Skip to contentSkip to conversation

of_flat_dt_match() helper build FAIL

DISCUSSION Benjamin Herrenschmidt 3 participants 3 messages Jan 21, 2011

lore
Share & tools
lore
#0 lore raw

a4f740cf33f7f6c164bbde3c0cdbcc77b0c4997c introduces:

/arch/powerpc/platforms/83xx/mpc831x_rdb.c:63: error: expected '{' before 'const'

and more...

This hunk is obviously bogus:

+struct const char *board[] __initdata = {
+ "MPC8313ERDB",
+ "fsl,mpc8315erdb",
+ NULL
+}
+

You should at least compile test your changes :-(

Please send Linus a fix.

Cheers,
Ben.

#1 lore raw

Hi Ben,

Quoted 17 lines · On Fri, 21 Jan 2011 13:15:22 +1100 Benjamin Herrenschmidt…

a4f740cf33f7f6c164bbde3c0cdbcc77b0c4997c introduces:

/arch/powerpc/platforms/83xx/mpc831x_rdb.c:63: error: expected '{' before 'const'

and more...

This hunk is obviously bogus:

(quoted diff) +6 -0
+struct const char *board[] __initdata = {
+	"MPC8313ERDB",
+	"fsl,mpc8315erdb",
+	NULL
+}
+
Quoted 3 lines

You should at least compile test your changes :-(

Please send Linus a fix.

Its already in Grant's devicetree/merge branch (which I assume he will ask you to pull soon) and has been in linux-next for the past 2 days.

Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
#2 lore raw
In reply to Benjamin Herrenschmidt
Quoted 16 lines · Benjamin Herrenschmidt

a4f740cf33f7f6c164bbde3c0cdbcc77b0c4997c introduces:

/arch/powerpc/platforms/83xx/mpc831x_rdb.c:63: error: expected '{' before 'const'

=A0and more...

This hunk is obviously bogus:

(quoted diff) +6 -0
+struct const char *board[] __initdata =3D {
+ =A0 =A0 =A0 "MPC8313ERDB",
+ =A0 =A0 =A0 "fsl,mpc8315erdb",
+ =A0 =A0 =A0 NULL
+}
+
Quoted 1 line

You should at least compile test your changes :-(

I do. Always. Over Christmas I even set up an autotest instance to automate a bunch of the sanity testing so I'd get better coverage, and I always get changes into linux-next, this commit included. Sometimes I miss a configuration though, and I apologize. Sorry.

Quoted 1 line

Please send Linus a fix.

I wrote and pushed out the fix yesterday and I just sent Linus the pull req= .

g.