Skip to contentSkip to conversation

busybox_1.18.2.bb: slugos needs a modified version of usb.sh script

PATCH In review Khem Raj 5 participants 10 messages Jan 21, 2011 – Jan 30, 2011

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 3/3 busybox_1.18.2.bb: slugos needs a modified version of usb.sh script

---
 recipes/busybox/busybox-1.18.2/slugos/usb.sh |   33 ++++++++++++++++++++++++++
 recipes/busybox/busybox_1.18.2.bb            |    2 +-
 2 files changed, 34 insertions(+), 1 deletions(-)
 create mode 100644 recipes/busybox/busybox-1.18.2/slugos/usb.sh
recipes/busybox/busybox-1.18.2/slugos/usb.sh new file +33 -0
new file mode 100644
index 0000000..172fdc6
@@ -0,0 +1,33 @@
+#!/bin/sh
+
+case "$ACTION" in
+  add|"")
+    for uevent in /sys/class/usb_endpoint/usbdev?.*/*/uevent; do
+      . $uevent
+      if [ ! -e /dev/bus/usb/$BUSNUM/$DEVNUM ]; then
+        mkdir -p /dev/bus/usb/$BUSNUM
+        mknod /dev/bus/usb/$BUSNUM/$DEVNUM c 189 $MINOR
+      fi
+    done
+    ;;
+  remove)
+    for device in /dev/bus/usb/*/*; do
+      REMOVED=1
+      dev=`basename $device`
+      bus=`basename $(dirname $device)`
+      for uevent in /sys/class/usb_endpoint/usbdev?.*/*/uevent; do
+        . $uevent
+        if [ $dev -eq $DEVNUM ] && [ $bus -eq $BUSNUM ]; then
+          REMOVED=0
+          break;
+        fi
+      done
+      if [ $REMOVED -eq 1 ]; then
+        rm /dev/bus/usb/$bus/$dev
+        if [ -z $(ls /dev/bus/usb/$bus/) ]; then
+          rmdir /dev/bus/usb/$bus/
+        fi
+      fi
+    done
+    ;;
+esac
recipes/busybox/busybox_1.18.2.bb +1 -1
index e6d17d3..7c47ab4 100644
@@ -1,5 +1,5 @@
 require busybox_1.1x.inc
-PR = "${INC_PR}.2"
+PR = "${INC_PR}.3"
 
 SRC_URI += " \
 	http://busybox.net/downloads/fixes-1.18.2/busybox-1.18.2-modprobe-small.patch;name=patch01 \
Signature · 1 line
1.7.2.3
#1 lore raw

Hi Khem,

Quoted 3 lines · Khem Raj
---
  recipes/busybox/busybox-1.18.2/slugos/usb.sh |   33 ++++++++++++++++++++++++++

Can't it become the generic script ? What makes it slugos specific ? (I didn't make a diff vs the other one so the question may be stupid ;-)

Thanks,
Eric

author
#2 lore raw
Quoted 4 lines · Eric Bénard

Hi Khem,

Quoted 1 line · Khem Raj
Quoted 8 lines
Quoted 4 lines

---
 recipes/busybox/busybox-1.18.2/slugos/usb.sh |   33
++++++++++++++++++++++++++

Can't it become the generic script ? What makes it slugos specific ? (I didn't make a diff vs the other one so the question may be stupid ;-)

you should have diffed them. uevents are stored in different directory on slugos

Quoted 8 lines

Thanks,
Eric

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

#3 lore raw
Quoted 10 lines · Khem Raj
Quoted 9 lines · Eric Bénard

Hi Khem,

Quoted 5 lines · Khem Raj
---
  recipes/busybox/busybox-1.18.2/slugos/usb.sh |   33

++++++++++++++++++++++++++

Quoted 6 lines
Quoted 3 lines

Can't it become the generic script ? What makes it slugos specific ? (I didn't make a diff vs the other one so the question may be stupid ;-)

you should have diffed them. uevents are stored in different directory on slugos

you could also put this in the commit log to prevent this diff to discover what is the change :-)

Eric

author
#4 lore raw
Quoted 17 lines · Eric Bénard
Quoted 16 lines · Khem Raj
Quoted 13 lines · Eric Bénard

Hi Khem,

Quoted 5 lines · Khem Raj

---
 recipes/busybox/busybox-1.18.2/slugos/usb.sh |   33
++++++++++++++++++++++++++

Can't it become the generic script ? What makes it slugos specific ? (I didn't make a diff vs the other one so the question may be stupid ;-)

Quoted 6 lines
Quoted 3 lines

you should have diffed them. uevents are stored in different directory on slugos

you could also put this in the commit log to prevent this diff to discover what is the change :-)

will do

Quoted 8 lines

Eric

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

#5 lore raw
In reply to Khem Raj
Quoted 10 lines · Khem Raj
Quoted 9 lines · Eric Bénard

Hi Khem,

Quoted 5 lines · Khem Raj
---
 recipes/busybox/busybox-1.18.2/slugos/usb.sh |   33

++++++++++++++++++++++++++

Quoted 5 lines
Quoted 3 lines

Can't it become the generic script ? What makes it slugos specific ? (I didn't make a diff vs the other one so the question may be stupid ;-)

you should have diffed them. uevents are stored in different directory on slugos

Isn't this kernel-specific, though? I don't have any other OE-based devices handy just now to check, but what's difference, specifically, and should we change something to bring SlugOS into line with the rest of the world?

-Mike (mwester)

author
#6 lore raw
Quoted 7 lines · Mike Westerhof

Isn't this kernel-specific, though?  I don't have any other OE-based devices handy just now to check, but what's difference, specifically, and should we change something to bring SlugOS into line with the rest of the world?

-Mike (mwester)

yes seems like slugos kernel enables.
CONFIG_SYSFS_DEPRECATED=y
CONFIG_SYSFS_DEPRECATED_V2=y

which enabled these. I havent tested the kernel by disabling them as I havent figured out how to boot a kernel from network on slug but if you can try that and see what /sys/class looks like that would help or if I find some time to make slug suck the kernel from a tftp then I can do it too.

#7 lore raw
Quoted 13 lines · Khem Raj
Quoted 7 lines · Mike Westerhof

Isn't this kernel-specific, though? I don't have any other OE-based devices handy just now to check, but what's difference, specifically, and should we change something to bring SlugOS into line with the rest of the world?

-Mike (mwester)

yes seems like slugos kernel enables.
CONFIG_SYSFS_DEPRECATED=y
CONFIG_SYSFS_DEPRECATED_V2=y

Quoted 5 lines

which enabled these. I havent tested the kernel by disabling them as I havent figured out how to boot a kernel from network on slug but if you can try that and see what /sys/class looks like that would help or if I find some time to make slug suck the kernel from a tftp then I can do it too.

Note that these kernel options also place an upper bound on what udev can be used and it's very much worth checking if they can be turned off.

Signature · 2 lines
Tom Rini
Mentor Graphics Corporation
#8 lore raw
Quoted 14 lines · Tom Rini
Quoted 13 lines · Khem Raj
Quoted 7 lines · Mike Westerhof

Isn't this kernel-specific, though? I don't have any other OE-based devices handy just now to check, but what's difference, specifically, and should we change something to bring SlugOS into line with the rest of the world?

-Mike (mwester)

yes seems like slugos kernel enables.
CONFIG_SYSFS_DEPRECATED=y
CONFIG_SYSFS_DEPRECATED_V2=y

Quoted 8 lines
Quoted 5 lines

which enabled these. I havent tested the kernel by disabling them as I havent figured out how to boot a kernel from network on slug but if you can try that and see what /sys/class looks like that would help or if I find some time to make slug suck the kernel from a tftp then I can do it too.

Note that these kernel options also place an upper bound on what udev can be used and it's very much worth checking if they can be turned off.

SlugOS has bumped up to a 2.6.29 kernel with the above CONFIG items disabled. (This is still a relatively old kernel, but I know that it basically works with SlugOS, so it's a good place to test mdev and, if anyone wants to, newer udevs.)

-Mike (mwester)

#9 lore raw
In reply to Khem Raj

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 6 lines · Khem Raj
Quoted 5 lines · Mike Westerhof

Isn't this kernel-specific, though? I don't have any other OE-based devices handy just now to check, but what's difference, specifically, and should we change something to bring SlugOS into line with the rest of the world?

Quoted 8 lines
Quoted 2 lines

-Mike (mwester)

yes seems like slugos kernel enables.
CONFIG_SYSFS_DEPRECATED=y
CONFIG_SYSFS_DEPRECATED_V2=y

which enabled these.

Good luck using udev >125 with those enabled.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNPUBlMkyGM64RGpERAtQ9AJ9uXJt3LkVLmFcdGtlzyXrkcS9GogCgsZd2 so8m83VyDJYV0ZRGbpxNrJA=
=DOKc
-----END PGP SIGNATURE-----