ASoC: Handle low measured DC offsets for wm_hubs devices
Subsystems (3)
PATCH 1/1 ASoC: Handle low measured DC offsets for wm_hubs devices
The DC servo codes are actually signed numbers so need to be treated as such.
Signed-off-by Mark Brown <[email protected]>
--- sound/soc/codecs/wm_hubs.c | 15 +++++++-------- 1 files changed, 7 insertions(+), 8 deletions(-)
sound/soc/codecs/wm_hubs.c +7 -8
@@ -91,6 +91,7 @@ static void wait_for_dc_servo(struct snd_soc_codec *codec, unsigned int op)static void calibrate_dc_servo (struct snd_soc_codec *codec) {struct wm_hubs_data *hubs =snd_soc_codec_get_drvdata (codec); +s8 offset;u16 reg, reg_l, reg_r, dcs_cfg;/* If we're using a digital only path and have a previously
@@ -149,16 +150,14 @@ static void calibrate_dc_servo(struct snd_soc_codec *codec) hubs->dcs_codes);/* HPOUT1L */ -if (reg_l + hubs->dcs_codes >0 && - reg_l + hubs->dcs_codes <0xff ) - reg_l += hubs->dcs_codes; - dcs_cfg = reg_l <<WM8993_DCS_DAC_WR_VAL_1_SHIFT ; + offset = reg_l; + offset += hubs->dcs_codes; + dcs_cfg = (u8 )offset <<WM8993_DCS_DAC_WR_VAL_1_SHIFT ;/* HPOUT1R */ -if (reg_r + hubs->dcs_codes >0 && - reg_r + hubs->dcs_codes <0xff ) - reg_r += hubs->dcs_codes; - dcs_cfg |= reg_r; + offset = reg_r; + offset += hubs->dcs_codes; + dcs_cfg |= (u8 )offset;dev_dbg (codec->dev,"DCS result: %x\n" , dcs_cfg);
Signature · 1 line
1.7.2.3
Quoted 8 lines · Mark Brown
The DC servo codes are actually signed numbers so need to be treated as such.
Signed-off-by Mark Brown <[email protected]>--- sound/soc/codecs/wm_hubs.c | 15 +++++++-------- 1 files changed, 7 insertions(+), 8 deletions(-)
Acked-by Liam Girdwood <[email protected]>
Signature · 3 lines
Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk