iio: imu: lsm6dsx: Fix mount matrix retrieval
Subsystems (2)
PATCH 1/1 iio: imu: lsm6dsx: Fix mount matrix retrieval
The function lsm6dsx_get_acpi_mount_matrix should return true when ACPI support is not enabled to allow executing iio_read_mount_matrix in the probe function.
--- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/imu/ renamed from drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c +0 -0
st_lsm6dsx/st_lsm6dsx_core.c
index 6a18b363cf73..62bc3ee783fb 100644
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c +0 -0
@@ -2687,7 +2687,7 @@ static int lsm6dsx_get_acpi_mount_matrix(struct device
*dev,
static int lsm6dsx_get_acpi_mount_matrix(struct device *dev,
structiio_mount_matrix *orientation)
{
- return false;
+ return true;
}
#endif
Signature · 1 line
2.41.0
Lorenzo Bianconi
maintainerQuoted 17 lines
The function
lsm6dsx_get_acpi_mount_matrixshould return true when ACPI support is not enabled to allow executingiio_read_mount_matrixin the probe function.Fixes dc3d25f22b88 ("iio: imu: lsm6dsx: Add ACPI mount matrix retrieval")Signed-off-by Alejandro Tafalla <[email protected]>--- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/iio/imu/ renamed from drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c +0
-0
st_lsm6dsx/st_lsm6dsx_core.c
index6a18b363cf73..62bc3ee783fb100644
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c static int lsm6dsx_get_acpi_mount_matrix(struct device · line 2692
Quoted 7 lines
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c +1
-1@@ -2687,7 +2687,7 @@ static int lsm6dsx_get_acpi_mount_matrix(struct device *dev, static int lsm6dsx_get_acpi_mount_matrix(struct device *dev,struct iio_mount_matrix *orientation) { -return false; +return true;
I would say it should return something like -EOPNOTSUPP.
Regards,
Lorenzo
Quoted 9 lines
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c +0
-0}#endif
Signature · 1 line
2.41.0
Quoted 28 lines · On miércoles, 12 de julio de 2023 13:04:05 (CEST) Lorenzo Bianconi wrote:
Quoted 28 lines
The function
lsm6dsx_get_acpi_mount_matrixshould return true when ACPI support is not enabled to allow executingiio_read_mount_matrixin the probe function.Fixes dc3d25f22b88 ("iio: imu: lsm6dsx: Add ACPI mount matrix retrieval")Signed-off-by Alejandro Tafalla <[email protected]>---
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0b/drivers/iio/imu/
st_lsm6dsx/st_lsm6dsx_core.c
index6a18b363cf73..62bc3ee783fb100644drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c +0
-0@@ -2687,7 +2687,7 @@ static int lsm6dsx_get_acpi_mount_matrix(structdevice *dev, static int lsm6dsx_get_acpi_mount_matrix(struct device *dev,struct iio_mount_matrix *orientation){
Quoted 11 lines
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
Quoted 2 lines
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c +1
-1-return false; +return true;I would say it should return something like
-EOPNOTSUPP.Regards,
LorenzoQuoted 3 lines
}
#endif
Hi, thank you for the review. I'll send a v2 with a better solution that uses error codes.
Alejandro.