msm gadget compilation failure with trout
Hi,
I've that:drivers/usb/gadget/ci13xxx_msm.c: In function 'ci13xxx_msm_notify_event':drivers/usb/gadget/ci13xxx_msm.c:42:3: error: 'USB_AHBBURST' undeclared (first use in this function) drivers/usb/gadget/ci13xxx_msm.c:42:3: note: each undeclared identifier is reported only once for each function it appears in drivers/usb/gadget/ci13xxx_msm.c:43:3: error: 'USB_AHBMODE' undeclared (first use in this function)
make[2]: *** [drivers/usb/gadget/ci13xxx_msm.o] Error 1 make[1]: *** [drivers/usb/gadget] Error 2
make[1]: *** Waiting for unfinished jobs....
here's my setup:
* linux-next/master
( git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git ) at 47db3d1b0b3d69c6e977158ac354a972b81677bd
* trout(also known as htc dream or G1) board
Should I include my defconfig?
Should I include more details?
Am I using the gadget wrong driver?
Denis.
Quoted 21 lines · Denis 'GNUtoo' Carikli
Hi,
I've that:
drivers/usb/gadget/ci13xxx_msm.c: In function 'ci13xxx_msm_notify_event':drivers/usb/gadget/ci13xxx_msm.c:42:3: error: 'USB_AHBBURST' undeclared (first use in this function)drivers/usb/gadget/ci13xxx_msm.c:42:3: note: each undeclared identifier is reported only once for each function it appears indrivers/usb/gadget/ci13xxx_msm.c:43:3: error: 'USB_AHBMODE' undeclared (first use in this function)
make[2]: *** [drivers/usb/gadget/ci13xxx_msm.o] Error 1 make[1]: *** [drivers/usb/gadget] Error 2
make[1]: *** Waiting for unfinished jobs....here's my setup:
* linux-next/master
(git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git) at47db3d1b0b3d69c6e977158ac354a972b81677bd
* trout(also known as htc dream or G1) board
Quoted 5 lines
Should I include my defconfig?
Should I include more details?
Am I using the gadget wrong driver?Denis.
Looks like it was cause by this commit,
commit e0c201f339fe7fc38d1b0f6f4755ff627686c7e0
Author: Pavankumar Kondeti <[email protected]> Date: Tue Dec 7 17:53:55 2010 +0530
USB: Add MSM OTG Controller driver
This driver implements PHY initialization, clock management, ULPI IO ops and simple OTG state machine to kick host/peripheral based on Id/VBUS line status. VBUS/Id lines are tied to a reference voltage on some boards. Hence provide debugfs interface to select host/peripheral mode.
I CC'd the people in the commit.. I have no idea what those values are support to be.
Daniel
Signature · 2 lines
Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
Hi Denis,
Quoted 22 lines · Daniel Walker
Quoted 21 lines · Denis 'GNUtoo' Carikli
Hi,
I've that:
drivers/usb/gadget/ci13xxx_msm.c: In function 'ci13xxx_msm_notify_event':drivers/usb/gadget/ci13xxx_msm.c:42:3: error: 'USB_AHBBURST' undeclared (first use in this function)drivers/usb/gadget/ci13xxx_msm.c:42:3: note: each undeclared identifier is reported only once for each function it appears indrivers/usb/gadget/ci13xxx_msm.c:43:3: error: 'USB_AHBMODE' undeclared (first use in this function)
make[2]: *** [drivers/usb/gadget/ci13xxx_msm.o] Error 1 make[1]: *** [drivers/usb/gadget] Error 2
make[1]: *** Waiting for unfinished jobs....here's my setup:
* linux-next/master
(git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git) at47db3d1b0b3d69c6e977158ac354a972b81677bd
* trout(also known as htc dream or G1) board
Quoted 4 lines
Quoted 4 lines
Should I include my defconfig?
Should I include more details?
Am I using the gadget wrong driver?
AHBMODE register offset is different for trout and AHBBURST register is not present in trout.
MSM gadget driver is supported only for QSD8x50 and MSM7x30 boards. USB support is not added for trout which uses an external PHY unlike the other targets. Please disable USB support in your defconfig.
Thanks,
Pavan
Signature · 2 lines
Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
Quoted 30 lines · Pavan Kondeti
Hi Denis,
Quoted 22 lines · Daniel Walker
Quoted 21 lines · Denis 'GNUtoo' Carikli
Hi,
I've that:
drivers/usb/gadget/ci13xxx_msm.c: In function 'ci13xxx_msm_notify_event':drivers/usb/gadget/ci13xxx_msm.c:42:3: error: 'USB_AHBBURST' undeclared (first use in this function)drivers/usb/gadget/ci13xxx_msm.c:42:3: note: each undeclared identifier is reported only once for each function it appears indrivers/usb/gadget/ci13xxx_msm.c:43:3: error: 'USB_AHBMODE' undeclared (first use in this function)
make[2]: *** [drivers/usb/gadget/ci13xxx_msm.o] Error 1 make[1]: *** [drivers/usb/gadget] Error 2
make[1]: *** Waiting for unfinished jobs....here's my setup:
* linux-next/master
(git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git) at47db3d1b0b3d69c6e977158ac354a972b81677bd
* trout(also known as htc dream or G1) boardQuoted 4 lines
Quoted 4 lines
Should I include my defconfig?
Should I include more details?
Am I using the gadget wrong driver?
Quoted 6 lines
AHBMODE register offset is different for trout and AHBBURST register is not present in trout.
MSM gadget driver is supported only for QSD8x50 and MSM7x30 boards. USB support is not added for trout which uses an external PHY unlike the other targets. Please disable USB support in your defconfig.
If it's not supported don't allow it to be compiled, but you need to make some sort of fix for this.
btw, if it's not support why is there a 7X01 define used in the header ?
Daniel
Signature · 3 lines
Sent by an consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
Quoted 34 lines · Daniel Walker
Quoted 33 lines · Pavan Kondeti
Hi Denis,
Quoted 22 lines · Daniel Walker
Quoted 21 lines · Denis 'GNUtoo' Carikli
Hi,
I've that:
drivers/usb/gadget/ci13xxx_msm.c: In function 'ci13xxx_msm_notify_event':drivers/usb/gadget/ci13xxx_msm.c:42:3: error: 'USB_AHBBURST' undeclared (first use in this function)drivers/usb/gadget/ci13xxx_msm.c:42:3: note: each undeclared identifier is reported only once for each function it appears indrivers/usb/gadget/ci13xxx_msm.c:43:3: error: 'USB_AHBMODE' undeclared (first use in this function)
make[2]: *** [drivers/usb/gadget/ci13xxx_msm.o] Error 1 make[1]: *** [drivers/usb/gadget] Error 2
make[1]: *** Waiting for unfinished jobs....here's my setup:
* linux-next/master
(git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git) at47db3d1b0b3d69c6e977158ac354a972b81677bd
* trout(also known as htc dream or G1) boardQuoted 4 lines
Quoted 4 lines
Should I include my defconfig?
Should I include more details?
Am I using the gadget wrong driver?AHBMODE register offset is different for trout and AHBBURST register is not present in trout.
Quoted 7 lines
Quoted 3 lines
MSM gadget driver is supported only for QSD8x50 and MSM7x30 boards. USB support is not added for trout which uses an external PHY unlike the other targets. Please disable USB support in your defconfig.
If it's not supported don't allow it to be compiled, but you need to make some sort of fix for this.
Agreed. I will submit a patch to fix this.
Quoted 2 lines
btw, if it's not support why is there a 7X01 define used in the header ?
Sorry. It should not have been there. It was a copy-paste mistake.
Signature · 2 lines
Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.