Skip to contentSkip to conversation

Patch to fix backlight on GM45

PATCH Peter Clifton 2 participants 3 messages Jan 28, 2011 – Feb 1, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Without this, querying the backlight value returns half of the value it has been set to. Hilarity ensues, as my user-space likes to query first before incrementing / decrementing brightness, leading to brightness collapsing to near as I try to adjust.

Signature · 11 lines
Peter Clifton

Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA

Tel: +44 (0)7729 980173 - (No signal in the lab!)
Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me)

From db647ad5ff5ce80e1a515411db7e4c6587c7e798 Mon Sep 17 00:00:00 2001
From: Peter Clifton <[email protected]>
Date: Fri, 28 Jan 2011 22:08:40 +0000
Subject: [PATCH] drm/intel: Fix brightness value query when in combination mode

---
 drivers/gpu/drm/i915/intel_panel.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/gpu/drm/i915/intel_panel.c +0 -1
index 4ab4239..1795823 100644
@@ -208,7 +208,6 @@ u32 intel_panel_get_backlight(struct drm_device *dev)
 			val &= ~1;
 			pci_read_config_byte(dev->pdev, PCI_LBPC, &lbpc);
 			val *= lbpc;
-			val >>= 1;
 		}
 	}
 
Signature · 1 line
1.7.2.3

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#1 lore raw

Il 28/01/2011 23:13, Peter Clifton ha scritto:

Quoted 4 lines

Without this, querying the backlight value returns half of the value it has been set to. Hilarity ensues, as my user-space likes to query first before incrementing / decrementing brightness, leading to brightness collapsing to near as I try to adjust.

I have this problem too. I will try your patch.

Darkbasic

#2 lore raw
In reply to Peter Clifton

Il 28/01/2011 23:13, Peter Clifton ha scritto:

Quoted 4 lines

Without this, querying the backlight value returns half of the value it has been set to. Hilarity ensues, as my user-space likes to query first before incrementing / decrementing brightness, leading to brightness collapsing to near as I try to adjust.

It works flawlessly, thank you! Unfortunately I have not been able to apply the attached patch (for unknown reasons), so I modified the file manually.

Will it ever be merged into drm-intel? Intel-drm-fixes is still bugged...

Darkbasic