staging: zcache: fix memory leak
PATCH 1/1 staging: zcache: fix memory leak
obj is not freed if __get_free_page() failed.
Signed-off-by Vasiliy Kulikov <[email protected]>
---
Compile tested only.
drivers/staging/zcache/zcache.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/staging/zcache/zcache.c +1 -0
@@ -790,6 +790,7 @@ static int zcache_do_preload(struct tmem_pool *pool) page = (void *)__get_free_page (ZCACHE_GFP_MASK );if (unlikely (page ==NULL )) { zcache_failed_get_free_pages++; +kmem_cache_free (zcache_obj_cache, obj); goto unlock_out; }preempt_disable ();
Signature · 1 line
1.7.0.4
Quoted 6 lines
From: Vasiliy Kulikov [mailto:[email protected]]
Sent: Thursday, February 10, 2011 11:01 AMobj is not freed if
__get_free_page()failed.Signed-off-by Vasiliy Kulikov <[email protected]>
Thanks Vasiliy! Good catch!
Quoted 16 lines
drivers/staging/zcache/zcache.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)drivers/staging/zcache/zcache.c +1
-0@@ -790,6 +790,7 @@ static int zcache_do_preload(struct tmem_pool *pool) page = (void *)__get_free_page (ZCACHE_GFP_MASK );if (unlikely (page ==NULL )) { zcache_failed_get_free_pages++; +kmem_cache_free (zcache_obj_cache, obj); goto unlock_out; }
Quoted 1 line
preempt_disable();
Acked-by Dan Magenheimer <[email protected]>