Skip to contentSkip to conversation

Fix cx23885 and cx25840 regressions

GIT FIXES for 2.6.38 Andy Walls 2 participants 4 messages Feb 14, 2011 – Feb 26, 2011 Media (V4L/DVB)

lore
Share & tools
lore

Andy Walls

author
#0 lore raw

Mauro,

Please pull the following regression fixes (and related compiler squawk fix) for 2.6.38.

Thanks go to Sven Barth for reporting the regression with the CX2583x chips in cx25840 and providing a patch.

Thanks also go to Mark Zimmerman for climinb the git learning curve and devoting the time perform a git bisect to isolate the cx23885 regression.

Regards,
Andy

The following changes since commit cf720fed25b8078ce0d6a10036dbf7a0baded679:

[media] add support for Encore FM3 (2011-01-19 16:42:42 -0200)

are available in the git repository at:
ssh://linuxtv.org/git/awalls/media_tree.git cx-fix-38

Andy Walls (2):
cx23885: Revert "Check for slave nack on all transactions"
cx23885: Remove unused 'err:' labels to quiet compiler warning

Sven Barth (1):

      cx25840: fix probing of cx2583x chips
 drivers/media/video/cx23885/cx23885-i2c.c  |   10 ----------
 drivers/media/video/cx25840/cx25840-core.c |    3 ++-
 2 files changed, 2 insertions(+), 11 deletions(-)
#1 lore raw
Quoted 11 lines · Andy Walls

Mauro,

Please pull the following regression fixes (and related compiler squawk fix) for 2.6.38.

Thanks go to Sven Barth for reporting the regression with the CX2583x chips in cx25840 and providing a patch.

Thanks also go to Mark Zimmerman for climinb the git learning curve and devoting the time perform a git bisect to isolate the cx23885 regression.

Please add

to the signed-off-by section of patches which should be applied to stable kernel trees. That way you ensure they will actually make it to the stable trees.

Quoted 9 lines

The following changes since commit cf720fed25b8078ce0d6a10036dbf7a0baded679:

[media] add support for Encore FM3 (2011-01-19 16:42:42 -0200)

are available in the git repository at:
ssh://linuxtv.org/git/awalls/media_tree.git cx-fix-38

Andy Walls (2):
cx23885: Revert "Check for slave nack on all transactions"

Thanks for fixing my mistakes!

Quoted 8 lines

cx23885: Remove unused 'err:' labels to quiet compiler warning

Sven Barth (1):

      cx25840: fix probing of cx2583x chips
 drivers/media/video/cx23885/cx23885-i2c.c  |   10 ----------
 drivers/media/video/cx25840/cx25840-core.c |    3 ++-
 2 files changed, 2 insertions(+), 11 deletions(-)
Signature · 1 line
Jean Delvare
author
#2 lore raw
Quoted 5 lines · Jean Delvare
Quoted 2 lines

Andy Walls (2):
cx23885: Revert "Check for slave nack on all transactions"

Thanks for fixing my mistakes!

Jean,

No problem.

I was the one who actually asked for your patch to go in without checking the hardware behavior carefully. So I jointly own the mistake. :) I'll shoulder some of the blame.

Regards,
Andy

author
#3 lore raw

[UPDATED] [GIT FIXES for 2.6.38] Fix cx23885 and cx25840 regressions, fix ivtv DMA error handling, and add new cx18 board profile.

In reply to Andy Walls

Mauro,

Please pull the following fixes for 2.6.38. This is a resend of my original pull request with two additional patches.

Thanks go to Sven Barth for reporting the regression with the CX2583x chips in cx25840 and providing a patch.

Thanks also go to Mark Zimmerman for climing the git learning curve and devoting the time perform a git bisect to isolate the cx23885 regression.

Thanks go to Michael for perform some excellent reasoning and working up a patch to correct a long standing problem with the way the ivtv driver deals with certain DMA Errors. Thanks also go to Pete for testing Mike's patch. (I have altered Michael's original patch slightly, to clear status errors only when it should be safe to do so without hanging the DMA engine.)

Thanks to Devin and Hauppauge for adding a new board profile for the latest HVR-1600 designs having a different DTV tuner and demodulator.

I think that's everyone...

Regards,
Andy

The following changes since commit cf720fed25b8078ce0d6a10036dbf7a0baded679:

[media] add support for Encore FM3 (2011-01-19 16:42:42 -0200)

are available in the git repository at:
ssh://linuxtv.org/git/awalls/media_tree.git cx-fix-38

Andy Walls (2):
cx23885: Revert "Check for slave nack on all transactions"
cx23885: Remove unused 'err:' labels to quiet compiler warning

Devin Heitmueller (1):
cx18: Add support for Hauppauge HVR-1600 models with s5h1411

Michael (1):
ivtv: Fix corrective action taken upon DMA ERR interrupt to avoid hang

Sven Barth (1):

      cx25840: fix probing of cx2583x chips
 drivers/media/video/cx18/cx18-cards.c      |   50 +++++++++++++++++++++++-
 drivers/media/video/cx18/cx18-driver.c     |   25 +++++++++++-
 drivers/media/video/cx18/cx18-driver.h     |    3 +-
 drivers/media/video/cx18/cx18-dvb.c        |   38 ++++++++++++++++++
 drivers/media/video/cx23885/cx23885-i2c.c  |   10 -----
 drivers/media/video/cx25840/cx25840-core.c |    3 +-
 drivers/media/video/ivtv/ivtv-irq.c        |   58 ++++++++++++++++++++++++---
 7 files changed, 165 insertions(+), 22 deletions(-)