xfs_repair: inode flags check should use flags
PATCH 1/1 xfs_repair: inode flags check should use flags
From: Dave Chinner <[email protected]>
The RT bitmap inode format flag check should use the flag, not the bit definition. As a result, it is incorrectly detecting inodes with the prealloc flag set as has having an invalid bit set.
--- repair/dinode.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
repair/dinode.c +2 -2
@@ -2551,11 +2551,11 @@ process_dinode_int(xfs_mount_t *mp, XFS_DIFLAG_RTINHERIT); } } -if (flags &XFS_DIFLAG_NEWRTBM_BIT ) { +if (flags &XFS_DIFLAG_NEWRTBM ) {/* must be a rt bitmap inode */ if (lino != mp->m_sb.sb_rbmino) {do_warn (_ ("inode %llu not rt bitmap" ), lino); - flags &= ~XFS_DIFLAG_NEWRTBM_BIT ; + flags &= ~XFS_DIFLAG_NEWRTBM ; } } if (flags & (XFS_DIFLAG_RTINHERIT |
Signature · 6 lines
1.7.2.3 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Quoted 7 lines · Dave Chinner
From: Dave Chinner <[email protected]>
The RT bitmap inode format flag check should use the flag, not the bit definition. As a result, it is incorrectly detecting inodes with the prealloc flag set as has having an invalid bit set.
Signed-off-by Dave Chinner <[email protected]>
Looks good.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 7 lines · Alex Elder
Quoted 6 lines · Dave Chinner
From: Dave Chinner <[email protected]>
The RT bitmap inode format flag check should use the flag, not the bit definition. As a result, it is incorrectly detecting inodes with the prealloc flag set as has having an invalid bit set.
Quoted 5 lines
Quoted 1 line
Signed-off-by Dave Chinner <[email protected]>Looks good.
Reviewed-by Alex Elder <[email protected]>
pushed.
Cheers,
Dave.
Signature · 7 lines
Dave Chinner [email protected] _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs