PTI Makefile and Kconfig additions.
PATCH 4/10 PTI Makefile and Kconfig additions.
From: J Freyensee <[email protected]>
This allows the Intel implementation of the PTI standard to be compiled and configured in Kconfig.
--- drivers/misc/Kconfig | 12 ++++++++++++ drivers/misc/Makefile | 1 + 2 files changed, 13 insertions(+), 0 deletions(-)
drivers/misc/Kconfig +12 -0
@@ -136,6 +136,18 @@ config PHANTOM If you choose to build module, its name will be phantom. If unsure, say N here. +config INTEL_MID_PTI + tristate "Parallel Trace Interface for MIPI P1149.7 cJTAG standard" + help + The PTI (Parallel Trace Interface) driver directs + trace data routed from various parts in the system out + through an Intel Penwell PTI port and out of the mobile + device for analysis with a debugging tool (Lauterbach or Fido). + + You should select this driver if the target kernel is meant for + an Intel Atom (non-netbook) mobile device containing a MIPI + P1149.7 standard implementation. + config SGI_IOC4 tristate "SGI IOC4 Base IO support" depends on PCI
drivers/misc/Makefile +1 -0
@@ -6,6 +6,7 @@ obj-$(CONFIG_IBM_ASM) += ibmasm/ obj-$(CONFIG_AD525X_DPOT) += ad525x_dpot.o obj-$(CONFIG_AD525X_DPOT_I2C) += ad525x_dpot-i2c.o obj-$(CONFIG_AD525X_DPOT_SPI) += ad525x_dpot-spi.o +obj-$(CONFIG_INTEL_MID_PTI) += pti.o obj-$(CONFIG_ATMEL_PWM) += atmel_pwm.o obj-$(CONFIG_ATMEL_SSC) += atmel-ssc.o obj-$(CONFIG_ATMEL_TCLIB) += atmel_tclib.o
Signature · 1 line
1.7.2.3
Arnd Bergmann
maintainerQuoted 7 lines · On Thursday 24 February 2011, [email protected] wrote:
From: J Freyensee <[email protected]>
This allows the Intel implementation of the PTI standard to be compiled and configured in
Kconfig.Signed-off-by J Freyensee <[email protected]>
This belongs together with the pti.c file, just merge the patches into one.
The Kconfig description is a nice text, how about copying it to the changeset so that reviewers know what the driver is about?
Arnd
Quoted 9 lines · Arnd Bergmann
Quoted 7 lines · On Thursday 24 February 2011, [email protected] wrote:
From: J Freyensee <[email protected]>
This allows the Intel implementation of the PTI standard to be compiled and configured in
Kconfig.Signed-off-by J Freyensee <[email protected]>
Quoted 7 lines
This belongs together with the
pti.cfile, just merge the patches into one.The
Kconfigdescription is a nice text, how about copying it to the changeset so that reviewers know what the driver is about?Arnd
I thought patch 02/10, 'Kernel documentation', would had been first and met this need?
Arnd Bergmann
maintainerQuoted 8 lines · J Freyensee
Quoted 3 lines · Arnd Bergmann
The
Kconfigdescription is a nice text, how about copying it to the changeset so that reviewers know what the driver is about?I thought patch 02/10, 'Kernel documentation', would had been first and met this need?
Documentation in source files is not the same as documentation in the changelog, you need both. The changeset comments are usually just one sentence in your series, and a little more would certainly be helpful.
Also, if you have one changeset with the documentation, that does not help anyone who looks at another changeset.
Arnd
Quoted 7 lines · Arnd Bergmann
Quoted 6 lines · J Freyensee
Quoted 3 lines · Arnd Bergmann
The
Kconfigdescription is a nice text, how about copying it to the changeset so that reviewers know what the driver is about?
Quoted 7 lines
Quoted 2 lines
I thought patch 02/10, 'Kernel documentation', would had been first and met this need?
Documentation in source files is not the same as documentation in the changelog, you need both. The changeset comments are usually just one sentence in your series, and a little more would certainly be helpful.
Okay, I can do that.
Thanks,
Jay
Quoted 4 lines
Also, if you have one changeset with the documentation, that does not help anyone who looks at another changeset.
Arnd