Skip to contentSkip to conversation

mm: <asm-generic/pgtable.h> must include <linux/mm_types.h>

PATCH New Ben Hutchings 1 participant 1 message Feb 27, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm: <asm-generic/pgtable.h> must include <linux/mm_types.h>

Commit e2cda322648122dc400c85ada80eaddbc612ef6a 'thp: add pmd mangling generic functions' replaced some macros in <asm-generic/pgtable.h> with inline functions. If the functions are to be defined (not all architectures need them) then struct vm_area_struct must be defined first. So include <linux/mm_types.h>.

Fixes a build failure seen in Debian:

CC [M] drivers/media/dvb/mantis/mantis_pci.o
In file included from /build/buildd-linux-2.6_2.6.38~rc6-1~experimental.1-armel-6J2ga4/linux-2.6-2.6.38~rc6/debian/build/source_armel_none/arch/arm/include/asm/pgtable.h:460,

                 from /build/buildd-linux-2.6_2.6.38~rc6-1~experimental.1-armel-6J2ga4/linux-2.6-2.6.38~rc6/debian/build/source_armel_none/drivers/media/dvb/mantis/mantis_pci.c:25:

/build/buildd-linux-2.6_2.6.38~rc6-1~experimental.1-armel-6J2ga4/linux-2.6-2.6.38~rc6/debian/build/source_armel_none/include/asm-generic/pgtable.h: In function 'ptep_test_and_clear_young':
/build/buildd-linux-2.6_2.6.38~rc6-1~experimental.1-armel-6J2ga4/linux-2.6-2.6.38~rc6/debian/build/source_armel_none/include/asm-generic/pgtable.h:29: error: dereferencing pointer to incomplete type

---
 include/asm-generic/pgtable.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
include/asm-generic/pgtable.h +2 -0
index 31b6188..b4bfe33 100644
@@ -4,6 +4,8 @@
 #ifndef __ASSEMBLY__
 #ifdef CONFIG_MMU
 
+#include <linux/mm_types.h>
+
 #ifndef __HAVE_ARCH_PTEP_SET_ACCESS_FLAGS
 extern int ptep_set_access_flags(struct vm_area_struct *vma,
 				 unsigned long address, pte_t *ptep,
Signature · 9 lines
1.7.4.1


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>