Skip to contentSkip to conversation

qt-4.7.1 phonon/gstreamer RGB fix

PATCH New Marc Reilly 2 participants 4 messages Feb 28, 2011 – Mar 1, 2011

lore
Share & tools
lore
#0 lore raw

Hi,

This fixes a colour issue with video playback via phonon on ARM system.

Cheers
Marc

#1 lore raw

PATCH 1/1 qt-4.7.1: patch gstreamer phonon plugin to use host rgb endianess

This patch was obtained from Nokia bug tracker.
Without it, the R and B channels are wrong when playing on ARM system.

---
 recipes/qt4/qt-4.7.1.inc                           |    1 +
 .../0010-phonon-gstreamer-rgb-endianess.patch      |   23 ++++++++++++++++++++
 2 files changed, 24 insertions(+), 0 deletions(-)
 create mode 100644 recipes/qt4/qt-4.7.1/0010-phonon-gstreamer-rgb-endianess.patch
recipes/qt4/qt-4.7.1.inc +1 -0
index ef54753..be7275d 100644
@@ -9,6 +9,7 @@ SRC_URI = "\
     file://hack-out-pg2-4.7.0.patch \
 	file://0006-freetype-host-includes.patch \
 	file://0001-Added-Openembedded-crossarch-option.patch \
+	file://0010-phonon-gstreamer-rgb-endianess.patch \
 	file://g++.conf \
 	file://linux.conf \
            "
recipes/qt4/qt-4.7.1/0010-phonon-gstreamer-rgb-endianess.patch new file +23 -0
new file mode 100644
index 0000000..d43366c
@@ -0,0 +1,23 @@
+--- a/src/3rdparty/phonon/gstreamer/qwidgetvideosink.cpp
++++ b/src/3rdparty/phonon/gstreamer/qwidgetvideosink.cpp
+@@ -18,6 +18,7 @@
+ #include <QApplication>
+ #include "videowidget.h"
+ #include "qwidgetvideosink.h"
++#include <gst/video/video.h>
+ 
+ QT_BEGIN_NAMESPACE
+ 
+@@ -106,11 +107,7 @@ static GstStaticPadTemplate template_factory_rgb =
+     GST_STATIC_PAD_TEMPLATE("sink",
+                             GST_PAD_SINK,
+                             GST_PAD_ALWAYS,
+-                            GST_STATIC_CAPS("video/x-raw-rgb, "
+-                                            "framerate = (fraction) [ 0, MAX ], "
+-                                            "width = (int) [ 1, MAX ], "
+-                                            "height = (int) [ 1, MAX ],"
+-                                            "bpp = (int) 32"));
++                            GST_STATIC_CAPS(GST_VIDEO_CAPS_xRGB_HOST_ENDIAN));
+ 
+ template <VideoFormat FMT>
+ struct template_factory; 
Signature · 1 line
1.7.1
#3 lore raw
Quoted 10 lines · Denis 'GNUtoo' Carikli
Quoted 6 lines · Marc Reilly

Hi,

This fixes a colour issue with video playback via phonon on ARM system.

Cheers
Marc

Hi, I didn't see any patches, did I miss them?

Denis.

Ah sorry they were sent to the mailing list,
Not my day.

Denis.