thinkpad-acpi: module autoloading for newer Lenovo ThinkPads.

PATCH In review Manoj Iyer 2 participants 6 messages Mar 7, 2011 – Mar 18, 2011 x86 platform drivers

Share & tools

Manoj Iyer

author

2011-03-07 23:27 UTC #0 lore raw

PATCH 1/1 thinkpad-acpi: module autoloading for newer Lenovo ThinkPads.

Please consider the following patch that adds support for auto loading thinkpad_acpi module on newer Lenovo ThinkPads that have HKEY HID set to LEN0068 instead of IBM0068.

==== dsdt.dsl =============================================

                    Device (HKEY)
                    {
                        Name (_HID, EisaId ("LEN0068"))
                        Method (_STA, 0, NotSerialized)
                        {
                            Return (0x0F)
                        }

============================================================

This patch was tested on a Lenovo x120e.

Thank you
Manoj Iyer

Manoj Iyer

author

2011-03-07 23:27 UTC #1 lore raw

PATCH 1/1 thinkpad-acpi: module autoloading for newer Lenovo ThinkPads.

The newer Lenovo ThinkPads have HKEY HID of LEN0068 instead of IBM0068. Added new HID so that thinkpad_acpi module will auto load on these newer Lenovo ThinkPads.

Signed-off-by Manoj Iyer <[email protected]>

---
 drivers/platform/x86/thinkpad_acpi.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

drivers/platform/x86/thinkpad_acpi.c +4 -2

index eb99223..125d891 100644
@@ -128,7 +128,8 @@ enum {
 };
 
 /* ACPI HIDs */
-#define TPACPI_ACPI_HKEY_HID		"IBM0068"
+#define TPACPI_ACPI_IBM_HKEY_HID	"IBM0068"
+#define TPACPI_ACPI_LENOVO_HKEY_HID	"LEN0068"
 #define TPACPI_ACPI_EC_HID		"PNP0C09"
 
 /* Input IDs */

@@ -3879,7 +3880,8 @@ errexit:
 }
 
 static const struct acpi_device_id ibm_htk_device_ids[] = {
-	{TPACPI_ACPI_HKEY_HID, 0},
+	{TPACPI_ACPI_IBM_HKEY_HID, 0},
+	{TPACPI_ACPI_LENOVO_HKEY_HID, 0},
 	{"", 0},
 };

Signature · 1 line

1.7.1

Henrique de Moraes Holschuh

Acked-by on v1 1/1

2011-03-08 12:41 UTC #2 lore raw

Quoted 5 lines · Manoj Iyer

The newer Lenovo ThinkPads have HKEY HID of LEN0068 instead of IBM0068. Added new HID so that thinkpad_acpi module will auto load on these newer Lenovo ThinkPads.
Signed-off-by Manoj Iyer <[email protected]>

Acked-by Henrique de Moraes Holschuh <[email protected]>

Quoted 23 lines

drivers/platform/x86/thinkpad_acpi.c +4 -2

index eb99223..125d891 100644
@@ -128,7 +128,8 @@ enum {
 };
 
 /* ACPI HIDs */
-#define TPACPI_ACPI_HKEY_HID		"IBM0068"
+#define TPACPI_ACPI_IBM_HKEY_HID	"IBM0068"
+#define TPACPI_ACPI_LENOVO_HKEY_HID	"LEN0068"
 #define TPACPI_ACPI_EC_HID		"PNP0C09"
 
 /* Input IDs */

@@ -3879,7 +3880,8 @@ errexit:
 }
 
 static const struct acpi_device_id ibm_htk_device_ids[] = {
-	{TPACPI_ACPI_HKEY_HID, 0},
+	{TPACPI_ACPI_IBM_HKEY_HID, 0},
+	{TPACPI_ACPI_LENOVO_HKEY_HID, 0},
 	{"", 0},
 };

Signature · 4 lines

  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Manoj Iyer

author

2011-03-18 18:09 UTC #3 lore raw

Henrique,

Thanks the ack on the patch, any idea when this will be Q'ed for linus tree ?

-----------------------------------------------------
Manoj Iyer
Ubuntu/Canonical
Hardware Enablement Team
------------------------------------------------------

Quoted 39 lines · Henrique de Moraes Holschuh

Quoted 5 lines · Manoj Iyer
The newer Lenovo ThinkPads have HKEY HID of LEN0068 instead of IBM0068. Added new HID so that thinkpad_acpi module will auto load on these newer Lenovo ThinkPads.
Signed-off-by Manoj Iyer <[email protected]>
Acked-by Henrique de Moraes Holschuh <[email protected]>
Quoted 15 lines
drivers/platform/x86/thinkpad_acpi.c +2 -1
index eb99223..125d891 100644
@@ -128,7 +128,8 @@ enum {
  };
 
  /* ACPI HIDs */
-#define TPACPI_ACPI_HKEY_HID         "IBM0068"
+#define TPACPI_ACPI_IBM_HKEY_HID     "IBM0068"
+#define TPACPI_ACPI_LENOVO_HKEY_HID  "LEN0068"
  #define TPACPI_ACPI_EC_HID           "PNP0C09"
 
  /* Input IDs */
drivers/platform/x86/thinkpad_acpi.c errexit: · line 3886
Quoted 8 lines
drivers/platform/x86/thinkpad_acpi.c +2 -1
@@ -3879,7 +3880,8 @@ errexit:
  }
 
  static const struct acpi_device_id ibm_htk_device_ids[] = {
-     {TPACPI_ACPI_HKEY_HID, 0},
+     {TPACPI_ACPI_IBM_HKEY_HID, 0},
+     {TPACPI_ACPI_LENOVO_HKEY_HID, 0},
       {"", 0},
  };
--
"One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh

Henrique de Moraes Holschuh

2011-03-08 00:43 UTC #4 lore raw

In reply to Manoj Iyer

Quoted 3 lines · Manoj Iyer

Please consider the following patch that adds support for auto loading thinkpad_acpi module on newer Lenovo ThinkPads that have HKEY HID set to LEN0068 instead of IBM0068.

Does the driver do anything useful on these Lenovo thinkpads?

Signature · 4 lines

  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Manoj Iyer

author

2011-03-08 01:23 UTC #5 lore raw

Absolutely, it enables hotkeys on a host of new Lenovo thinkpads, x120e, T420, T520 etc.

-----------------------------------------------------
Manoj Iyer
Ubuntu/Canonical
Hardware Enablement Team
------------------------------------------------------

Quoted 18 lines · Henrique de Moraes Holschuh

Quoted 3 lines · Manoj Iyer
Please consider the following patch that adds support for auto loading thinkpad_acpi module on newer Lenovo ThinkPads that have HKEY HID set to LEN0068 instead of IBM0068.
Does the driver do anything useful on these Lenovo thinkpads?
--
"One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/