Skip to contentSkip to conversation

fb_imageblit semantic

DISCUSSION Petr Vandrovec 2 participants 2 messages Mar 14, 2003 Framebuffer layer

lore
Share & tools
lore
#0 lore raw
Quoted 5 lines · Geert Uytterhoeven
Quoted 3 lines · Petr Vandrovec

Why do you pass image.depth == 16 (or 24 or 32) to fb_imageblit when logo image is in reality always 8bpp, as quick look at cfb_imageblit revealed?

Quoted 7 lines

Should indeed be 8.

Quoted 3 lines

Should I just assume that image.depth == 1 means that data are 1bpp with fgcol/bgcol valid, and all other depths mean 8bpp input?

This was changed from 1 to 0 in James' latest tree.

WTF? Color depth 0 means that whole picture is single-color, and imageblit degenerates to rectfill in such case. Please, either use 'depth' as source image color depth, or do not name it depth.
Petr Vandrovec

-------------------------------------------------------
This SF.net email is sponsored by:Crypto Challenge is now open! Get cracking and register here for some mind boggling fun and the chance of winning an Apple iPod:
http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en

#1 lore raw
Quoted 12 lines · Petr Vandrovec
Quoted 11 lines · Geert Uytterhoeven
Quoted 3 lines · Petr Vandrovec

Why do you pass image.depth == 16 (or 24 or 32) to fb_imageblit when logo image is in reality always 8bpp, as quick look at cfb_imageblit revealed?

Should indeed be 8.

Quoted 3 lines

Should I just assume that image.depth == 1 means that data are 1bpp with fgcol/bgcol valid, and all other depths mean 8bpp input?

Quoted 5 lines
Quoted 1 line

This was changed from 1 to 0 in James' latest tree.

WTF? Color depth 0 means that whole picture is single-color, and imageblit degenerates to rectfill in such case. Please, either use 'depth' as source image color depth, or do not name it depth.

It's 0 (expand [bf]gcol) to differentiate from 1 (copy monochrome).

Splitting imageblit into separate routines for both operations would be trivial, though.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

-------------------------------------------------------
This SF.net email is sponsored by:Crypto Challenge is now open! Get cracking and register here for some mind boggling fun and the chance of winning an Apple iPod:
http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en