Skip to contentSkip to conversation

Fixed the format: lines over 80 characters .

PATCH NAK [email protected] 4 participants 6 messages Mar 27, 2011 – Mar 28, 2011 Multifunction devices (MFD)

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 Fixed the format: lines over 80 characters .

From: Wanlong Gao <[email protected]>

Lines over 80 characters
FILE: janz-cmodio.c:273

Signed-off-by Wanlong Gao <[email protected]>
---
 drivers/mfd/janz-cmodio.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
drivers/mfd/janz-cmodio.c +4 -2
index 36a166b..fb29d23 100644
@@ -270,8 +270,10 @@ static void __devexit cmodio_pci_remove(struct pci_dev *dev)
 
 /* The list of devices that this module will support */
 static DEFINE_PCI_DEVICE_TABLE(cmodio_pci_ids) = {
-	{ PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030, PCI_VENDOR_ID_JANZ, 0x0101 },
-	{ PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050, PCI_VENDOR_ID_JANZ, 0x0100 },
+	{ PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030,
+			PCI_VENDOR_ID_JANZ, 0x0101 },
+	{ PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050,
+			PCI_VENDOR_ID_JANZ, 0x0100 },
 	{ 0, }
 };
 MODULE_DEVICE_TABLE(pci, cmodio_pci_ids);
Signature · 1 line
1.7.3
NAK
#1 lore raw

drivers/mfd/janz-cmodio.c static void __devexit cmodio_pci_remove(struct pci_dev *dev) · line 276

Quoted 9 lines · On Sun, Mar 27, 2011 at 11:07:24AM +0800, [email protected] wrote:

Lines over 80 characters

static DEFINE_PCI_DEVICE_TABLE(cmodio_pci_ids) = {

drivers/mfd/janz-cmodio.c +4 -2
-	{ PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030, PCI_VENDOR_ID_JANZ, 0x0101 },
-	{ PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050, PCI_VENDOR_ID_JANZ, 0x0100 },
+	{ PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030,
+			PCI_VENDOR_ID_JANZ, 0x0101 },
+	{ PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050,
+			PCI_VENDOR_ID_JANZ, 0x0100 },

NAK, this is less readable.

author NAK
#2 lore raw

I see, thanks .

------------------
wanlong.gao
2011-03-27

-------------------------------------------------------------
发件人：Alexey Dobriyan
发送日期：2011-03-27 21:54:05
收件人：wanlong.gao
抄送：greg; harryxiyou; linux-kernel
主题：Re: [PATCH] Fixed the format: lines over 80 characters .

drivers/mfd/janz-cmodio.c static void __devexit cmodio_pci_remove(struct pci_dev *dev) · line 276

Quoted 9 lines · On Sun, Mar 27, 2011 at 11:07:24AM +0800, [email protected] wrote:

Lines over 80 characters

static DEFINE_PCI_DEVICE_TABLE(cmodio_pci_ids) = {

drivers/mfd/janz-cmodio.c +4 -2
-	{ PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030, PCI_VENDOR_ID_JANZ, 0x0101 },
-	{ PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050, PCI_VENDOR_ID_JANZ, 0x0100 },
+	{ PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030,
+			PCI_VENDOR_ID_JANZ, 0x0101 },
+	{ PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050,
+			PCI_VENDOR_ID_JANZ, 0x0100 },

NAK, this is less readable. �翳簕.n�+壏煯壄�+%娝�遍荻w�簕.n�+壏{炳G珴�妠ay�蕠跈�,jf＂穐殢飦�戧鐉_璁(殠娸"濟�m���G珴�⒏?櫒璀�&ｘ忈秈O曟瑉窔v豝�m��� �鹅�⒏?朓�

author NAK
#3 lore raw
In reply to Alexey Dobriyan

But if you read the code in the 80 columns screen , isn't it less readable with the code over 80 characters ?

-------------------------------------------------------------
发件人：Alexey Dobriyan
发送日期：2011-03-27 21:54:05
收件人：wanlong.gao
抄送：greg; harryxiyou; linux-kernel
主题：Re: [PATCH] Fixed the format: lines over 80 characters .

drivers/mfd/janz-cmodio.c static void __devexit cmodio_pci_remove(struct pci_dev *dev) · line 276

Quoted 9 lines · On Sun, Mar 27, 2011 at 11:07:24AM +0800, [email protected] wrote:

Lines over 80 characters

static DEFINE_PCI_DEVICE_TABLE(cmodio_pci_ids) = {

drivers/mfd/janz-cmodio.c +4 -2
-	{ PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030, PCI_VENDOR_ID_JANZ, 0x0101 },
-	{ PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050, PCI_VENDOR_ID_JANZ, 0x0100 },
+	{ PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030,
+			PCI_VENDOR_ID_JANZ, 0x0101 },
+	{ PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050,
+			PCI_VENDOR_ID_JANZ, 0x0100 },

NAK, this is less readable. �翳簕.n�+壏煯壄�+%娝�遍荻w�簕.n�+壏{炳G珴�妠ay�蕠跈�,jf＂穐殢飦�戧鐉_璁(殠娸"濟�m���G珴�⒏?櫒璀�&ｘ忈秈O曟瑉窔v豝�m��� �鹅�⒏?朓�

#4 lore raw
Quoted 3 lines · wanlong.gao

But if you read the code in the 80 columns screen , isn't it less readable with the code over 80 characters ?

I too agree that it is less readable. Even if I read it in a 80 col screen (which I seldom do), I could easily scroll to the right. This is not code, its a table, and having each item on its own row makes it much easier to read what field goes with what item.

-- Steve

Acked-by
#5 lore raw
In reply to Alexey Dobriyan
Quoted 4 lines · Alexey Dobriyan
Quoted 3 lines · On Sun, Mar 27, 2011 at 11:07:24AM +0800, [email protected] wrote:

Lines over 80 characters

Signed-off-by Wanlong Gao <[email protected]>
Acked-by Harry Wei <[email protected]>
Quoted 1 line

NAK, this is less readable.

Hi Alexey,
I don't know how above patch decreases the readable for us.
Well, we should recognize it may be less readable after cleaning the lines, which are over 80 characters. But this is well for me.

Quoted 5 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/