Skip to contentSkip to conversation

net/9p: nwname should be an unsigned int

PATCH In review Harsh Prateek Bora 2 participants 2 messages Mar 30, 2011 – Mar 31, 2011

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/9p: nwname should be an unsigned int

---
 include/net/9p/client.h |    2 +-
 net/9p/client.c         |    6 +++---
 net/9p/protocol.c       |    4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)
include/net/9p/client.h +1 -1
index 0a30977..31e5343 100644
@@ -218,7 +218,7 @@ void p9_client_disconnect(struct p9_client *clnt);
 void p9_client_begin_disconnect(struct p9_client *clnt);
 struct p9_fid *p9_client_attach(struct p9_client *clnt, struct p9_fid *afid,
 					char *uname, u32 n_uname, char *aname);
-struct p9_fid *p9_client_walk(struct p9_fid *oldfid, int nwname, char **wnames,
+struct p9_fid *p9_client_walk(struct p9_fid *oldfid, uint16_t nwname, char **wnames,
 								int clone);
 int p9_client_open(struct p9_fid *fid, int mode);
 int p9_client_fcreate(struct p9_fid *fid, char *name, u32 perm, int mode,
net/9p/client.c +3 -3
index 2ccbf04..1af4afb 100644
@@ -929,7 +929,7 @@ error:
 }
 EXPORT_SYMBOL(p9_client_attach);
 
-struct p9_fid *p9_client_walk(struct p9_fid *oldfid, int nwname, char **wnames,
+struct p9_fid *p9_client_walk(struct p9_fid *oldfid, uint16_t nwname, char **wnames,
 	int clone)
 {
 	int err;
@@ -937,7 +937,7 @@ struct p9_fid *p9_client_walk(struct p9_fid *oldfid, int nwname, char **wnames,
 	struct p9_fid *fid;
 	struct p9_qid *wqids;
 	struct p9_req_t *req;
-	int16_t nwqids, count;
+	uint16_t nwqids, count;
 
 	err = 0;
 	wqids = NULL;
@@ -955,7 +955,7 @@ struct p9_fid *p9_client_walk(struct p9_fid *oldfid, int nwname, char **wnames,
 		fid = oldfid;
 
 
-	P9_DPRINTK(P9_DEBUG_9P, ">>> TWALK fids %d,%d nwname %d wname[0] %s\n",
+	P9_DPRINTK(P9_DEBUG_9P, ">>> TWALK fids %d,%d nwname %ud wname[0] %s\n",
 		oldfid->fid, fid->fid, nwname, wnames ? wnames[0] : NULL);
 
 	req = p9_client_rpc(clnt, P9_TWALK, "ddT", oldfid->fid, fid->fid,
net/9p/protocol.c +2 -2
index 8a4084f..0573b9b 100644
@@ -265,7 +265,7 @@ p9pdu_vreadf(struct p9_fcall *pdu, int proto_version, const char *fmt,
 			}
 			break;
 		case 'T':{
-				int16_t *nwname = va_arg(ap, int16_t *);
+				uint16_t *nwname = va_arg(ap, uint16_t *);
 				char ***wnames = va_arg(ap, char ***);
 
 				errcode = p9pdu_readf(pdu, proto_version,
@@ -495,7 +495,7 @@ p9pdu_vwritef(struct p9_fcall *pdu, int proto_version, const char *fmt,
 			}
 			break;
 		case 'T':{
-				int16_t nwname = va_arg(ap, int);
+				uint16_t nwname = va_arg(ap, int);
 				const char **wnames = va_arg(ap, const char **);
 
 				errcode = p9pdu_writef(pdu, proto_version, "w",
Signature · 1 line
1.7.1.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 1 line · Harsh Prateek Bora
Quoted 72 lines
---
  include/net/9p/client.h |    2 +-
  net/9p/client.c         |    6 +++---
  net/9p/protocol.c       |    4 ++--
  3 files changed, 6 insertions(+), 6 deletions(-)
include/net/9p/client.h +1 -1
index 0a30977..31e5343 100644
@@ -218,7 +218,7 @@ void p9_client_disconnect(struct p9_client *clnt);
  void p9_client_begin_disconnect(struct p9_client *clnt);
  struct p9_fid *p9_client_attach(struct p9_client *clnt, struct p9_fid *afid,
  					char *uname, u32 n_uname, char *aname);
-struct p9_fid *p9_client_walk(struct p9_fid *oldfid, int nwname, char **wnames,
+struct p9_fid *p9_client_walk(struct p9_fid *oldfid, uint16_t nwname, char **wnames,
  								int clone);
  int p9_client_open(struct p9_fid *fid, int mode);
  int p9_client_fcreate(struct p9_fid *fid, char *name, u32 perm, int mode,
net/9p/client.c +3 -3
index 2ccbf04..1af4afb 100644
@@ -929,7 +929,7 @@ error:
  }
  EXPORT_SYMBOL(p9_client_attach);
 
-struct p9_fid *p9_client_walk(struct p9_fid *oldfid, int nwname, char **wnames,
+struct p9_fid *p9_client_walk(struct p9_fid *oldfid, uint16_t nwname, char **wnames,
  	int clone)
  {
  	int err;
@@ -937,7 +937,7 @@ struct p9_fid *p9_client_walk(struct p9_fid *oldfid, int nwname, char **wnames,
  	struct p9_fid *fid;
  	struct p9_qid *wqids;
  	struct p9_req_t *req;
-	int16_t nwqids, count;
+	uint16_t nwqids, count;
 
  	err = 0;
  	wqids = NULL;
@@ -955,7 +955,7 @@ struct p9_fid *p9_client_walk(struct p9_fid *oldfid, int nwname, char **wnames,
  		fid = oldfid;
 
 
-	P9_DPRINTK(P9_DEBUG_9P, ">>>  TWALK fids %d,%d nwname %d wname[0] %s\n",
+	P9_DPRINTK(P9_DEBUG_9P, ">>>  TWALK fids %d,%d nwname %ud wname[0] %s\n",
  		oldfid->fid, fid->fid, nwname, wnames ? wnames[0] : NULL);
 
  	req = p9_client_rpc(clnt, P9_TWALK, "ddT", oldfid->fid, fid->fid,
net/9p/protocol.c +2 -2
index 8a4084f..0573b9b 100644
@@ -265,7 +265,7 @@ p9pdu_vreadf(struct p9_fcall *pdu, int proto_version, const char *fmt,
  			}
  			break;
  		case 'T':{
-				int16_t *nwname = va_arg(ap, int16_t *);
+				uint16_t *nwname = va_arg(ap, uint16_t *);
  				char ***wnames = va_arg(ap, char ***);
 
  				errcode = p9pdu_readf(pdu, proto_version,
@@ -495,7 +495,7 @@ p9pdu_vwritef(struct p9_fcall *pdu, int proto_version, const char *fmt,
  			}
  			break;
  		case 'T':{
-				int16_t nwname = va_arg(ap, int);
+				uint16_t nwname = va_arg(ap, int);
  				const char **wnames = va_arg(ap, const char **);
 
  				errcode = p9pdu_writef(pdu, proto_version, "w",