] eio: New recipe for eio
PATCH 1/2 ] eio: New recipe for eio
--- recipes/efl1/eio.inc | 11 +++++++++++ recipes/efl1/eio_svn.bb | 13 +++++++++++++ 2 files changed, 24 insertions(+), 0 deletions(-) create mode 100644 recipes/efl1/eio.inc create mode 100644 recipes/efl1/eio_svn.bb
recipes/efl1/eio.inc new file +11 -0
@@ -0,0 +1,11 @@ +DESCRIPTION = "Enlightenment Input Output Library" +LICENSE = "MIT BSD" +DEPENDS = "ecore eina" + +inherit efl + +BBCLASSEXTEND = "native" +INC_PR = "r0" + +# Some upgrade path tweaking +AUTO_LIBNAME_PKGS = ""
recipes/efl1/eio_svn.bb new file +13 -0
@@ -0,0 +1,13 @@ +require eio.inc + +SRCREV = "${EFL_SRCREV}" +PV = "0.1.0+svnr${SRCPV}" +PR = "${INC_PR}.0" +DEFAULT_PREFERENCE = "-1" + +LIC_FILES_CHKSUM = "file://COPYING;md5=403f20cf42c847686ac2956f14bfa30f" + +SRC_URI = "\ + ${E_SVN}/trunk;module=${SRCNAME};proto=http;scmdata=keep \ +" +S = "${WORKDIR}/${SRCNAME}"
Signature · 1 line
1.7.2.5
Am Donnerstag, den 31.03.2011, 22:39 +0300 schrieb Philippe De Swert:
»eio: add initial recipe (svn)« or something like that would be a better commit summary in my opinion.
Quoted 15 lines
Signed-off-by Philippe De Swert <[email protected]>--- recipes/efl1/eio.inc | 11 +++++++++++ recipes/efl1/eio_svn.bb | 13 +++++++++++++ 2 files changed, 24 insertions(+), 0 deletions(-) create mode 100644 recipes/efl1/eio.inc create mode 100644 recipes/efl1/eio_svn.bbrecipes/efl1/eio.inc new file +1
-0@@ -0,0 +1,11 @@ +DESCRIPTION = "Enlightenment Input Output Library"
recipes/efl1/eio.inc line 11
Quoted 10 lines
recipes/efl1/eio.inc new file +10
-0+LICENSE = "MIT BSD" +DEPENDS = "ecore eina" + +inherit efl + +BBCLASSEXTEND = "native" +INC_PR = "r0" + +# Some upgrade path tweaking +AUTO_LIBNAME_PKGS = ""
What upgrade patch?
recipes/efl1/eio_svn.bb line 6
Quoted 12 lines
recipes/efl1/eio_svn.bb new file +6
-0@@ -0,0 +1,13 @@ +require eio.inc + +SRCREV = "${EFL_SRCREV}" +PV = "0.1.0+svnr${SRCPV}" +PR = "${INC_PR}.0" +DEFAULT_PREFERENCE = "-1"
It is the only recipe, so DP = "-1" should not be useful.
recipes/efl1/eio_svn.bb line 13
Quoted 6 lines
recipes/efl1/eio_svn.bb new file +6
-0+LIC_FILES_CHKSUM = "file://COPYING;md5=403f20cf42c847686ac2956f14bfa30f" + +SRC_URI = "\ + ${E_SVN}/trunk;module=${SRCNAME};proto=http;scmdata=keep \ +" +S = "${WORKDIR}/${SRCNAME}"
Thanks,
Paul
Hi Paul,
Thanks for the review.
Quoted 4 lines · Paul Menzel
Am Donnerstag, den 31.03.2011, 22:39 +0300 schrieb Philippe De Swert:
»eio: add initial recipe (svn)« or something like that would be a better commit summary in my opinion.
I'll keep that in mind
Quoted 5 lines
recipes/efl1/eio.inc line 11
Quoted 3 lines
recipes/efl1/eio.inc new file +3
-0+ +# Some upgrade path tweaking +AUTO_LIBNAME_PKGS = ""What upgrade patch?
Yeah I should have double checked that... Just put it there as all the other enlightenment
.inc files had it.
Quoted 6 lines
Quoted 6 lines
recipes/efl1/eio_svn.bb new file +0
-0@@ -0,0 +1,13 @@
Quoted 8 lines
recipes/efl1/eio_svn.bb line 6
Quoted 6 lines
recipes/efl1/eio_svn.bb new file +6
-0+require eio.inc + +SRCREV = "${EFL_SRCREV}" +PV = "0.1.0+svnr${SRCPV}" +PR = "${INC_PR}.0" +DEFAULT_PREFERENCE = "-1"It is the only recipe, so
DP = "-1"should not be useful.
Just wanted to be future proof for when the actual versioned recipes come.
Cheers,
Philippe
Dear Philippe,
Am Freitag, den 01.04.2011, 10:25 +0300 schrieb Philippe De Swert:
Quoted 1 line
Thanks for the review.
No problem.
Quoted 7 lines · Paul Menzel
Quoted 4 lines
Am Donnerstag, den 31.03.2011, 22:39 +0300 schrieb Philippe De Swert:
»eio: add initial recipe (svn)« or something like that would be a better commit summary in my opinion.
I'll keep that in mind
Additionally »[PATCH [1/2]]« seems to confuse git am to use
] eio: New recipe for eio
as the commit summary. So only no nested brackets please.
I found one other problem. The license is LGPL 2.1+ and not MIT or BSD [1].
Quoted 8 lines
Quoted 5 lines
recipes/efl1/eio.inc line 11
Quoted 3 lines
recipes/efl1/eio.inc new file +3
-0+ +# Some upgrade path tweaking +AUTO_LIBNAME_PKGS = ""What upgrade patch?
Yeah I should have double checked that... Just put it there as all the other enlightenment .inc files had it.
Maybe Martin can comment on that.
Quoted 15 lines
Quoted 6 lines
Quoted 6 lines
recipes/efl1/eio_svn.bb new file +0
-0@@ -0,0 +1,13 @@Quoted 8 lines
recipes/efl1/eio_svn.bb line 6
Quoted 6 lines
recipes/efl1/eio_svn.bb new file +6
-0+require eio.inc + +SRCREV = "${EFL_SRCREV}" +PV = "0.1.0+svnr${SRCPV}" +PR = "${INC_PR}.0" +DEFAULT_PREFERENCE = "-1"It is the only recipe, so
DP = "-1"should not be useful.
Quoted 1 line
Just wanted to be future proof for when the actual versioned recipes come.
I think it should be adapted if there is a recipe for a released version.
Please resend the patch as [PATCH 1/2 v2] after Martin has commented.
Thanks,
Paul
[1] http://trac.enlightenment.org/e/browser/trunk/eio/COPYING?rev=57852
Quoted 32 lines · Paul Menzel
Dear Philippe,
Am Freitag, den 01.04.2011, 10:25 +0300 schrieb Philippe De Swert:
Quoted 1 line
Thanks for the review.
No problem.
Quoted 7 lines · Paul Menzel
Quoted 4 lines
Am Donnerstag, den 31.03.2011, 22:39 +0300 schrieb Philippe De Swert:
»eio: add initial recipe (svn)« or something like that would be a better commit summary in my opinion.
I'll keep that in mind
Additionally »[PATCH [1/2]]« seems to confuse
git amto use] eio: New recipe for eio
as the commit summary. So only no nested brackets please.
I found one other problem. The license is LGPL 2.1+ and not MIT or BSD [1].
Quoted 6 lines
Quoted 5 lines
recipes/efl1/eio.inc line 11
Quoted 3 lines
recipes/efl1/eio.inc new file +3
-0+ +# Some upgrade path tweaking +AUTO_LIBNAME_PKGS = ""What upgrade patch?
Quoted 4 lines
Quoted 2 lines
Yeah I should have double checked that... Just put it there as all the other enlightenment .inc files had it.
Maybe Martin can comment on that.
Don't know if eio will part in next efl release (1.1.0 probably), but libeio-ver-pre-svn-09 is not nice package name anyways, so I vote to keep it for future upgrade path :).
Quoted 16 lines
Quoted 16 lines
Quoted 15 lines
recipes/efl1/eio_svn.bb line 6
Quoted 13 lines
recipes/efl1/eio_svn.bb new file +6
-0@@ -0,0 +1,13 @@ +require eio.inc + +SRCREV = "${EFL_SRCREV}" +PV = "0.1.0+svnr${SRCPV}" +PR = "${INC_PR}.0" +DEFAULT_PREFERENCE = "-1"It is the only recipe, so
DP = "-1"should not be useful.
Quoted 1 line
Quoted 1 line
Just wanted to be future proof for when the actual versioned recipes come.
Also fine with DP = "-1" (even on only one version in this case) in case there will be eio_1.1.0.bb
Quoted 4 lines
I think it should be adapted if there is a recipe for a released version.
Please resend the patch as [PATCH 1/2 v2] after Martin has commented.
For me, just fix LICENSE and I'm fine with it (just overlooked license in off-list review).
Cheers,
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]