Skip to contentSkip to conversation

ASoC: Remove excessively verbose logging on I2C write

PATCH In review Mark Brown 2 participants 2 messages Apr 4, 2011 – Apr 5, 2011

Subsystems (2)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 ASoC: Remove excessively verbose logging on I2C write

We don't need to log every I2C transfer, and certainly not at error level.

---
 sound/soc/soc-cache.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
sound/soc/soc-cache.c +0 -1
index 22b0990..5655fce 100644
@@ -245,7 +245,6 @@ static unsigned int do_i2c_read(struct snd_soc_codec *codec,
 	xfer[1].buf = data;
 
 	ret = i2c_transfer(client->adapter, xfer, 2);
-	dev_err(&client->dev, "i2c_transfer() returned %d\n", ret);
 	if (ret == 2)
 		return 0;
 	else if (ret < 0)
Signature · 1 line
1.7.4.1
Acked-by on v1 1/1
#1 lore raw
Quoted 12 lines · Mark Brown

We don't need to log every I2C transfer, and certainly not at error level.

---
 sound/soc/soc-cache.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
sound/soc/soc-cache.c +0 -0
index 22b0990..5655fce 100644

sound/soc/soc-cache.c static unsigned int do_i2c_read(struct snd_soc_codec *codec, · line 250

Quoted 7 lines
sound/soc/soc-cache.c +0 -1
@@ -245,7 +245,6 @@ static unsigned int do_i2c_read(struct snd_soc_codec *codec,
 	xfer[1].buf = data;
 
 	ret = i2c_transfer(client->adapter, xfer, 2);
-	dev_err(&client->dev, "i2c_transfer() returned %d\n", ret);
 	if (ret == 2)
 		return 0;
 	else if (ret < 0)