netfilter: xt_conntrack: fix inverted conntrack direction test
Subsystems (2)
PATCH 1/1 netfilter: xt_conntrack: fix inverted conntrack direction test
--ctdir ORIGINAL matches REPLY packets, and vv:
userspace sets "invert_flags &= ~XT_CONNTRACK_DIRECTION" in ORIGINAL case.
Thus: (CTINFO2DIR(ctinfo) == IP_CT_DIR_ORIGINAL) ^
!!(info->invert_flags & XT_CONNTRACK_DIRECTION))
yields "1 ^ 0", which is true -> returns false.
Reproducer:
iptables -I OUTPUT 1 -p tcp --syn -m conntrack --ctdir ORIGINAL
Signed-off-by Florian Westphal <[email protected]>
--- net/netfilter/xt_conntrack.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
net/netfilter/xt_conntrack.c +1 -1
@@ -195,7 +195,7 @@ conntrack_mt(const struct sk_buff *skb, struct xt_action_param *par,return info->match_flags &XT_CONNTRACK_STATE ;if ((info->match_flags &XT_CONNTRACK_DIRECTION ) && (CTINFO2DIR (ctinfo) ==IP_CT_DIR_ORIGINAL ) ^ - !!(info->invert_flags &XT_CONNTRACK_DIRECTION )) + !(info->invert_flags &XT_CONNTRACK_DIRECTION ))return false;if (info->match_flags &XT_CONNTRACK_ORIGSRC )
Signature · 1 line
1.7.3.4
Patrick McHardy
AppliedQuoted 5 lines · Florian Westphal
--ctdir ORIGINAL matches REPLY packets, and vv:
userspace sets "
invert_flags&= ~XT_CONNTRACK_DIRECTION" in ORIGINAL case.
Quoted 7 lines
Thus: (CTINFO2DIR(ctinfo) ==
IP_CT_DIR_ORIGINAL) ^!!(info->invert_flags & XT_CONNTRACK_DIRECTION))yields "1 ^ 0", which is true -> returns false.
Reproducer:
iptables -I OUTPUT 1 -p tcp --syn -m conntrack --ctdir ORIGINAL
Applied, thanks Florian.