Skip to contentSkip to conversation

tests: Fix duplicate 'kms_flip_event_leak' entry in tests/Makefile.sources

PATCH In review Shuang He 2 participants 5 messages Apr 8, 2015 – Apr 9, 2015

lore
Share & tools
lore

Shuang He

author
#0 lore raw

PATCH 1/1 tests: Fix duplicate 'kms_flip_event_leak' entry in tests/Makefile.sources

Or, it will cause piglit failure to run I-G-T test case

---
 tests/Makefile.sources | 1 -
 1 file changed, 1 deletion(-)
tests/Makefile.sources +0 -1
index 3e3aa57..aded08f 100644
@@ -85,7 +85,6 @@ TESTS_progs_M = \
 	kms_flip \
 	kms_flip_event_leak \
 	kms_flip_tiling \
-	kms_flip_event_leak \
 	kms_mmio_vs_cs_flip \
 	kms_pipe_b_c_ivb \
 	kms_pipe_crc_basic \
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 3 lines · Shuang He

Or, it will cause piglit failure to run I-G-T test case

How does it fail? And please fix the time on your machine, date on the mail is 2011 ;-)
-Daniel

Quoted 23 lines
---
 tests/Makefile.sources | 1 -
 1 file changed, 1 deletion(-)
tests/Makefile.sources +0 -1
index 3e3aa57..aded08f 100644
@@ -85,7 +85,6 @@ TESTS_progs_M = \
 	kms_flip \
 	kms_flip_event_leak \
 	kms_flip_tiling \
-	kms_flip_event_leak \
 	kms_mmio_vs_cs_flip \
 	kms_pipe_b_c_ivb \
 	kms_pipe_crc_basic \
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
author
#2 lore raw
Quoted 9 lines

-----Original Message-----
From: Daniel Vetter [mailto:[email protected]] On Behalf Of Daniel Vetter
Sent: Wednesday, April 8, 2015 4:15 PM
To: He, Shuang
Cc: [email protected]
Subject: Re: [Intel-gfx] [PATCH] tests: Fix duplicate 'kms_flip_event_leak' entry in tests/Makefile.sources

Quoted 7 lines
Quoted 3 lines · Shuang He

Or, it will cause piglit failure to run I-G-T test case

How does it fail? And please fix the time on your machine, date on the mail is 2011 ;-)

[He, Shuang] Piglit is now checking duplicate case name. and duplicate 'kms_flip_event_leak' in I-G-T will directly lead piglit abort testing from start. Following are output of it:
./piglit-run.py -d tests/igt.py t
Error: A test has already been asigned the name: igt@kms_flip_event_leak
and both tests are the same.

Thanks
--Shuang

Quoted 21 lines

-Daniel

Quoted 19 lines
---
 tests/Makefile.sources | 1 -
 1 file changed, 1 deletion(-)
tests/Makefile.sources +0 -2
index 3e3aa57..aded08f 100644
@@ -85,7 +85,6 @@ TESTS_progs_M = \
 	kms_flip \
 	kms_flip_event_leak \
 	kms_flip_tiling \
-	kms_flip_event_leak \
 	kms_mmio_vs_cs_flip \
 	kms_pipe_b_c_ivb \
 	kms_pipe_crc_basic \
--

1.9.1

Quoted 9 lines
Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

author
#3 lore raw
Quoted 22 lines

-----Original Message-----
From: He, Shuang
Sent: Wednesday, April 8, 2015 4:16 PM
To: Daniel Vetter
Cc: [email protected]
Subject: RE: [Intel-gfx] [PATCH] tests: Fix duplicate 'kms_flip_event_leak' entry in tests/Makefile.sources

Quoted 14 lines

-----Original Message-----
From: Daniel Vetter [mailto:[email protected]] On Behalf Of Daniel Vetter
Sent: Wednesday, April 8, 2015 4:15 PM
To: He, Shuang
Cc: [email protected]
Subject: Re: [Intel-gfx] [PATCH] tests: Fix duplicate 'kms_flip_event_leak' entry in tests/Makefile.sources

Quoted 3 lines · Shuang He

Or, it will cause piglit failure to run I-G-T test case

Quoted 8 lines
Quoted 2 lines

How does it fail? And please fix the time on your machine, date on the mail is 2011 ;-)

[He, Shuang] Piglit is now checking duplicate case name. and duplicate 'kms_flip_event_leak' in I-G-T will directly lead piglit abort testing from start. Following are output of it:
./piglit-run.py -d tests/igt.py t
Error: A test has already been asigned the name: igt@kms_flip_event_leak and both tests are the same.

[He, Shuang] Could anyone follow up this one? It's blocking our testing, though we could kind of work around it.

Thanks
--Shuang

Quoted 33 lines

Thanks
--Shuang

Quoted 30 lines

-Daniel

Quoted 19 lines
---
 tests/Makefile.sources | 1 -
 1 file changed, 1 deletion(-)
tests/Makefile.sources +0 -2
index 3e3aa57..aded08f 100644
@@ -85,7 +85,6 @@ TESTS_progs_M = \
 	kms_flip \
 	kms_flip_event_leak \
 	kms_flip_tiling \
-	kms_flip_event_leak \
 	kms_mmio_vs_cs_flip \
 	kms_pipe_b_c_ivb \
 	kms_pipe_crc_basic \
--

1.9.1

Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
Quoted 24 lines · Shuang
Quoted 24 lines

-----Original Message-----
From: He, Shuang
Sent: Wednesday, April 8, 2015 4:16 PM
To: Daniel Vetter
Cc: [email protected]
Subject: RE: [Intel-gfx] [PATCH] tests: Fix duplicate 'kms_flip_event_leak' entry in tests/Makefile.sources

Quoted 16 lines

-----Original Message-----
From: Daniel Vetter [mailto:[email protected]] On Behalf Of Daniel Vetter
Sent: Wednesday, April 8, 2015 4:15 PM
To: He, Shuang
Cc: [email protected]
Subject: Re: [Intel-gfx] [PATCH] tests: Fix duplicate 'kms_flip_event_leak' entry in tests/Makefile.sources

Quoted 3 lines · Shuang He

Or, it will cause piglit failure to run I-G-T test case

How does it fail? And please fix the time on your machine, date on the mail is 2011 ;-)

Quoted 7 lines
Quoted 6 lines

[He, Shuang] Piglit is now checking duplicate case name. and duplicate 'kms_flip_event_leak' in I-G-T will directly lead piglit abort testing from start. Following are output of it:
./piglit-run.py -d tests/igt.py t
Error: A test has already been asigned the name: igt@kms_flip_event_leak and both tests are the same.

[He, Shuang] Could anyone follow up this one? It's blocking our testing, though we could kind of work around it.

Sorry I forgot to push out the patch, done now.
-Daniel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx