Skip to contentSkip to conversation

ASoC: Remove default settings from Tegra Kconfig

PATCH In review Mark Brown 2 participants 2 messages Apr 21, 2011

Subsystems (3)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 ASoC: Remove default settings from Tegra Kconfig

There needs to be a strong reason for overriding the Kconfig default.

---
 sound/soc/tegra/Kconfig |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
sound/soc/tegra/Kconfig +0 -3
index a759fbe..0f5bd82 100644
@@ -1,14 +1,12 @@
 config SND_SOC_TEGRA
 	tristate "SoC Audio for the Tegra System-on-Chip"
 	depends on ARCH_TEGRA && TEGRA_SYSTEM_DMA
-	default m
 	help
 	  Say Y or M here if you want support for SoC audio on Tegra.
 
 config SND_SOC_TEGRA_I2S
 	tristate
 	depends on SND_SOC_TEGRA
-	default m
 	help
 	  Say Y or M if you want to add support for codecs attached to the
 	  Tegra I2S interface. You will also need to select the individual
@@ -25,7 +23,6 @@ config SND_SOC_TEGRA_WM8903
 	tristate "SoC Audio support for Tegra boards using a WM8903 codec"
 	depends on SND_SOC_TEGRA && I2C
 	depends on MACH_HAS_SND_SOC_TEGRA_WM8903
-	default m
 	select SND_SOC_TEGRA_I2S
 	select SND_SOC_WM8903
 	help
Signature · 1 line
1.7.4.1
Acked-by on v1 1/1
#1 lore raw

Mark Brown wrote at Thursday, April 21, 2011 5:03 AM:

Quoted 3 lines

There needs to be a strong reason for overriding the Kconfig default.

Hmmm. I must have chosen the wrong thing to copy. But looking at the existing ASoC Kconfig files, I have no idea where I got it from.

Quoted 33 lines
---
 sound/soc/tegra/Kconfig |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
sound/soc/tegra/Kconfig +0 -4
index a759fbe..0f5bd82 100644
@@ -1,14 +1,12 @@
 config SND_SOC_TEGRA
 	tristate "SoC Audio for the Tegra System-on-Chip"
 	depends on ARCH_TEGRA && TEGRA_SYSTEM_DMA
-	default m
 	help
 	  Say Y or M here if you want support for SoC audio on Tegra.
 
 config SND_SOC_TEGRA_I2S
 	tristate
 	depends on SND_SOC_TEGRA
-	default m
 	help
 	  Say Y or M if you want to add support for codecs attached to the
 	  Tegra I2S interface. You will also need to select the individual
@@ -25,7 +23,6 @@ config SND_SOC_TEGRA_WM8903
 	tristate "SoC Audio support for Tegra boards using a WM8903 codec"
 	depends on SND_SOC_TEGRA && I2C
 	depends on MACH_HAS_SND_SOC_TEGRA_WM8903
-	default m
 	select SND_SOC_TEGRA_I2S
 	select SND_SOC_WM8903
 	help
--

1.7.4.1

Signature · 1 line
nvpublic