Skip to contentSkip to conversation

Documentation/filesystems/inotify.txt edits

PATCH In review Aaron Faanes 2 participants 6 messages Apr 25, 2011 Documentation

lore
Share & tools
lore
#0 lore raw

cover Documentation/filesystems/inotify.txt edits

Some minor proofreading changes in inotify.txt.

Aaron Faanes (3):
Documentation: remove some spurious spaces in inotify.txt
Documentation: Correct a couple missing words in inotify.txt
Documentation: Reword example about inotify's fd-per-instance design

 Documentation/filesystems/inotify.txt |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
Signature · 1 line
1.7.4.4
#1 lore raw

PATCH 1/3 Documentation: remove some spurious spaces in inotify.txt

---
 Documentation/filesystems/inotify.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Documentation/filesystems/inotify.txt +1 -1
index 59a919f..f00c435 100644
@@ -250,7 +250,7 @@ A: An fd-per-watch quickly consumes more file descriptors than are allowed,
    scales to 1000s of directories, juggling 1000s of fd's just does not seem
    the right interface.  It is too heavy.
 
-   Additionally, it _is_ possible to  more than one instance  and
+   Additionally, it _is_ possible to more than one instance and
    juggle more than one queue and thus more than one associated fd.  There
    need not be a one-fd-per-process mapping; it is one-fd-per-queue and a
    process can easily want more than one queue.
Signature · 1 line
1.7.4.4
#2 lore raw

Re: [PATCH 1/3] Documentation: remove some spurious spaces in inotify.txt

Quoted 10 lines · On Sun, 24 Apr 2011 19:35:02 -0500 Aaron Faanes wrote:
---
 Documentation/filesystems/inotify.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Documentation/filesystems/inotify.txt +0 -0
index 59a919f..f00c435 100644

Documentation/filesystems/inotify.txt A: An fd-per-watch quickly consumes more file descriptors than are allowed, · line 253

Quoted 5 lines
Documentation/filesystems/inotify.txt +1 -1
@@ -250,7 +250,7 @@ A: An fd-per-watch quickly consumes more file descriptors than are allowed,
    scales to 1000s of directories, juggling 1000s of fd's just does not seem
    the right interface.  It is too heavy.
 
-   Additionally, it _is_ possible to  more than one instance  and
+   Additionally, it _is_ possible to more than one instance and

Isn't there at least one word missing here?

Documentation/filesystems/inotify.txt A: An fd-per-watch quickly consumes more file descriptors than are allowed, · line 256

Quoted 4 lines
Documentation/filesystems/inotify.txt +0 -0
    juggle more than one queue and thus more than one associated fd.  There
    need not be a one-fd-per-process mapping; it is one-fd-per-queue and a
    process can easily want more than one queue.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

#3 lore raw

PATCH 2/3 Documentation: Correct a couple missing words in inotify.txt

In reply to Aaron Faanes
---
 Documentation/filesystems/inotify.txt |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Documentation/filesystems/inotify.txt +2 -2
index f00c435..8d8cba1 100644
@@ -248,9 +248,9 @@ A: An fd-per-watch quickly consumes more file descriptors than are allowed,
 
    When you talk about designing a file change notification system that
    scales to 1000s of directories, juggling 1000s of fd's just does not seem
-   the right interface.  It is too heavy.
+   to be the right interface.  It is too heavy.
 
-   Additionally, it _is_ possible to more than one instance and
+   Additionally, it _is_ possible to have more than one instance and
    juggle more than one queue and thus more than one associated fd.  There
    need not be a one-fd-per-process mapping; it is one-fd-per-queue and a
    process can easily want more than one queue.
Signature · 1 line
1.7.4.4
#4 lore raw

Re: [PATCH 2/3] Documentation: Correct a couple missing words in inotify.txt

Quoted 10 lines · On Sun, 24 Apr 2011 19:35:03 -0500 Aaron Faanes wrote:
---
 Documentation/filesystems/inotify.txt |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Documentation/filesystems/inotify.txt +0 -0
index f00c435..8d8cba1 100644

Documentation/filesystems/inotify.txt A: An fd-per-watch quickly consumes more file descriptors than are allowed, · line 251

Quoted 5 lines
Documentation/filesystems/inotify.txt +1 -1
@@ -248,9 +248,9 @@ A: An fd-per-watch quickly consumes more file descriptors than are allowed,
 
    When you talk about designing a file change notification system that
    scales to 1000s of directories, juggling 1000s of fd's just does not seem
-   the right interface.  It is too heavy.
+   to be the right interface.  It is too heavy.

either way is OK.

Documentation/filesystems/inotify.txt A: An fd-per-watch quickly consumes more file descriptors than are allowed, · line 253

Quoted 3 lines
Documentation/filesystems/inotify.txt +1 -1
-   Additionally, it _is_ possible to more than one instance and
+   Additionally, it _is_ possible to have more than one instance and

OK, there is the missing word.

Documentation/filesystems/inotify.txt A: An fd-per-watch quickly consumes more file descriptors than are allowed, · line 256

Quoted 4 lines
Documentation/filesystems/inotify.txt +0 -0
    juggle more than one queue and thus more than one associated fd.  There
    need not be a one-fd-per-process mapping; it is one-fd-per-queue and a
    process can easily want more than one queue.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

#5 lore raw

PATCH 3/3 Documentation: Reword example about inotify's fd-per-instance design

In reply to Aaron Faanes

Made the final example read more clearly by splitting it into a couple more sentences.

---
 Documentation/filesystems/inotify.txt |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
Documentation/filesystems/inotify.txt +3 -3
index 8d8cba1..fbb50ad 100644
@@ -246,9 +246,9 @@ A: An fd-per-watch quickly consumes more file descriptors than are allowed,
 
    - 1024 is still too low.  ;-)
 
-   When you talk about designing a file change notification system that
-   scales to 1000s of directories, juggling 1000s of fd's just does not seem
-   to be the right interface.  It is too heavy.
+   For example, consider the design of a file change notification system that
+   scales to 1000s of directories.  Juggling 1000s of fd's in this case is just
+   not the right interface.  It is too heavy.
 
    Additionally, it _is_ possible to have more than one instance and
    juggle more than one queue and thus more than one associated fd.  There
Signature · 1 line
1.7.4.4