Skip to contentSkip to conversation

QA: Please respect commit policy!

DISCUSSION Paul Menzel 1 participant 1 message Apr 26, 2011

lore
Share & tools
lore
#0 lore raw

Dear OE developers,

looking through the commit log during the last few days I noticed that some commits are missing the Signed-off-by line. For example [1]. The line is required by our commit policy [2] though.

Additionally I kindly ask everyone to write good commit messages. (I know I am getting on your nerves already.) For example in [2]

commit e557584a06b312e19811e07fdf75d1a7f123ed91
Author: Tom Rini <[email protected]>
Date: Tue Apr 26 07:17:07 2011 -0700

bluez4: Move the update-rc.d bits to 4.42 only

Noted by Martin Jansa, taken from what he did in oe-core/meta-oe.

it would have been nice to have a link to the commit in oe-core and meta-oe, so that people do not have to search for this themselves.

The example commits are only examples and I am of course doing similar errors as can be seen by [4].

This message is just a friendly reminder.

Thanks and thank you for your work,

Paul

[1] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=ce56683db5a9efe9b44ed7d1c64a88028ea87ff7
[2] http://openembedded.org/index.php/Commit_Policy
[3] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=e557584a06b312e19811e07fdf75d1a7f123ed91
[4] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=3cb4c65dbd0fba178208bc908ce93e6b1ae9fe9b