Skip to contentSkip to conversation

Input: twl4030-pwrbutton - fix a leak of the IRQ during init failure

PATCH Applied Axel Lin 2 participants 2 messages Apr 28, 2011

Subsystems (2)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 Input: twl4030-pwrbutton - fix a leak of the IRQ during init failure

In twl4030_pwrbutton_probe error path, free_irq() was using NULL rather than the driver data as the data pointer so free_irq() wouldn't have matched.

---
 drivers/input/misc/twl4030-pwrbutton.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/input/misc/twl4030-pwrbutton.c +1 -1
index f16972b..38e4b50 100644
@@ -89,7 +89,7 @@ static int __init twl4030_pwrbutton_probe(struct platform_device *pdev)
 	return 0;
 
 free_irq:
-	free_irq(irq, NULL);
+	free_irq(irq, pwr);
 free_input_dev:
 	input_free_device(pwr);
 	return err;
Signature · 1 line
1.7.1
maintainer Applied
#1 lore raw
Quoted 2 lines · Axel Lin

In twl4030_pwrbutton_probe error path, free_irq() was using NULL rather than the driver data as the data pointer so free_irq() wouldn't have matched.

Applied, thanks Axel.

Signature · 1 line
Dmitry