Skip to contentSkip to conversation

regulator: Put mutex lock down to mc13783_powermisc_rmw function

PATCH In review Axel Lin 2 participants 4 messages May 3, 2011 – May 4, 2011 Voltage and current regulator framework

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/2 regulator: Put mutex lock down to mc13783_powermisc_rmw function

mc13783_powermisc_rmw function is doing read/modify/write bitmask operations, thus add the lock to protect it.
Then we can remove the lock/unlock from the caller.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/regulator/mc13783-regulator.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
drivers/regulator/mc13783-regulator.c +6 -6
index 3e5d0c3..13d699c 100644
@@ -235,11 +235,12 @@ static int mc13783_powermisc_rmw(struct mc13xxx_regulator_priv *priv, u32 mask,
 	int ret;
 	u32 valread;
 
+	mc13xxx_lock(mc13783);
 	BUG_ON(val & ~mask);
 
 	ret = mc13xxx_reg_read(mc13783, MC13783_REG_POWERMISC, &valread);
 	if (ret)
-		return ret;
+		goto out;
 
 	/* Update the stored state for Power Gates. */
 	priv->powermisc_pwgt_state =

@@ -252,7 +253,10 @@ static int mc13783_powermisc_rmw(struct mc13xxx_regulator_priv *priv, u32 mask,
 	valread = (valread & ~MC13783_REG_POWERMISC_PWGTSPI_M) |
 						priv->powermisc_pwgt_state;
 
-	return mc13xxx_reg_write(mc13783, MC13783_REG_POWERMISC, valread);
+	ret = mc13xxx_reg_write(mc13783, MC13783_REG_POWERMISC, valread);
+out:
+	mc13xxx_unlock(mc13783);
+	return ret;
 }
 
 static int mc13783_gpo_regulator_enable(struct regulator_dev *rdev)

@@ -270,10 +274,8 @@ static int mc13783_gpo_regulator_enable(struct regulator_dev *rdev)
 	    id == MC13783_REG_PWGT2SPI)
 		en_val = 0;
 
-	mc13xxx_lock(priv->mc13xxx);
 	ret = mc13783_powermisc_rmw(priv, mc13xxx_regulators[id].enable_bit,
 					en_val);
-	mc13xxx_unlock(priv->mc13xxx);
 
 	return ret;
 }

@@ -293,10 +295,8 @@ static int mc13783_gpo_regulator_disable(struct regulator_dev *rdev)
 	    id == MC13783_REG_PWGT2SPI)
 		dis_val = mc13xxx_regulators[id].enable_bit;
 
-	mc13xxx_lock(priv->mc13xxx);
 	ret = mc13783_powermisc_rmw(priv, mc13xxx_regulators[id].enable_bit,
 					dis_val);
-	mc13xxx_unlock(priv->mc13xxx);
 
 	return ret;
 }
Signature · 1 line
1.7.1
author
#1 lore raw

PATCH 2/2 regulator: Put mutex lock down to mc13892_powermisc_rmw function

mc13892_powermisc_rmw function is doing read/modify/write bitmask operations, thus add the lock to protect it.
Then we can remove the lock/unlock from the caller.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/regulator/mc13892-regulator.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
drivers/regulator/mc13892-regulator.c +6 -6
index 679b315..763895d 100644
@@ -302,11 +302,12 @@ static int mc13892_powermisc_rmw(struct mc13xxx_regulator_priv *priv, u32 mask,
 	int ret;
 	u32 valread;
 
+	mc13xxx_lock(mc13892);
 	BUG_ON(val & ~mask);
 
 	ret = mc13xxx_reg_read(mc13892, MC13892_POWERMISC, &valread);
 	if (ret)
-		return ret;
+		goto out;
 
 	/* Update the stored state for Power Gates. */
 	priv->powermisc_pwgt_state =

@@ -319,7 +320,10 @@ static int mc13892_powermisc_rmw(struct mc13xxx_regulator_priv *priv, u32 mask,
 	valread = (valread & ~MC13892_POWERMISC_PWGTSPI_M) |
 		priv->powermisc_pwgt_state;
 
-	return mc13xxx_reg_write(mc13892, MC13892_POWERMISC, valread);
+	ret = mc13xxx_reg_write(mc13892, MC13892_POWERMISC, valread);
+out:
+	mc13xxx_unlock(mc13892);
+	return ret;
 }
 
 static int mc13892_gpo_regulator_enable(struct regulator_dev *rdev)

@@ -339,9 +343,7 @@ static int mc13892_gpo_regulator_enable(struct regulator_dev *rdev)
 	if (id == MC13892_GPO4)
 		mask |= MC13892_POWERMISC_GPO4ADINEN;
 
-	mc13xxx_lock(priv->mc13xxx);
 	ret = mc13892_powermisc_rmw(priv, mask, en_val);
-	mc13xxx_unlock(priv->mc13xxx);
 
 	return ret;
 }

@@ -359,10 +361,8 @@ static int mc13892_gpo_regulator_disable(struct regulator_dev *rdev)
 	if (id == MC13892_PWGT1SPI || id == MC13892_PWGT2SPI)
 		dis_val = mc13892_regulators[id].enable_bit;
 
-	mc13xxx_lock(priv->mc13xxx);
 	ret = mc13892_powermisc_rmw(priv, mc13892_regulators[id].enable_bit,
 		dis_val);
-	mc13xxx_unlock(priv->mc13xxx);
 
 	return ret;
 }
Signature · 1 line
1.7.1
#2 lore raw
In reply to Axel Lin
Quoted 3 lines · Axel Lin

mc13783_powermisc_rmw function is doing read/modify/write bitmask operations, thus add the lock to protect it.
Then we can remove the lock/unlock from the caller.

This should be squashed in with the MFD patch I think otherwise we'll get bisection points with either no lock or double locking (which upsets lockdep IIRC). The change itself looks good, though, and similarly for patch 2

author
#3 lore raw

Hi Mark,
2011/5/4 Mark Brown <[email protected]>:

Quoted 10 lines · Axel Lin
Quoted 3 lines

mc13783_powermisc_rmw function is doing read/modify/write bitmask operations, thus add the lock to protect it.
Then we can remove the lock/unlock from the caller.

This should be squashed in with the MFD patch I think otherwise we'll get bisection points with either no lock or double locking (which upsets lockdep IIRC).  The change itself looks good, though, and similarly for patch 2

I think these 2 patches are independent from the MFD patch.

The MFD patch modified the mc13xxx_reg_rmw which is not called by mc13783_powermisc_rmw and mc13783_powermisc_rmw functions.
I double checked the usage of mc13783_powermisc_rmw and mc13783_powermisc_rmw, I think these 2 patches can be applied either with or without the MFD patch.

Regards,
Axel