Skip to contentSkip to conversation

KernelDoc:Add the device driver-model structures to kerneldoc

PATCH Superseded Wanlong Gao 2 participants 2 messages May 4, 2011

Subsystems (2)

v5 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

PATCH v5 1/1 KernelDoc:Add the device driver-model structures to kerneldoc

Hi Greg:

Sorry for adding your signed-off. But because that I thought I had got some thing from your articles and book in this patch.

Hi Randy:
Thanks very much for your careful checking this patch, and sorry for the errors, I'll be more carefully next time.
And don't forget the other patch which removed these structures from the Documentation/driver-model/ .

Thanks very much.
Best regards

Wanlong Gao

Add the comments to the structure bus_type, device_driver, device, class for generating the driver-model kerneldoc.

---
 Documentation/DocBook/device-drivers.tmpl |    6 +-
 include/linux/device.h                    |  154 ++++++++++++++++++++++++++++-
 2 files changed, 154 insertions(+), 6 deletions(-)
Documentation/DocBook/device-drivers.tmpl +3 -3
index 36f63d4..b638e50 100644
@@ -96,10 +96,10 @@ X!Iinclude/linux/kobject.h
 
   <chapter id="devdrivers">
      <title>Device drivers infrastructure</title>
+     <sect1><title>The Basic Device Driver-Model Structures </title>
+!Iinclude/linux/device.h
+     </sect1>
      <sect1><title>Device Drivers Base</title>
-<!--
-X!Iinclude/linux/device.h
--->
 !Edrivers/base/driver.c
 !Edrivers/base/core.c
 !Edrivers/base/class.c
include/linux/device.h +151 -3

184 lines not on this page · raw message

Signature · 1 line
1.7.4.1
#1 lore raw
Quoted 5 lines · Wanlong Gao

Hi Greg:

Sorry for adding your signed-off. But because that I thought I had got some thing from your articles and book in this patch.

That's fine, and you should say that in the patch description. Please re-read Documentation/SubmittingPatches for exactly what "Signed-off-by:" means and you will see that you can not add other names to a patch without their permission.

Quoted 6 lines

Hi Randy:
Thanks very much for your careful checking this patch, and sorry for the errors, I'll be more carefully next time.
And don't forget the other patch which removed these structures from the Documentation/driver-model/ .

Can you resend that, along with this one (with better description based on above) again so that I can apply both of them at the same time?

thanks,

greg k-h