conf/layer.conf: conf/layer.conf: Document the operation on BBPATH correctly in the comment
PATCH 1/1 conf/layer.conf: conf/layer.conf: Document the operation on BBPATH correctly in the comment
From: Khem Raj <[email protected]>
Provide additional commentary that should help a bit more
--- meta-efl/conf/layer.conf | 2 +- meta-gnome/conf/layer.conf | 2 +- meta-gpe/conf/layer.conf | 2 +- meta-oe/conf/layer.conf | 18 +++++++++++++++++- 4 files changed, 20 insertions(+), 4 deletions(-)
meta-efl/conf/layer.conf +1 -1
@@ -1,4 +1,4 @@ -# We have a conf and classes directory, prepend to BBPATH to prefer our versions +# We have a conf and classes directory, append to BBPATH BBPATH .= ":${LAYERDIR}" # We have a recipes directory, add to BBFILES
meta-gnome/conf/layer.conf +1 -1
@@ -1,4 +1,4 @@ -# We have a conf and classes directory, prepend to BBPATH to prefer our versions +# We have a conf and classes directory, append to BBPATH BBPATH .= ":${LAYERDIR}" # We have a recipes directory, add to BBFILES
meta-gpe/conf/layer.conf +1 -1
@@ -1,4 +1,4 @@ -# We have a conf and classes directory, prepend to BBPATH to prefer our versions +# We have a conf and classes directory, append to BBPATH BBPATH .= ":${LAYERDIR}" # We have a recipes directory, add to BBFILES
meta-oe/conf/layer.conf +17 -1
@@ -1,4 +1,14 @@ -# We have a conf and classes directory, prepend to BBPATH to prefer our versions +# It really depends on order of the layers appearing in BBLAYERS +# variable in toplevel bblayers.conf file, where bitbake will search +# for .inc files and others where bitbake uses BBPATH since it will +# search the directories from first to last as specfied in BBPATH +# Therefore if you want a given layer to be considered high priority +# for the .inc and .conf etc. then consider it adding at the beginning +# of BBPATH. For bblayers bitbake will use BBFILES_PRIORITY to resolve +# the recipe contention so the order of directories in BBFILES does +# not matter + +# We have a conf and classes directory, append to BBPATH BBPATH .= ":${LAYERDIR}" # We have a recipes directory, add to BBFILES
@@ -6,4 +16,10 @@ BBFILES += "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend" BBFILE_COLLECTIONS += "openembedded-layer" BBFILE_PATTERN_openembedded-layer := "^${LAYERDIR}/" + +# Define the priority for recipes (.bb files) from this layer +# this should be noted when you use this layer since it has +# to fall into the correct layer priority order that you have decided +# for you layering model + BBFILE_PRIORITY_openembedded-layer = "6"
Signature · 1 line
1.7.4.1
Am Freitag, den 06.05.2011, 15:10 -0700 schrieb [email protected]:
Quoted 47 lines
From: Khem Raj <[email protected]>
Provide additional commentary that should help a bit more
Signed-off-by Khem Raj <[email protected]>--- meta-efl/conf/layer.conf | 2 +- meta-gnome/conf/layer.conf | 2 +- meta-gpe/conf/layer.conf | 2 +- meta-oe/conf/layer.conf | 18 +++++++++++++++++- 4 files changed, 20 insertions(+), 4 deletions(-)meta-efl/conf/layer.conf +1
-1@@ -1,4 +1,4 @@ -# We have a conf and classes directory, prepend to BBPATH to prefer our versions +# We have a conf and classes directory, append to BBPATH BBPATH .= ":${LAYERDIR}" # We have a recipes directory, add to BBFILESmeta-gnome/conf/layer.conf +1
-1@@ -1,4 +1,4 @@ -# We have a conf and classes directory, prepend to BBPATH to prefer our versions +# We have a conf and classes directory, append to BBPATH BBPATH .= ":${LAYERDIR}" # We have a recipes directory, add to BBFILESmeta-gpe/conf/layer.conf +1
-1@@ -1,4 +1,4 @@ -# We have a conf and classes directory, prepend to BBPATH to prefer our versions +# We have a conf and classes directory, append to BBPATH BBPATH .= ":${LAYERDIR}" # We have a recipes directory, add to BBFILESmeta-oe/conf/layer.conf +0
-0
meta-oe/conf/layer.conf line 4
Quoted 5 lines
meta-oe/conf/layer.conf +4
-1@@ -1,4 +1,14 @@ -# We have a conf and classes directory, prepend to BBPATH to prefer our versions +# It really depends on order of the layers appearing in BBLAYERS +# variable in toplevel bblayers.conf file, where bitbake will search +# for .inc files and others where bitbake uses BBPATH since it will +# search the directories from first to last as specfied in BBPATH
spec*i*fied
meta-oe/conf/layer.conf line 6
Quoted 2 lines
meta-oe/conf/layer.conf +2
-0+# Therefore if you want a given layer to be considered high priority +# for the .inc and .conf etc. then consider it adding at the beginning
… then consider adding it to the …
meta-oe/conf/layer.conf line 9
Quoted 3 lines
meta-oe/conf/layer.conf +3
-0+# of BBPATH. For bblayers bitbake will use BBFILES_PRIORITY to resolve +# the recipe contention so the order of directories in BBFILES does +# not matter
Full stop at the end?
meta-oe/conf/layer.conf BBFILES += "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend" · line 20
Quoted 11 lines
meta-oe/conf/layer.conf +4
-0+ +# We have a conf and classes directory, append to BBPATH BBPATH .= ":${LAYERDIR}" # We have a recipes directory, add to BBFILES@@ -6,4 +16,10 @@ BBFILES += "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend" BBFILE_COLLECTIONS += "openembedded-layer" BBFILE_PATTERN_openembedded-layer := "^${LAYERDIR}/" + +# Define the priority for recipes (.bb files) from this layer
Add an extra line to make paragraph more clear or start with a capital letter below?
meta-oe/conf/layer.conf BBFILES += "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend" · line 21
Quoted 1 line
meta-oe/conf/layer.conf +1
-0+# this should be noted when you use this layer since it has
Note sounds strange. Use »defined« again?
meta-oe/conf/layer.conf BBFILES += "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend" · line 23
Quoted 2 lines
meta-oe/conf/layer.conf +2
-0+# to fall into the correct layer priority order that you have decided +# for you layering model
s/you/your/
meta-oe/conf/layer.conf BBFILES += "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend" · line 25
Quoted 2 lines
meta-oe/conf/layer.conf +1
-0+ BBFILE_PRIORITY_openembedded-layer = "6"
But please wait a bit before pushing it. Maybe a native speaker will read through the new comments.
Thanks,
Paul
Quoted 91 lines · Paul Menzel
Am Freitag, den 06.05.2011, 15:10 -0700 schrieb [email protected]:
Quoted 47 lines
From: Khem Raj<[email protected]>
Provide additional commentary that should help a bit more
Signed-off-by Khem Raj<[email protected]>--- meta-efl/conf/layer.conf | 2 +- meta-gnome/conf/layer.conf | 2 +- meta-gpe/conf/layer.conf | 2 +- meta-oe/conf/layer.conf | 18 +++++++++++++++++- 4 files changed, 20 insertions(+), 4 deletions(-)meta-efl/conf/layer.conf +1
-1@@ -1,4 +1,4 @@ -# We have a conf and classes directory, prepend to BBPATH to prefer our versions +# We have a conf and classes directory, append to BBPATH BBPATH .= ":${LAYERDIR}" # We have a recipes directory, add to BBFILESmeta-gnome/conf/layer.conf +1
-1@@ -1,4 +1,4 @@ -# We have a conf and classes directory, prepend to BBPATH to prefer our versions +# We have a conf and classes directory, append to BBPATH BBPATH .= ":${LAYERDIR}" # We have a recipes directory, add to BBFILESmeta-gpe/conf/layer.conf +1
-1@@ -1,4 +1,4 @@ -# We have a conf and classes directory, prepend to BBPATH to prefer our versions +# We have a conf and classes directory, append to BBPATH BBPATH .= ":${LAYERDIR}" # We have a recipes directory, add to BBFILESmeta-oe/conf/layer.conf +0
-0meta-oe/conf/layer.conf line 4
Quoted 5 lines
meta-oe/conf/layer.conf +4
-1@@ -1,4 +1,14 @@ -# We have a conf and classes directory, prepend to BBPATH to prefer our versions +# It really depends on order of the layers appearing in BBLAYERS +# variable in toplevel bblayers.conf file, where bitbake will search +# for .inc files and others where bitbake uses BBPATH since it will +# search the directories from first to last as specfied in BBPATHspec*i*fied
meta-oe/conf/layer.conf line 6
Quoted 2 lines
meta-oe/conf/layer.conf +2
-0+# Therefore if you want a given layer to be considered high priority +# for the .inc and .conf etc. then consider it adding at the beginning… then consider adding it to the …
meta-oe/conf/layer.conf line 9
Quoted 3 lines
meta-oe/conf/layer.conf +3
-0+# of BBPATH. For bblayers bitbake will use BBFILES_PRIORITY to resolve +# the recipe contention so the order of directories in BBFILES does +# not matterFull stop at the end?
meta-oe/conf/layer.conf BBFILES += "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend" · line 20
Quoted 11 lines
meta-oe/conf/layer.conf +4
-0+ +# We have a conf and classes directory, append to BBPATH BBPATH .= ":${LAYERDIR}" # We have a recipes directory, add to BBFILES@@ -6,4 +16,10 @@ BBFILES += "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend" BBFILE_COLLECTIONS += "openembedded-layer" BBFILE_PATTERN_openembedded-layer := "^${LAYERDIR}/" + +# Define the priority for recipes (.bb files) from this layerAdd an extra line to make paragraph more clear or start with a capital letter below?
meta-oe/conf/layer.conf BBFILES += "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend" · line 21
Quoted 1 line
meta-oe/conf/layer.conf +1
-0+# this should be noted when you use this layer since it hasNote sounds strange. Use »defined« again?
meta-oe/conf/layer.conf BBFILES += "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend" · line 23
Quoted 2 lines
meta-oe/conf/layer.conf +2
-0+# to fall into the correct layer priority order that you have decided +# for you layering models/you/your/
Quoted 7 lines
meta-oe/conf/layer.conf BBFILES += "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend" · line 25
Quoted 2 lines
meta-oe/conf/layer.conf +1
-0+ BBFILE_PRIORITY_openembedded-layer = "6"Acked-by Paul Menzel<[email protected]>But please wait a bit before pushing it. Maybe a native speaker will read through the new comments.
The corrections look fine, but I think that last bit should be worded more like this:
# Define the priority for recipes (.bb files) from this layer,
# choosing carefully how this layer interacts with all of the # other layers.
n.b. I'm not convinced of the worth of layer priorities; I don't see what they gain and to me they only cause confusion...
Signature · 4 lines
------------------------------------------------------------ Gary Thomas | Consulting for the MLB Associates | Embedded world ------------------------------------------------------------
Quoted 107 lines · Gary Thomas
Quoted 98 lines · Paul Menzel
Am Freitag, den 06.05.2011, 15:10 -0700 schrieb [email protected]:
Quoted 53 lines
From: Khem Raj<[email protected]>
Provide additional commentary that should help a bit more
Signed-off-by Khem Raj<[email protected]>---
meta-efl/conf/layer.conf | 2 +-meta-gnome/conf/layer.conf| 2 +-meta-gpe/conf/layer.conf| 2 +-meta-oe/conf/layer.conf| 18 +++++++++++++++++-4 files changed, 20 insertions(+), 4 deletions(-)meta-efl/conf/layer.conf +0
-1@@ -1,4 +1,4 @@ -# We have a conf and classes directory, prepend to BBPATH to prefer ourversions
+# We have a conf and classes directory, append to BBPATH BBPATH .= ":${LAYERDIR}"# We have a recipes directory, add to BBFILES
meta-gnome/conf/layer.conf +0
-1@@ -1,4 +1,4 @@ -# We have a conf and classes directory, prepend to BBPATH to prefer ourversions
+# We have a conf and classes directory, append to BBPATH BBPATH .= ":${LAYERDIR}"# We have a recipes directory, add to BBFILES
meta-gpe/conf/layer.conf +0
-1@@ -1,4 +1,4 @@ -# We have a conf and classes directory, prepend to BBPATH to prefer ourversions
+# We have a conf and classes directory, append to BBPATH BBPATH .= ":${LAYERDIR}"# We have a recipes directory, add to BBFILES
meta-oe/conf/layer.conf +0
-1@@ -1,4 +1,14 @@ -# We have a conf and classes directory, prepend to BBPATH to prefer ourversions
meta-oe/conf/layer.conf line 4
Quoted 4 lines
meta-oe/conf/layer.conf +4
-0+# It really depends on order of the layers appearing in BBLAYERS +# variable in toplevel bblayers.conf file, where bitbake will search +# for .inc files and others where bitbake uses BBPATH since it will +# search the directories from first to last as specfied in BBPATHspec*i*fied
meta-oe/conf/layer.conf line 6
Quoted 2 lines
meta-oe/conf/layer.conf +2
-0+# Therefore if you want a given layer to be considered high priority +# for the .inc and .conf etc. then consider it adding at the beginning… then consider adding it to the …
meta-oe/conf/layer.conf line 9
Quoted 3 lines
meta-oe/conf/layer.conf +3
-0+# of BBPATH. For bblayers bitbake will use BBFILES_PRIORITY to resolve +# the recipe contention so the order of directories in BBFILES does +# not matterFull stop at the end?
meta-oe/conf/layer.conf BBFILES += "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend" · line 20
Quoted 12 lines
meta-oe/conf/layer.conf +2
-0+ +# We have a conf and classes directory, append to BBPATHBBPATH .= ":${LAYERDIR}"
# We have a recipes directory, add to BBFILES
meta-oe/conf/layer.conf +0
-0@@ -6,4 +16,10 @@ BBFILES += "${LAYERDIR}/recipes-*/*/*.bb${LAYERDIR}/recipes-*/*/*.bbappend"
BBFILE_COLLECTIONS += "openembedded-layer" BBFILE_PATTERN_openembedded-layer := "^${LAYERDIR}/"
meta-oe/conf/layer.conf +2
-0+ +# Define the priority for recipes (.bb files) from this layerAdd an extra line to make paragraph more clear or start with a capital letter below?
Quoted 1 line
+# this should be noted when you use this layer since it has
Note sounds strange. Use »defined« again?
meta-oe/conf/layer.conf BBFILES += "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend" · line 23
Quoted 2 lines
meta-oe/conf/layer.conf +2
-0+# to fall into the correct layer priority order that you have decided +# for you layering models/you/your/
Quoted 7 lines
Quoted 2 lines
+
BBFILE_PRIORITY_openembedded-layer = "6"Acked-by Paul Menzel<[email protected]>But please wait a bit before pushing it. Maybe a native speaker will read through the new comments.
Quoted 7 lines
The corrections look fine, but I think that last bit should be worded more like this:
# Define the priority for recipes (.bb files) from this layer,
# choosing carefully how this layer interacts with all of the # other layers.
thank you. Will redo it and incorporate feedback.
Quoted 3 lines
n.b. I'm not convinced of the worth of layer priorities; I don't see what they gain and to me they only cause confusion...
Thats a different story :)
We are documenting what we have.
Quoted 11 lines
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel