Skip to contentSkip to conversation

ASoC: Don't squash 16x8 registers down to 8 bits

PATCH In review Mark Brown 2 participants 2 messages May 11, 2011

Subsystems (2)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 ASoC: Don't squash 16x8 registers down to 8 bits

Currently we'll force all registers to fit in 8 bits before passing down to the I/O function. Looks like a cut'n'paste bug.

---
 sound/soc/soc-cache.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
sound/soc/soc-cache.c +0 -1
index bb8e446..40548ce 100644
@@ -232,7 +232,6 @@ static int snd_soc_16_8_write(struct snd_soc_codec *codec, unsigned int reg,
 	data[0] = (reg >> 8) & 0xff;
 	data[1] = reg & 0xff;
 	data[2] = value;
-	reg &= 0xff;
 
 	return do_hw_write(codec, reg, value, data, 3);
 }
Signature · 1 line
1.7.5.1
Acked-by on v1 1/1
#1 lore raw
Quoted 13 lines · Mark Brown

Currently we'll force all registers to fit in 8 bits before passing down to the I/O function. Looks like a cut'n'paste bug.

---
 sound/soc/soc-cache.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
sound/soc/soc-cache.c +0 -0
index bb8e446..40548ce 100644

sound/soc/soc-cache.c static int snd_soc_16_8_write(struct snd_soc_codec *codec, unsigned int reg, · line 237

Quoted 7 lines
sound/soc/soc-cache.c +0 -1
@@ -232,7 +232,6 @@ static int snd_soc_16_8_write(struct snd_soc_codec *codec, unsigned int reg,
 	data[0] = (reg >> 8) & 0xff;
 	data[1] = reg & 0xff;
 	data[2] = value;
-	reg &= 0xff;
 
 	return do_hw_write(codec, reg, value, data, 3);
 }