Skip to contentSkip to conversation

spi: spi_nuc900: Use spi_bitbang_stop instead of spi_unregister_master in nuc900_spi_remove

PATCH Applied Axel Lin 2 participants 4 messages May 14, 2011 – May 19, 2011

Subsystems (2)
SPI Arm Samsung Exynos
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/2 spi: spi_nuc900: Use spi_bitbang_stop instead of spi_unregister_master in nuc900_spi_remove

Calling spi_bitbang_stop() will also destroy bitbang->workqueue, which is created by calling spi_bitbang_start() in nuc900_spi_probe().

Signed-off-by Axel Lin <[email protected]>
---
 drivers/spi/spi_nuc900.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/spi/spi_nuc900.c +1 -1
index d5be18b..3cd15f6 100644
@@ -463,7 +463,7 @@ static int __devexit nuc900_spi_remove(struct platform_device *dev)
 
 	platform_set_drvdata(dev, NULL);
 
-	spi_unregister_master(hw->master);
+	spi_bitbang_stop(&hw->bitbang);
 
 	clk_disable(hw->clk);
 	clk_put(hw->clk);
Signature · 1 line
1.7.1
author
#1 lore raw

PATCH 2/2 spi: spi_s3c24xx: Use spi_bitbang_stop instead of spi_unregister_master in s3c24xx_spi_remove

Calling spi_bitbang_stop() will also destroy bitbang->workqueue, which is created by calling spi_bitbang_start() in s3c24xx_spi_probe().

Signed-off-by Axel Lin <[email protected]>
---
 drivers/spi/spi_s3c24xx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/spi/spi_s3c24xx.c +1 -1
index 151a95e..1a5fcab 100644
@@ -668,7 +668,7 @@ static int __exit s3c24xx_spi_remove(struct platform_device *dev)
 
 	platform_set_drvdata(dev, NULL);
 
-	spi_unregister_master(hw->master);
+	spi_bitbang_stop(&hw->bitbang);
 
 	clk_disable(hw->clk);
 	clk_put(hw->clk);
Signature · 1 line
1.7.1
Applied
#2 lore raw

Re: [PATCH 2/2] spi: spi_s3c24xx: Use spi_bitbang_stop instead of spi_unregister_master in s3c24xx_spi_remove

Quoted 4 lines · Axel Lin

Calling spi_bitbang_stop() will also destroy bitbang->workqueue, which is created by calling spi_bitbang_start() in s3c24xx_spi_probe().

Signed-off-by Axel Lin <[email protected]>

Applied, thanks.
g.

Quoted 22 lines
---
 drivers/spi/spi_s3c24xx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/spi/spi_s3c24xx.c +1 -1
index 151a95e..1a5fcab 100644
@@ -668,7 +668,7 @@ static int __exit s3c24xx_spi_remove(struct platform_device *dev)
 
 	platform_set_drvdata(dev, NULL);
 
-	spi_unregister_master(hw->master);
+	spi_bitbang_stop(&hw->bitbang);
 
 	clk_disable(hw->clk);
 	clk_put(hw->clk);
Signature · 1 line
1.7.1
Applied
#3 lore raw
In reply to Axel Lin
Quoted 4 lines · Axel Lin

Calling spi_bitbang_stop() will also destroy bitbang->workqueue, which is created by calling spi_bitbang_start() in nuc900_spi_probe().

Signed-off-by Axel Lin <[email protected]>

Applied, thanks.

g.

Quoted 22 lines
---
 drivers/spi/spi_nuc900.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/spi/spi_nuc900.c +1 -1
index d5be18b..3cd15f6 100644
@@ -463,7 +463,7 @@ static int __devexit nuc900_spi_remove(struct platform_device *dev)
 
 	platform_set_drvdata(dev, NULL);
 
-	spi_unregister_master(hw->master);
+	spi_bitbang_stop(&hw->bitbang);
 
 	clk_disable(hw->clk);
 	clk_put(hw->clk);
Signature · 1 line
1.7.1