Skip to contentSkip to conversation

Incorrect alignment assumptions in x86_64 stacktrace

DISCUSSION Keith Owens 2 participants 3 messages Aug 25, 2006

lore
Share & tools
lore
#0 lore raw

2.6.18-rc4 arch/x86_64/kernel/stacktrace.c::get_stack_end() incorrectly assumes that the irqstackptr is IRQSTACKSIZE aligned.

	stack_end = (unsigned long)cpu_pda(cpu)->irqstackptr;
	if (stack_end) {
		stack_start = stack_end & ~(IRQSTACKSIZE-1);

irqstackptr is only guaranteed to be page aligned, not IRQSTACKSIZE (4*PAGE_SIZE) aligned.

#1 lore raw
Quoted 9 lines · Keith Owens

2.6.18-rc4 arch/x86_64/kernel/stacktrace.c::get_stack_end() incorrectly assumes that the irqstackptr is IRQSTACKSIZE aligned.

	stack_end = (unsigned long)cpu_pda(cpu)->irqstackptr;
	if (stack_end) {
		stack_start = stack_end & ~(IRQSTACKSIZE-1);

irqstackptr is only guaranteed to be page aligned, not IRQSTACKSIZE (4*PAGE_SIZE) aligned.

Thanks. I have already removed that code post 2.6.18 (the standard backtracer now does both stacktrace and show_trace)

You think it is important enough for 2.6.18?

-Andi

#2 lore raw
Quoted 8 lines · Andi Kleen (on Fri, 25 Aug 2006 09:33:53 +0200) wrote:
Quoted 7 lines · Keith Owens

2.6.18-rc4 arch/x86_64/kernel/stacktrace.c::get_stack_end() incorrectly assumes that the irqstackptr is IRQSTACKSIZE aligned.

	stack_end = (unsigned long)cpu_pda(cpu)->irqstackptr;
	if (stack_end) {
		stack_start = stack_end & ~(IRQSTACKSIZE-1);
Quoted 7 lines
Quoted 2 lines

irqstackptr is only guaranteed to be page aligned, not IRQSTACKSIZE (4*PAGE_SIZE) aligned.

Thanks. I have already removed that code post 2.6.18 (the standard backtracer now does both stacktrace and show_trace)

You think it is important enough for 2.6.18?

Depends if any x86_64 distributions are going to be based on 2.6.18. I hear rumours, but no facts.