staging: bcm: Style cleanup of 1st 500 lines.
A message that is not in the archive (sent off-list or not yet received): [email protected]
Review
Quoted 13 lines · Ken O'Brien
Applied coding convention rules to 1st 500 lines. These lines no longer throw errors or warnings. Subsequent patches will fix the remaining lines.
(quoted diff) +6
-4- else if (_IOC_DIR(cmd) & _IOC_WRITE) - Status = !access_ok(VERIFY_READ, argp, _IOC_SIZE(cmd)); - else if (_IOC_NONE == (_IOC_DIR(cmd) & _IOC_NONE)) - Status = STATUS_SUCCESS; + else + if (_IOC_DIR(cmd) & _IOC_WRITE) + Status = !access_ok(VERIFY_READ, argp, _IOC_SIZE(cmd)); + else + if (_IOC_NONE == (_IOC_DIR(cmd) & _IOC_NONE)) + Status = STATUS_SUCCESS;
The original code was correct, "else if" goes on one line.
Review
Quoted 4 lines
(quoted diff) +4
-0+ if (IsReqGpioIsLedInNVM(Adapter, value) == FALSE) { + BCM_DEBUG_PRINT(Adapter, DBG_TYPE_OTHERS, OSAL_DBG, + DBG_LVL_ALL, + "Sorry, Requested GPIO<0x%X> is not correspond to LED !!!",
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This should be indented to there. I know it makes the line too long but it's better to ignore checkpatch on this. Even computer programs like checkpatch can ignored from time to time. There were several other debug messages like this so it's probably worth redoing the patch once any other review comments are in.
Review
Quoted 2 lines
(quoted diff) +2
-0+ value); + Status = -EINVAL;
regards,
dan carpenter