enjoy: add alsa and autodetect gst modules.
PATCH v2 1/1 enjoy: add alsa and autodetect gst modules.
Without autodetect, enjoy segfaults. Without alsa, no sound is played.
That happens because emotion needs them to play as shown in its source code:emotion_gstreamer_pipeline.c: sink = gst_element_factory_make("autoaudiosink", "audiosink");
Signed-off-by Pau Espin Pedrol <[email protected]>
--- recipes/e17/enjoy_svn.bb | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
recipes/e17/enjoy_svn.bb +2 -2
@@ -3,7 +3,7 @@ LICENSE = "LGPLv3" DEPENDS = "evas ecore edje elementary emotion lightmediascanner" SRCREV = "${EFL_SRCREV}" PV = "0.0+svnr${SRCPV}" -PR = "r4" +PR = "r5" DEPENDS += "gst-plugins-good ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugins-ugly', d)}"
@@ -13,7 +13,7 @@ DEPENDS += "gst-plugins-good ${@base_conditional('ENTERPRISE_DISTRO', '1', '', ' #4th needed for flac playback #5th needed binary to create db RDEPENDS += "\ - gst-plugin-typefindfunctions gst-plugin-playbin gst-plugin-volume gst-plugin-decodebin2 \ + gst-plugin-typefindfunctions gst-plugin-playbin gst-plugin-volume gst-plugin-decodebin2 gst-plugin-alsa gst-plugin-autodetect \ ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugin-mad gst-plugin-id3demux', d)} \ gst-plugin-ogg gst-plugin-ivorbisdec \ gst-plugin-flac \
Signature · 1 line
1.7.5.rc3
Am Montag, den 13.06.2011, 20:59 +0200 schrieb Pau Espin Pedrol:
Quoted 4 lines
Without autodetect, enjoy segfaults. Without alsa, no sound is played.
That happens because emotion needs them to play as shown in its source code:
emotion_gstreamer_pipeline.c: sink =gst_element_factory_make("autoaudiosink", "audiosink");
Thank you for resending the patch!
Quoted 5 lines
Signed-off-by Pau Espin Pedrol <[email protected]>--- recipes/e17/enjoy_svn.bb | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
[…]
Acked-by Paul Menzel <[email protected]>
I will give the others folks a day or two for reviewing and commit your patch afterward.
Thanks,
Paul