Skip to contentSkip to conversation

conntrack: add missing break when parsing --id/--secmark options

PATCH Applied Florian Westphal 2 participants 2 messages Jun 15, 2011 – Jul 8, 2011 netfilter

lore
Share & tools
lore

Florian Westphal

author maintainer
#0 lore raw

PATCH 1/1 conntrack: add missing break when parsing --id/--secmark options

commit 147ed522f52a62ab0d854ddc443d27d97dbf6cdf (conntrack: add support for mark mask) failed to add a break after secmark/id option parsing.

Results in '-m 42 -c 1' to search for mark 1 instead of 42.

---
Sorry about this; i did not see it until now...

src/conntrack.c +1 -0
index 3e1cb11..8eae554 100644
@@ -1566,6 +1566,7 @@ int main(int argc, char *argv[])
 			nfct_set_attr_u32(tmpl.ct,
 					  opt2attr[c],
 					  strtoul(optarg, NULL, 0));
+			break;
 		case 'm':
 			options |= opt2type[c];
 			parse_u32_mask(optarg, &tmpl.mark);
Signature · 1 line
1.7.3.4
maintainer Applied
#1 lore raw
Quoted 5 lines · Florian Westphal

commit 147ed522f52a62ab0d854ddc443d27d97dbf6cdf (conntrack: add support for mark mask) failed to add a break after secmark/id option parsing.

Results in '-m 42 -c 1' to search for mark 1 instead of 42.

Applied, thanks.