Skip to contentSkip to conversation

input: wacom - Wacom Bamboo Pen D4 has 1024 pressure level

PATCH In review Ping Cheng 2 participants 2 messages Jul 1, 2011 – Jul 4, 2011 HID

lore
Share & tools
lore

Ping Cheng

author
#0 lore raw

PATCH 1/4 input: wacom - Wacom Bamboo Pen D4 has 1024 pressure level

Quoted 5 lines · Henrik Rydberg

Hi Ping,

Quoted 2 lines · Ping Cheng

Instead of 512.

Quoted 7 lines
Quoted 3 lines

---

Perhaps one could elaborate the commit message a bit - in particular since the text mentions 512, whereas the patch seems to change from 256?

Nice catch, Henrik. 512 was a typo. Does this commit message work:

It is reported by Ubuntu users that Wacom Bamboo Pen D4 has 1024 pressure level instead of 256.

Ping

Quoted 20 lines
Quoted 8 lines
 drivers/input/tablet/wacom_wac.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/input/tablet/wacom_wac.c +0 -0
index 2ea0d2e..1cbb9a8 100644

drivers/input/tablet/wacom_wac.c static const struct wacom_features wacom_features_0xD3 =

Quoted 9 lines
drivers/input/tablet/wacom_wac.c +1 -2
@@ -1462,7 +1462,7 @@ static const struct wacom_features wacom_features_0xD3 =
      { "Wacom Bamboo 2FG 6x8", WACOM_PKGLEN_BBFUN,     21648, 13530, 1023,
        63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
 static const struct wacom_features wacom_features_0xD4 =
-     { "Wacom Bamboo Pen",     WACOM_PKGLEN_BBFUN,     14720,  9200,  255,
+     { "Wacom Bamboo Pen",     WACOM_PKGLEN_BBFUN,     14720,  9200, 1023,
        63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
 static const struct wacom_features wacom_features_0xD6 =
      { "Wacom BambooPT 2FG 4x5", WACOM_PKGLEN_BBFUN,   14720,  9200, 1023,
--

Thanks,
Henrik

#1 lore raw
Quoted 11 lines · Ping Cheng
Quoted 8 lines · Henrik Rydberg

Hi Ping,

Quoted 5 lines · Ping Cheng

Instead of 512.

---

Quoted 8 lines
Quoted 3 lines

Perhaps one could elaborate the commit message a bit - in particular since the text mentions 512, whereas the patch seems to change from 256?

Nice catch, Henrik. 512 was a typo. Does this commit message work:

It is reported by Ubuntu users that Wacom Bamboo Pen D4 has 1024 pressure level instead of 256.

Unfortunately I already pushed out the patch to we'll have to live with bad log message. Oh well...

Thanks.

Signature · 1 line
Dmitry