openssh/dropbear: No need for each to PROVIDE ssh/sshd

RFC PATCH In review Richard Purdie 3 participants 3 messages Jul 5, 2011

Share & tools

Richard Purdie

author

2011-07-05 13:37 UTC #0 lore raw

RFC PATCH 1/1 openssh/dropbear: No need for each to PROVIDE ssh/sshd

Nothing in the system actually uses the PROVIDES field for these recipes, its usually the runtime packages that are used. We can therefore remove the PROVIDES and hence quieten the associated warnings from bitbake.

If these recipes do really need the PROVIDES, they would be better as virtuals and adding that to MULTI_PROVIDER_WHITELIST.

Signed-off-by Richard Purdie <[email protected]>

---

meta/recipes-connectivity/openssh/openssh_5.8p2.bb +0 -1

index ec33b29..e23069c 100644
@@ -12,7 +12,6 @@ PR = "r0"
 DEPENDS = "zlib openssl"
 DEPENDS += "${@base_contains('DISTRO_FEATURES', 'pam', 'libpam', '', d)}"
 
-PROVIDES = "ssh sshd"
 RPROVIDES = "ssh sshd"
 
 CONFLICTS_${PN} = "dropbear"

meta/recipes-core/dropbear/dropbear.inc +0 -1

index c9c41d2..1b51e1a 100644
@@ -8,7 +8,6 @@ LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=3a5b0c2f0d0c49dfde9558ae2036683c"
 
 DEPENDS = "zlib"
-PROVIDES = "ssh sshd"
 RPROVIDES = "ssh sshd"
 
 SRC_URI = "http://matt.ucc.asn.au/dropbear/releases/dropbear-${PV}.tar.gz \

Koen Kooi

2011-07-05 13:40 UTC #1 lore raw

looks good to me

Op 5 jul. 2011 om 14:33 heeft Richard Purdie <[email protected]> het volgende geschreven:

Quoted 41 lines

Nothing in the system actually uses the PROVIDES field for these recipes, its usually the runtime packages that are used. We can therefore remove the PROVIDES and hence quieten the associated warnings from bitbake.
If these recipes do really need the PROVIDES, they would be better as virtuals and adding that to MULTI_PROVIDER_WHITELIST.
Signed-off-by Richard Purdie <[email protected]>
---
meta/recipes-connectivity/openssh/openssh_5.8p2.bb +0 -0
index ec33b29..e23069c 100644
@@ -12,7 +12,6 @@ PR = "r0"
DEPENDS = "zlib openssl"
DEPENDS += "${@base_contains('DISTRO_FEATURES', 'pam', 'libpam', '', d)}"
-PROVIDES = "ssh sshd"
RPROVIDES = "ssh sshd"
CONFLICTS_${PN} = "dropbear"
meta/recipes-core/dropbear/dropbear.inc +0 -0
index c9c41d2..1b51e1a 100644
@@ -8,7 +8,6 @@ LICENSE = "MIT"
LIC_FILES_CHKSUM = "file://LICENSE;md5=3a5b0c2f0d0c49dfde9558ae2036683c"
DEPENDS = "zlib"
-PROVIDES = "ssh sshd"
RPROVIDES = "ssh sshd"
SRC_URI = "http://matt.ucc.asn.au/dropbear/releases/dropbear-${PV}.tar.gz \
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Khem Raj

Acked-by on v1 1/1

2011-07-05 20:51 UTC #2 lore raw

In reply to Richard Purdie

Quoted 30 lines · Richard Purdie

Nothing in the system actually uses the PROVIDES field for these recipes, its usually the runtime packages that are used. We can therefore remove the PROVIDES and hence quieten the associated warnings from bitbake.
If these recipes do really need the PROVIDES, they would be better as virtuals and adding that to MULTI_PROVIDER_WHITELIST.
Signed-off-by Richard Purdie <[email protected]>
---
meta/recipes-connectivity/openssh/openssh_5.8p2.bb +0 -0
index ec33b29..e23069c 100644
@@ -12,7 +12,6 @@ PR = "r0"
DEPENDS = "zlib openssl"
DEPENDS += "${@base_contains('DISTRO_FEATURES', 'pam', 'libpam', '', d)}"
-PROVIDES = "ssh sshd"
RPROVIDES = "ssh sshd"
CONFLICTS_${PN} = "dropbear"
meta/recipes-core/dropbear/dropbear.inc +0 -0
index c9c41d2..1b51e1a 100644
@@ -8,7 +8,6 @@ LICENSE = "MIT"
LIC_FILES_CHKSUM = "file://LICENSE;md5=3a5b0c2f0d0c49dfde9558ae2036683c"

Quoted 6 lines

DEPENDS = "zlib"
-PROVIDES = "ssh sshd"
RPROVIDES = "ssh sshd"
SRC_URI = "http://matt.ucc.asn.au/dropbear/releases/dropbear-${PV}.tar.gz \

Infact I have tested same patch last week so

Acked-by Khem Raj <[email protected]>

Quoted 6 lines

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core