Skip to contentSkip to conversation

GPIO: DA9052 GPIO module v2

PATCH In review ashishj3 2 participants 2 messages Jul 5, 2011

Subsystems (3)
lore
Share & tools
lore

ashishj3

author
#0 lore raw

PATCH 2/11 GPIO: DA9052 GPIO module v2

DA9052 PMIC has 16 bit GPIO bus for peripheral control.

This patch add support for the GPIO pins on the DA9052.

---
Changes since v2
- change of file name
- correct reference to irq_base in function to_irq()
- remove pdata dependency

---
 drivers/gpio/Kconfig            |    6 +
 drivers/gpio/Makefile           |    1 +
 drivers/gpio/gpio-da9052.c      |  259 +++++++++++++++++++++++++++++++++++++++
 include/linux/mfd/da9052/gpio.h |   47 +++++++
 4 files changed, 313 insertions(+), 0 deletions(-)
 create mode 100755 drivers/gpio/gpio-da9052.c
 create mode 100755 include/linux/mfd/da9052/gpio.h
drivers/gpio/Kconfig +6 -0
index d3b2953..df510d4 100644
@@ -65,6 +65,12 @@ config GPIO_SYSFS
 
 # put expanders in the right section, in alphabetical order
 
+config GPIO_DA9052
+	tristate "Dialog DA9052 GPIO"
+	depends on PMIC_DA9052
+	help
+	  Say yes here to enable the GPIO driver for the DA9052 chip.
+
 config GPIO_MAX730X
 	tristate
 
drivers/gpio/Makefile +1 -0
index becef59..cbee503 100644
@@ -11,6 +11,7 @@ obj-$(CONFIG_GPIOLIB)		+= gpiolib.o
 obj-$(CONFIG_GPIO_ADP5520)	+= adp5520-gpio.o
 obj-$(CONFIG_GPIO_ADP5588)	+= adp5588-gpio.o
 obj-$(CONFIG_GPIO_BASIC_MMIO)	+= basic_mmio_gpio.o
+obj-$(CONFIG_GPIO_DA9052)	+= gpio-da9052.o
 obj-$(CONFIG_GPIO_LANGWELL)	+= langwell_gpio.o
 obj-$(CONFIG_GPIO_MAX730X)	+= max730x.o
 obj-$(CONFIG_GPIO_MAX7300)	+= max7300.o
drivers/gpio/gpio-da9052.c new file +259 -0

259 lines not on this page · raw message

include/linux/mfd/da9052/gpio.h new file +47 -0

47 lines not on this page · raw message

#1 lore raw
Quoted 12 lines · On Tuesday 05 July 2011, ashishj3 wrote:

DA9052 PMIC has 16 bit GPIO bus for peripheral control.

This patch add support for the GPIO pins on the DA9052.

---
Changes since v2
- change of file name
- correct reference to irq_base in function to_irq()
- remove pdata dependency

Quoted 6 lines
---
 drivers/gpio/Kconfig            |    6 +
 drivers/gpio/Makefile           |    1 +
 drivers/gpio/gpio-da9052.c      |  259 +++++++++++++++++++++++++++++++++++++++
 include/linux/mfd/da9052/gpio.h |   47 +++++++
 4 files changed, 313 insertions(+), 0 deletions(-)

I think I commented on this before, but please remove any header files in include/linux that are not used as an interface between different modules. If a header just describes properties of the hardware and is used by a single source file, move the contents into that source file.

If a header is used by multiple files in one directory, make it a local header in that directory.

Arnd