Skip to contentSkip to conversation

cpufreq: exynos4210: make needlessly global symbols static

PATCH In review Axel Lin 2 participants 4 messages Jul 8, 2011

Subsystems (2)
Arm Samsung Exynos CPU frequency scaling framework
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/2 cpufreq: exynos4210: make needlessly global symbols static

The following symbols are needlessly defined global:
exynos4_verify_speed
exynos4_getspeed
exynos4_set_clkdiv

Make them static.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/cpufreq/exynos4210-cpufreq.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/cpufreq/exynos4210-cpufreq.c +3 -3
index 54025fc..b7c3a84 100644
@@ -191,17 +191,17 @@ static unsigned int exynos4_apll_pms_table[CPUFREQ_LEVEL_END] = {
 	((200 << 16) | (6 << 8) | 4),
 };
 
-int exynos4_verify_speed(struct cpufreq_policy *policy)
+static int exynos4_verify_speed(struct cpufreq_policy *policy)
 {
 	return cpufreq_frequency_table_verify(policy, exynos4_freq_table);
 }
 
-unsigned int exynos4_getspeed(unsigned int cpu)
+static unsigned int exynos4_getspeed(unsigned int cpu)
 {
 	return clk_get_rate(cpu_clk) / 1000;
 }
 
-void exynos4_set_clkdiv(unsigned int div_index)
+static void exynos4_set_clkdiv(unsigned int div_index)
 {
 	unsigned int tmp;
Signature · 1 line
1.7.4.1
author
#1 lore raw

PATCH 2/2 cpufreq: s5pv210: make needlessly global symbols static

The following symbols are needlessly defined global:
s5pv210_verify_speed
s5pv210_getspeed

Make them static.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/cpufreq/s5pv210-cpufreq.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/cpufreq/s5pv210-cpufreq.c +2 -2
index a7cb338..806408e 100644
@@ -121,7 +121,7 @@ static void s5pv210_set_refresh(enum s5pv210_dmc_port ch, unsigned long freq)
 	__raw_writel(tmp1, reg);
 }
 
-int s5pv210_verify_speed(struct cpufreq_policy *policy)
+static int s5pv210_verify_speed(struct cpufreq_policy *policy)
 {
 	if (policy->cpu)
 		return -EINVAL;

@@ -129,7 +129,7 @@ int s5pv210_verify_speed(struct cpufreq_policy *policy)
 	return cpufreq_frequency_table_verify(policy, s5pv210_freq_table);
 }
 
-unsigned int s5pv210_getspeed(unsigned int cpu)
+static unsigned int s5pv210_getspeed(unsigned int cpu)
 {
 	if (cpu)
 		return 0;
Signature · 1 line
1.7.4.1
Acked-by on v1 2/2
#2 lore raw

RE: [PATCH 2/2] cpufreq: s5pv210: make needlessly global symbols static

Quoted 8 lines · Axel Lin

The following symbols are needlessly defined global:
s5pv210_verify_speed
s5pv210_getspeed

Make them static.

Signed-off-by Axel Lin <[email protected]>
Acked-by Kukjin Kim <[email protected]>

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

Quoted 29 lines
---
 drivers/cpufreq/s5pv210-cpufreq.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/cpufreq/s5pv210-cpufreq.c +1 -1
index a7cb338..806408e 100644
@@ -121,7 +121,7 @@ static void s5pv210_set_refresh(enum s5pv210_dmc_port
 ch, unsigned long freq)
 	__raw_writel(tmp1, reg);
 }
 
-int s5pv210_verify_speed(struct cpufreq_policy *policy)
+static int s5pv210_verify_speed(struct cpufreq_policy *policy)
 {
 	if (policy->cpu)
drivers/cpufreq/s5pv210-cpufreq.c +1 -2
 		return -EINVAL;

@@ -129,7 +129,7 @@ int s5pv210_verify_speed(struct cpufreq_policy *policy)
 	return cpufreq_frequency_table_verify(policy, s5pv210_freq_table);
 }
 
-unsigned int s5pv210_getspeed(unsigned int cpu)
+static unsigned int s5pv210_getspeed(unsigned int cpu)
 {
 	if (cpu)
 		return 0;
--

1.7.4.1

Acked-by on v1 1/2
#3 lore raw
In reply to Axel Lin
Quoted 9 lines · Axel Lin

The following symbols are needlessly defined global:
exynos4_verify_speed
exynos4_getspeed
exynos4_set_clkdiv

Make them static.

Signed-off-by Axel Lin <[email protected]>

Yes :)

Acked-by Kukjin Kim <[email protected]>

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

Quoted 33 lines
---
 drivers/cpufreq/exynos4210-cpufreq.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/cpufreq/exynos4210- renamed from drivers/cpufreq/exynos4210-cpufreq.c +0 -0

cpufreq.c
index 54025fc..b7c3a84 100644

drivers/cpufreq/exynos4210-cpufreq.c +3 -4
@@ -191,17 +191,17 @@ static unsigned int
 exynos4_apll_pms_table[CPUFREQ_LEVEL_END] = {
 	((200 << 16) | (6 << 8) | 4),
 };
 
-int exynos4_verify_speed(struct cpufreq_policy *policy)
+static int exynos4_verify_speed(struct cpufreq_policy *policy)
 {
 	return cpufreq_frequency_table_verify(policy, exynos4_freq_table);
 }
 
-unsigned int exynos4_getspeed(unsigned int cpu)
+static unsigned int exynos4_getspeed(unsigned int cpu)
 {
 	return clk_get_rate(cpu_clk) / 1000;
 }
 
-void exynos4_set_clkdiv(unsigned int div_index)
+static void exynos4_set_clkdiv(unsigned int div_index)
 {
 	unsigned int tmp;
 
--

1.7.4.1