Skip to contentSkip to conversation

pulseaudio: Switch to version version 0.9.22 for Angstrom 2011.03

PATCH In review Joel A Fernandes 4 participants 6 messages Jul 9, 2011 – Jul 11, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pulseaudio: Switch to version version 0.9.22 for Angstrom 2011.03

This fixes all the issues noticed earlier with pulseaudio 0.9.15:
* Pulseaudio keeping audio devices busy when run as per-user instance
* Failure of pactl, pacmd etc to connect to the pulseaudio server

---
Notes:
* This has to go into the OpenEmbedded 2011.03-maintenance branch as there is no such configration file in the master branch
* Please ignore the earlier patch "pulseaudio: Run as system-wide instance instead of per-user"

Applying this and the patch titled "beagleboard-test-scripts: Add a script flash-fs.sh for flashing NAND" will mark the "Alpha" build of the C5 image. Can this be tagged?

Things to go into "Beta":
* User button fixes (kernel and flashing scripts)
* U-boot fixes for EHCI timeouts when doing a tftpboot

 conf/distro/angstrom-2008.1.conf                   |    3 +++
 .../include/angstrom-2008-preferred-versions.inc   |    2 +-
 2 files changed, 4 insertions(+), 1 deletions(-)
conf/distro/angstrom-2008.1.conf +3 -0
index ae1ed4c..7b4f25a 100644
@@ -121,6 +121,9 @@ PREFERRED_VERSION_binutils_avr32 = "2.17"
 PREFERRED_VERSION_binutils-cross_avr32 = "2.17"
 PREFERRED_VERSION_binutils-cross-sdk_avr32 = "2.17"
 
+ANGSTROM_PULSEAUDIO_VERSION		= "0.9.15"
+ANGSTROM_PULSEAUDIO_VERSION_armv7a	= "0.9.22"
+
 PREFERRED_PROVIDER_dbus-glib             = "dbus-glib"
 PREFERRED_PROVIDER_hotplug               = "udev"
 PREFERRED_PROVIDER_opkg                 ?= "opkg"
conf/distro/include/angstrom-2008-preferred-versions.inc +1 -1
index b5b524a..e4b8bf1 100644
@@ -44,7 +44,7 @@ PREFERRED_VERSION_pango-native     = "1.24.4"
 #PREFERRED_VERSION_pixman	= "0.13.2"
 PREFERRED_VERSION_pkgconfig	= "0.23"
 PREFERRED_VERSION_pkgconfig-native = "0.23"
-PREFERRED_VERSION_pulseaudio 	= "0.9.15"
+PREFERRED_VERSION_pulseaudio 	= "${ANGSTROM_PULSEAUDIO_VERSION}"
 PREFERRED_VERSION_python-pycairo = "1.8.0"
 PREFERRED_VERSION_qt4-tools-native = "${ANGSTROM_QT_VERSION}"
 PREFERRED_VERSION_qt4-tools-sdk = "${ANGSTROM_QT_VERSION}"
Signature · 1 line
1.7.0.4
#1 lore raw
Quoted 13 lines · Joel A Fernandes

This fixes all the issues noticed earlier with pulseaudio 0.9.15:
 * Pulseaudio keeping audio devices busy when run as per-user instance
 * Failure of pactl, pacmd etc to connect to the pulseaudio server

---
Notes:
* This has to go into the OpenEmbedded 2011.03-maintenance branch as there is no such configration file in the master branch
* Please ignore the earlier patch "pulseaudio: Run as system-wide instance instead of per-user"

Applying this and the patch titled "beagleboard-test-scripts: Add a script flash-fs.sh for flashing NAND" will mark the "Alpha" build of the C5 image. Can this be tagged?

Quoted 8 lines

Things to go into "Beta":
* User button fixes (kernel and flashing scripts)
* U-boot fixes for EHCI timeouts when doing a tftpboot

 conf/distro/angstrom-2008.1.conf                   |    3 +++ .../include/angstrom-2008-preferred-versions.inc   |    2 +-

 2 files changed, 4 insertions(+), 1 deletions(-)

I'm not sure if DISTRO_PR has to be bumped so I left it as is, please let me know if its required.

Thanks,
Joel

Acked-by on v1 1/1
#2 lore raw
In reply to Joel A Fernandes

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 09-07-11 02:21, Joel A Fernandes schreef:

Quoted 6 lines

This fixes all the issues noticed earlier with pulseaudio 0.9.15: * Pulseaudio keeping audio devices busy when run as per-user instance * Failure of pactl, pacmd etc to connect to the pulseaudio server

Signed-off-by: Joel A Fernandes
<[email protected]>

Tom, do you want to take this directly or should I do a pull request with this in it?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFOGCFbMkyGM64RGpERAiB+AJ9VdbP77X9RB9ticvZt1nza9HncegCgqJ97 iZVhWtlMPB8HG1QTtjsE41Q=
=29tt
-----END PGP SIGNATURE-----

#3 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 5 lines · Koen Kooi

Op 09-07-11 02:21, Joel A Fernandes schreef:

Quoted 3 lines

This fixes all the issues noticed earlier with pulseaudio 0.9.15: * Pulseaudio keeping audio devices busy when run as per-user instance * Failure of pactl, pacmd etc to connect to the pulseaudio server

Quoted 7 lines
Quoted 2 lines

Signed-off-by: Joel A Fernandes
<[email protected]>

Tom, do you want to take this directly or should I do a pull request with this in it?

I was going to grab this Sunday but got distracted. I see you put it in your current request, thanks!

- --
Tom Rini
Mentor Graphics Corporation
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJOGwtrAAoJEI4NMjfc3nJxMqUH/jl0RRrar1O+W6xfBNWYpwOu 1ws4Dht+RpCjiv2arS/4cBsTpzAD+l/AhkOVR4oHRoeXoMwrOQ8OAN7YG5BjqCFR XrDY4ZSxxECLZSWzsaRIOz8JuBO4R9d7F5C8/IuLc0arXX6nsDdTDQV7ClrRmqxG 2JpG4D1w/YDhiehyWJ6yTRvq9d1nfXaRo8PskdsDirX9wNzS5spad7ovyABOlNxe 6PmU0R4ypTUSkXDSd/3sSXLhufQ3JXoLKeDeSv0mqPI3ztXRNgNDDox1H8jL6A5D 5noz7liM31MOvbhDTFzQiu3qKylVCtPiChK/hA+9hI04OSQDrxd44J7e7xLHR5M= =lBGp
-----END PGP SIGNATURE-----

#4 lore raw
In reply to Joel A Fernandes

Am Freitag, den 08.07.2011, 19:21 -0500 schrieb Joel A Fernandes:

I do not know if the commit summary is correct and if it should be prepended with »angstrom«.

Quoted 3 lines

This fixes all the issues noticed earlier with pulseaudio 0.9.15:
* Pulseaudio keeping audio devices busy when run as per-user instance
* Failure of pactl, pacmd etc to connect to the pulseaudio server

Please always include links to corresponding list threads if they are available.

Quoted 4 lines

---
Notes:
* This has to go into the OpenEmbedded 2011.03-maintenance branch as there is no such configration file in the master branch

        $ git grep pulse conf/distro
        conf/distro/include/angstrom-2008-preferred-versions.inc:PREFERRED_VERSION_gst-pulse    = "0.9.7"
        conf/distro/include/angstrom-2008-preferred-versions.inc:PREFERRED_VERSION_pulseaudio   = "0.9.15"
        conf/distro/include/angstrom-2010-preferred-versions.inc:PREFERRED_VERSION_gst-pulse    = "0.9.7"
        conf/distro/include/angstrom-2010-preferred-versions.inc:PREFERRED_VERSION_pulseaudio   = "0.9.22"
        […]

So you your change could actually be applied to master?

Quoted 8 lines

* Please ignore the earlier patch "pulseaudio: Run as system-wide instance instead of per-user"

Applying this and the patch titled "beagleboard-test-scripts: Add a script flash-fs.sh for flashing NAND" will mark the "Alpha" build of the C5 image. Can this be tagged?

Things to go into "Beta":
* User button fixes (kernel and flashing scripts)
* U-boot fixes for EHCI timeouts when doing a tftpboot

Great, but this should have gone to a separate thread.

Quoted 9 lines
 conf/distro/angstrom-2008.1.conf                   |    3 +++
 .../include/angstrom-2008-preferred-versions.inc   |    2 +-
 2 files changed, 4 insertions(+), 1 deletions(-)
conf/distro/angstrom-2008.1.conf +0 -0
index ae1ed4c..7b4f25a 100644

conf/distro/angstrom-2008.1.conf PREFERRED_VERSION_binutils_avr32 = "2.17" · line 126

Quoted 6 lines
conf/distro/angstrom-2008.1.conf +3 -0
@@ -121,6 +121,9 @@ PREFERRED_VERSION_binutils_avr32 = "2.17"
 PREFERRED_VERSION_binutils-cross_avr32 = "2.17"
 PREFERRED_VERSION_binutils-cross-sdk_avr32 = "2.17"
 
+ANGSTROM_PULSEAUDIO_VERSION		= "0.9.15"
+ANGSTROM_PULSEAUDIO_VERSION_armv7a	= "0.9.22"
+

1. Where did you find this syntax?

	$ git grep PULSE conf/distro/

does not find anything in branch master.

2. Could you add an explanation, why 0.9.22 is not used for everything and only for armv7a. Is that because of commit cce5e648 [1]?

Quoted 8 lines
conf/distro/angstrom-2008.1.conf +0 -0
 PREFERRED_PROVIDER_dbus-glib             = "dbus-glib"
 PREFERRED_PROVIDER_hotplug               = "udev"
 PREFERRED_PROVIDER_opkg                 ?= "opkg"
conf/distro/include/angstrom-2008-preferred-versions.inc +0 -0
index b5b524a..e4b8bf1 100644

conf/distro/include/angstrom-2008-preferred-versions.inc PREFERRED_VERSION_pango-native = "1.24.4" · line 50

Quoted 8 lines
conf/distro/include/angstrom-2008-preferred-versions.inc +1 -1
@@ -44,7 +44,7 @@ PREFERRED_VERSION_pango-native     = "1.24.4"
 #PREFERRED_VERSION_pixman	= "0.13.2"
 PREFERRED_VERSION_pkgconfig	= "0.23"
 PREFERRED_VERSION_pkgconfig-native = "0.23"
-PREFERRED_VERSION_pulseaudio 	= "0.9.15"
+PREFERRED_VERSION_pulseaudio 	= "${ANGSTROM_PULSEAUDIO_VERSION}"
 PREFERRED_VERSION_python-pycairo = "1.8.0"
 PREFERRED_VERSION_qt4-tools-native = "${ANGSTROM_QT_VERSION}"
 PREFERRED_VERSION_qt4-tools-sdk = "${ANGSTROM_QT_VERSION}"

So I would prefer, if you would change the version just in this file and such a patch could go into branch master first.

Even better would be the following.

1. Package PA 0.9.23 for oe-dev. If I remember correctly I send all patches upstream and it should work for all architectures(?).
2. Prefer PA 0.9.23 for Ȧngström and other distributions.
3. Remove older PA versions.
4. Cherry pick these changes into branch 2011.03-maintenance.

Joel, do you have time and motivation to do that?

Thanks,

Paul

[1] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=cce5e648222525a0619f454ddc4f2253afca2821

#5 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 09-07-11 12:09, Paul Menzel schreef:

Quoted 1 line

1. Package PA 0.9.23 for oe-dev.

That could work, apart from oe-dev being a dead-end. OE-core has .23 already

Quoted 3 lines

2. Prefer PA 0.9.23 for Ȧngström and other distributions. 3. Remove older PA versions. 4. Cherry pick these changes into branch 2011.03-maintenance.

That won't work, the gcc 4.3.x angstrom is using in maintenance lacks the needed atomic ops (even after the merge from buglabs) to build it for !armv7a. To keep things single I'd recommend the following:

* enable .22 for armv7a, leave the rest as-is
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFOGM1lMkyGM64RGpERAjjzAJ9KvJaiB0ypsZFQwChE3PV6Q7Ph7wCdEXpO zofD3v8F8h1/xzgpFvNFnJw=
=a6bP
-----END PGP SIGNATURE-----