Skip to contentSkip to conversation

dell-laptop - using buffer without mutex_lock

PATCH New Jose Alonso 1 participant 1 message Jul 10, 2011 x86 platform drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dell-laptop - using buffer without mutex_lock

(resending patch with tabs and signed-off-by)

Using buffer->output[1] without mutex_lock()

version linux-3.0-rc6
--

drivers/platform/x86/dell-laptop.c +3 -3
@@ -560,11 +560,11 @@
 	else
 		dell_send_request(buffer, 0, 1);
 
+	ret = buffer->output[1];
+
 out:
 	release_buffer();
-	if (ret)
-		return ret;
-	return buffer->output[1];
+	return ret;
 }
 
 static const struct backlight_ops dell_ops = {