Skip to contentSkip to conversation

wimax: delete struct wimax_dev field rfkill_input

PATCH In review Randy Dunlap 3 participants 3 messages Jul 11, 2011 – Jul 13, 2011 Networking

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wimax: delete struct wimax_dev field rfkill_input

From: Randy Dunlap <[email protected]>

"make htmldocs" warns that struct member "rfkill_input" does not have a description. After searching all kernel .[hc] files, this field is not used, so remove it.

Warning(include/net/wimax.h:432): No description found for parameter 'rfkill_input'

---
 include/net/wimax.h |    1 -
 1 file changed, 1 deletion(-)
include/net/wimax.h +0 -1
@@ -423,7 +423,6 @@ struct wimax_dev {
 	int (*op_reset)(struct wimax_dev *wimax_dev);
 
 	struct rfkill *rfkill;
-	struct input_dev *rfkill_input;
 	unsigned rf_hw;
 	unsigned rf_sw;
 	char name[32];
#1 lore raw

Hi Randy

Quoted 5 lines

From: Randy Dunlap <[email protected]>

"make htmldocs" warns that struct member "rfkill_input" does not have a description. After searching all kernel .[hc] files, this field is not used, so remove it.

Vitaly sent a patch a couple weeks ago to do this same cleanup.

Thank you anyway!

#2 lore raw
Quoted 5 lines · Inaky

Hi Randy

Quoted 2 lines

From: Randy Dunlap <[email protected]>

Quoted 7 lines
Quoted 3 lines

"make htmldocs" warns that struct member "rfkill_input" does not have a description.  After searching all kernel .[hc] files, this field is not used, so remove it.

Vitaly sent a patch a couple weeks ago to do this same cleanup.

Thank you anyway!

Yes, it's in David's net-next tree:

http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=commit;h=c6af9c406ceb3434281cf230938453931dcbab75

Thanks,
Vitaliy