Skip to contentSkip to conversation

sched: Cleanup duplicate local variable in {enqueue_dequeue}_task_fair

PATCH Lin Ming 1 participant 2 messages Jul 22, 2011

lore
Share & tools
lore

Lin Ming

author
#0 lore raw

No need to define a new "cfs_rq" variable in the "for" block. Just use the one at the top of the function.

Signed-off-by Lin Ming <[email protected]>
---
 kernel/sched_fair.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
kernel/sched_fair.c +2 -2
index e7d67a9..47d6b17 100644
@@ -1336,7 +1336,7 @@ enqueue_task_fair(struct rq *rq, struct task_struct *p, int flags)
 	}
 
 	for_each_sched_entity(se) {
-		struct cfs_rq *cfs_rq = cfs_rq_of(se);
+		cfs_rq = cfs_rq_of(se);
 
 		update_cfs_load(cfs_rq, 0);
 		update_cfs_shares(cfs_rq);

@@ -1376,7 +1376,7 @@ static void dequeue_task_fair(struct rq *rq, struct task_struct *p, int flags)
 	}
 
 	for_each_sched_entity(se) {
-		struct cfs_rq *cfs_rq = cfs_rq_of(se);
+		cfs_rq = cfs_rq_of(se);
 
 		update_cfs_load(cfs_rq, 0);
 		update_cfs_shares(cfs_rq);
author
#1 lore raw

[tip:sched/core] sched: Cleanup duplicate local variable in [enqueue|dequeue]_task_fair

Commit-ID:  0f3171438fc917b9f6b8b60dbb7a3fff9a0f68fd
Gitweb:     http://git.kernel.org/tip/0f3171438fc917b9f6b8b60dbb7a3fff9a0f68fd
Author:     Lin Ming <[email protected]>
AuthorDate: Fri, 22 Jul 2011 09:14:31 +0800
Committer:  Ingo Molnar <[email protected]>
CommitDate: Fri, 22 Jul 2011 12:47:22 +0200

sched: Cleanup duplicate local variable in [enqueue|dequeue]_task_fair

No need to define a new "cfs_rq" variable in the "for" block. Just use the one at the top of the function.

Signed-off-by Lin Ming <[email protected]>
Cc Peter Zijlstra <[email protected]>
Link http://lkml.kernel.org/r/[email protected] open here
Signed-off-by Ingo Molnar <[email protected]>
---
 kernel/sched_fair.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
kernel/sched_fair.c +2 -2
index a2ecbaa..bc8ee99 100644
@@ -1317,7 +1317,7 @@ enqueue_task_fair(struct rq *rq, struct task_struct *p, int flags)
 	}
 
 	for_each_sched_entity(se) {
-		struct cfs_rq *cfs_rq = cfs_rq_of(se);
+		cfs_rq = cfs_rq_of(se);
 
 		update_cfs_load(cfs_rq, 0);
 		update_cfs_shares(cfs_rq);

@@ -1360,7 +1360,7 @@ static void dequeue_task_fair(struct rq *rq, struct task_struct *p, int flags)
 	}
 
 	for_each_sched_entity(se) {
-		struct cfs_rq *cfs_rq = cfs_rq_of(se);
+		cfs_rq = cfs_rq_of(se);
 
 		update_cfs_load(cfs_rq, 0);
 		update_cfs_shares(cfs_rq);