Skip to contentSkip to conversation

ASoC: Disable wm_hubs periodic DC servo update

PATCH In review Mark Brown 2 participants 2 messages Jul 28, 2011 – Jul 29, 2011

Subsystems (3)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 ASoC: Disable wm_hubs periodic DC servo update

This does not function correctly in all circumstances so disable the periodic updates unconditionally for stable; a future patch will reenable where appropriate.

---
 sound/soc/codecs/wm_hubs.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
sound/soc/codecs/wm_hubs.c +1 -2
index 4de6794..4416a76 100644
@@ -440,9 +440,8 @@ static int hp_event(struct snd_soc_dapm_widget *w,
 		reg |= WM8993_HPOUT1L_DLY | WM8993_HPOUT1R_DLY;
 		snd_soc_write(codec, WM8993_ANALOGUE_HP_0, reg);
 
-		/* Smallest supported update interval */
 		snd_soc_update_bits(codec, WM8993_DC_SERVO_1,
-				    WM8993_DCS_TIMER_PERIOD_01_MASK, 1);
+				    WM8993_DCS_TIMER_PERIOD_01_MASK, 0);
 
 		calibrate_dc_servo(codec);
 
Signature · 1 line
1.7.5.4
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Mark Brown

This does not function correctly in all circumstances so disable the periodic updates unconditionally for stable; a future patch will reenable where appropriate.

Quoted 18 lines
 sound/soc/codecs/wm_hubs.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
sound/soc/codecs/wm_hubs.c +1 -2
index 4de6794..4416a76 100644
@@ -440,9 +440,8 @@ static int hp_event(struct snd_soc_dapm_widget *w,
 		reg |= WM8993_HPOUT1L_DLY | WM8993_HPOUT1R_DLY;
 		snd_soc_write(codec, WM8993_ANALOGUE_HP_0, reg);
 
-		/* Smallest supported update interval */
 		snd_soc_update_bits(codec, WM8993_DC_SERVO_1,
-				    WM8993_DCS_TIMER_PERIOD_01_MASK, 1);
+				    WM8993_DCS_TIMER_PERIOD_01_MASK, 0);
 
 		calibrate_dc_servo(codec);