mmc: tmio: eliminate unused variable 'mmc' warning
Subsystems (2)
PATCH 1/1 mmc: tmio: eliminate unused variable 'mmc' warning
Fix below compile warning:
CC drivers/mmc/host/tmio_mmc.odrivers/mmc/host/tmio_mmc.c: In function 'tmio_mmc_suspend':drivers/mmc/host/tmio_mmc.c:30: warning: unused variable 'mmc' drivers/mmc/host/tmio_mmc.c: In function 'tmio_mmc_resume':drivers/mmc/host/tmio_mmc.c:45: warning: unused variable 'mmc'
--- drivers/mmc/host/tmio_mmc.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/mmc/host/tmio_mmc.c +0 -2
@@ -27,7 +27,6 @@static int tmio_mmc_suspend (struct platform_device *dev,pm_message_t state) {const struct mfd_cell *cell =mfd_get_cell (dev); -struct mmc_host *mmc =platform_get_drvdata (dev);int ret; ret =tmio_mmc_host_suspend (&dev->dev);
@@ -42,7 +41,6 @@ static int tmio_mmc_suspend(struct platform_device *dev, pm_message_t state)static int tmio_mmc_resume (struct platform_device *dev) {const struct mfd_cell *cell =mfd_get_cell (dev); -struct mmc_host *mmc =platform_get_drvdata (dev);int ret =0 ;/* Tell the MFD core we are ready to be enabled */
Signature · 1 line
1.7.4.1
Quoted 8 lines · Axel Lin
Fix below compile warning:
CCdrivers/mmc/host/tmio_mmc.odrivers/mmc/host/tmio_mmc.c: In function 'tmio_mmc_suspend':drivers/mmc/host/tmio_mmc.c:30: warning: unused variable 'mmc'drivers/mmc/host/tmio_mmc.c: In function 'tmio_mmc_resume':drivers/mmc/host/tmio_mmc.c:45: warning: unused variable 'mmc'Signed-off-by Axel Lin <[email protected]>
Good for 3.1, do we also push such "harmless" compiler warning fixes to stable?
Thanks
Guennadi
Quoted 29 lines
--- drivers/mmc/host/tmio_mmc.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)drivers/mmc/host/tmio_mmc.c +0
-2@@ -27,7 +27,6 @@static int tmio_mmc_suspend (struct platform_device *dev,pm_message_t state) {const struct mfd_cell *cell =mfd_get_cell (dev); -struct mmc_host *mmc =platform_get_drvdata (dev);int ret; ret =tmio_mmc_host_suspend (&dev->dev);@@ -42,7 +41,6 @@ static int tmio_mmc_suspend(struct platform_device *dev, pm_message_t state)static int tmio_mmc_resume (struct platform_device *dev) {const struct mfd_cell *cell =mfd_get_cell (dev); -struct mmc_host *mmc =platform_get_drvdata (dev);int ret =0 ;/* Tell the MFD core we are ready to be enabled */ Signature · 1 line
1.7.4.1
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
Hi,
Quoted 9 lines · Guennadi Liakhovetski
Quoted 7 lines · Axel Lin
Fix below compile warning:
CCdrivers/mmc/host/tmio_mmc.odrivers/mmc/host/tmio_mmc.c: In function 'tmio_mmc_suspend':drivers/mmc/host/tmio_mmc.c:30: warning: unused variable 'mmc'drivers/mmc/host/tmio_mmc.c: In function 'tmio_mmc_resume':drivers/mmc/host/tmio_mmc.c:45: warning: unused variable 'mmc'
Quoted 6 lines
Quoted 1 line
Signed-off-by Axel Lin <[email protected]>Good for 3.1, do we also push such "harmless" compiler warning fixes to stable?
Pushed for 3.1, thanks. I don't think this is appropriate for stable.
- Chris.
Signature · 2 lines
Chris Ball <[email protected]> <http://printf.net/> One Laptop Per Child
Quoted 7 lines · Chris Ball
Quoted 1 line
Good for 3.1, do we also push such "harmless" compiler warning fixes
to
Quoted 3 lines
stable?
Pushed for 3.1, thanks. I don't think this is appropriate for stable.
Why on earth not? its obviously correct...
Hi Ian,
Quoted 9 lines · Ian Molton
Quoted 6 lines · Chris Ball
Quoted 4 lines
Good for 3.1, do we also push such "harmless" compiler warning fixes to stable?
Pushed for 3.1, thanks. I don't think this is appropriate for stable.
Why on earth not? its obviously correct...
Because the rules for stable@ consist of more than the patch being obviously correct.
You seem to have chosen one stable@ rule that this patch meets, and ignored the other nine which it mostly does not meet:
Documentation/stable_kernel_rules.txt:
- It must fix a real bug that bothers people (not a, "This could be a problem..." type thing).
- It must fix a problem that causes a build error (but not for things marked CONFIG_BROKEN), an oops, a hang, data corruption, a real security issue, or some "oh, that's not good" issue. In short, something critical.
- It cannot contain any "trivial" fixes in it (spelling changes, whitespace cleanups, etc).
Thanks,
- Chris.
Signature · 2 lines
Chris Ball <[email protected]> <http://printf.net/> One Laptop Per Child