Skip to contentSkip to conversation

printk: add module parameter console_suspend_enabled to control console_suspend_enabled

PATCH In review Yanmin Zhang 2 participants 6 messages Aug 9, 2011 – Aug 10, 2011

lore
Share & tools
lore

Yanmin Zhang

author
#0 lore raw

PATCH 1/1 printk: add module parameter console_suspend_enabled to control console_suspend_enabled

We are enabling some power features on medfield. To test suspend-2-RAM conveniently, we need turn on/off console_suspend_enabled frequently.

Below patch adds a module parameter, so users could change it by:
/sys/module/printk/parameters/console_suspend_enabled

Signed-off-by Yanmin Zhang <[email protected]>
---
 kernel/printk.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
kernel/printk.c +2 -0
index 37dff34..ce00f1b 100644
@@ -1106,6 +1106,8 @@ static int __init console_suspend_disable(char *str)
 	return 1;
 }
 __setup("no_console_suspend", console_suspend_disable);
+module_param_named(console_suspend_enabled, console_suspend_enabled,
+		bool, S_IRUGO | S_IWUSR);
 
 /**
  * suspend_console - suspend the console subsystem
Signature · 1 line
1.7.1
#1 lore raw
Quoted 5 lines · Yanmin Zhang

We are enabling some power features on medfield. To test suspend-2-RAM conveniently, we need turn on/off console_suspend_enabled frequently.

Below patch adds a module parameter, so users could change it by:
/sys/module/printk/parameters/console_suspend_enabled

What about change name to no_console_suspend? Or it will be weird if boot kernel with both no_console_suspend and printk.console_suspend_enabled set.

Quoted 32 lines
Signed-off-by Yanmin Zhang <[email protected]>

---
 kernel/printk.c |    2 ++

 1 files changed, 2 insertions(+), 0 deletions(-)
kernel/printk.c +2 -1
index 37dff34..ce00f1b 100644
@@ -1106,6 +1106,8 @@ static int __init console_suspend_disable(char *str)
        return 1;
  }
  __setup("no_console_suspend", console_suspend_disable);
+module_param_named(console_suspend_enabled, console_suspend_enabled,
+               bool, S_IRUGO | S_IWUSR);
 
  /**
  * suspend_console - suspend the console subsystem
--

1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Signature · 2 lines
Regards
Yang RuiRui
author
#2 lore raw

Re: [PATCH ] printk: add module parameter console_suspend to control console_suspend_enabled

Quoted 11 lines · Dave Young
Quoted 5 lines · Yanmin Zhang

We are enabling some power features on medfield. To test suspend-2-RAM conveniently, we need turn on/off console_suspend_enabled frequently.

Below patch adds a module parameter, so users could change it by:
/sys/module/printk/parameters/console_suspend_enabled

What about change name to no_console_suspend? Or it will be weird if boot kernel with both no_console_suspend and printk.console_suspend_enabled set.

Thanks for the comments. How about changing the name to console_suspend? If changing it to no_console_suspend, we can't map the input to console_suspend_enabled directly.

Below is the new patch.

---

We are enabling some power features on medfield. To test suspend-2-RAM conveniently, we need turn on/off console_suspend_enabled frequently.

Below patch adds a module parameter, so users could change it by:
/sys/module/printk/parameters/console_suspend

Signed-off-by Yanmin Zhang <[email protected]>
---
 kernel/printk.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
kernel/printk.c +2 -0
index 37dff34..1decef6 100644
@@ -1106,6 +1106,8 @@ static int __init console_suspend_disable(char *str)
 	return 1;
 }
 __setup("no_console_suspend", console_suspend_disable);
+module_param_named(console_suspend, console_suspend_enabled,
+		bool, S_IRUGO | S_IWUSR);
 
 /**
  * suspend_console - suspend the console subsystem
Signature · 1 line
1.7.1
#3 lore raw

Re: [PATCH ] printk: add module parameter console_suspend to control console_suspend_enabled

Hi,

Quoted 9 lines · Yanmin Zhang
Quoted 8 lines · Dave Young
Quoted 5 lines · Yanmin Zhang

We are enabling some power features on medfield. To test suspend-2-RAM conveniently, we need turn on/off console_suspend_enabled frequently.

Below patch adds a module parameter, so users could change it by:
/sys/module/printk/parameters/console_suspend_enabled

Quoted 6 lines
Quoted 3 lines

What about change name to no_console_suspend? Or it will be weird if boot kernel with both no_console_suspend and printk.console_suspend_enabled set.

Thanks for the comments. How about changing the name to console_suspend? If changing it to no_console_suspend, we can't map the input to console_suspend_enabled directly.

How about use module_param_cb instead of module_param_named?

Quoted 36 lines

Below is the new patch.

---

We are enabling some power features on medfield. To test suspend-2-RAM conveniently, we need turn on/off console_suspend_enabled frequently.

Below patch adds a module parameter, so users could change it by:
/sys/module/printk/parameters/console_suspend

Signed-off-by Yanmin Zhang <[email protected]>

---
 kernel/printk.c |    2 ++

 1 files changed, 2 insertions(+), 0 deletions(-)
kernel/printk.c +2 -1
index 37dff34..1decef6 100644
@@ -1106,6 +1106,8 @@ static int __init console_suspend_disable(char *str)
        return 1;
  }
  __setup("no_console_suspend", console_suspend_disable);
+module_param_named(console_suspend, console_suspend_enabled,
+               bool, S_IRUGO | S_IWUSR);
 
  /**
  * suspend_console - suspend the console subsystem
--

1.7.1

Signature · 2 lines
Regards
Yang RuiRui
author
#4 lore raw

Re: [PATCH ] printk: add module parameter console_suspend to control console_suspend_enabled

Quoted 13 lines · Dave Young

Hi,

Quoted 9 lines · Yanmin Zhang
Quoted 8 lines · Dave Young
Quoted 5 lines · Yanmin Zhang

We are enabling some power features on medfield. To test suspend-2-RAM conveniently, we need turn on/off console_suspend_enabled frequently.

Below patch adds a module parameter, so users could change it by:
/sys/module/printk/parameters/console_suspend_enabled

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

What about change name to no_console_suspend? Or it will be weird if boot kernel with both no_console_suspend and printk.console_suspend_enabled set.

Thanks for the comments. How about changing the name to console_suspend? If changing it to no_console_suspend, we can't map the input to console_suspend_enabled directly.

How about use module_param_cb instead of module_param_named?

Thanks for the pointer. Indeed, we could use module_param_cb to support the input/output parsing. Is it too complicated to use it here? It's better to keep simple. The new name console_suspend is clearer than old name.

Quoted 32 lines
Quoted 32 lines

Below is the new patch.

---

We are enabling some power features on medfield. To test suspend-2-RAM conveniently, we need turn on/off console_suspend_enabled frequently.

Below patch adds a module parameter, so users could change it by:
/sys/module/printk/parameters/console_suspend

Signed-off-by Yanmin Zhang <[email protected]>
---
 kernel/printk.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
kernel/printk.c +2 -1
index 37dff34..1decef6 100644
@@ -1106,6 +1106,8 @@ static int __init console_suspend_disable(char *str)
       return 1;
 }
 __setup("no_console_suspend", console_suspend_disable);
+module_param_named(console_suspend, console_suspend_enabled,
+               bool, S_IRUGO | S_IWUSR);
 
 /**
 * suspend_console - suspend the console subsystem
--
#5 lore raw

Re: [PATCH ] printk: add module parameter console_suspend to control console_suspend_enabled

Quoted 17 lines · Yanmin Zhang
Quoted 16 lines · Dave Young

Hi,

Quoted 12 lines · Yanmin Zhang
Quoted 11 lines · Dave Young
Quoted 5 lines · Yanmin Zhang

We are enabling some power features on medfield. To test suspend-2-RAM conveniently, we need turn on/off console_suspend_enabled frequently.

Below patch adds a module parameter, so users could change it by:
/sys/module/printk/parameters/console_suspend_enabled

What about change name to no_console_suspend? Or it will be weird if boot kernel with both no_console_suspend and printk.console_suspend_enabled set.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

Thanks for the comments. How about changing the name to console_suspend? If changing it to no_console_suspend, we can't map the input to console_suspend_enabled directly.

How about use module_param_cb instead of module_param_named?

Thanks for the pointer. Indeed, we could use module_param_cb to support the input/output parsing. Is it too complicated to use it here? It's better to keep simple. The new name console_suspend is clearer than old name.

But it is a little bit confused if the param is not consistant with no_console_suspend while use in cmdline. If we have printk.console_suspend param, then maybe no_console_suspend can be killed?

Anyway, I will no insist on this.

Quoted 36 lines
Quoted 33 lines
Quoted 33 lines

Below is the new patch.

---

We are enabling some power features on medfield. To test suspend-2-RAM conveniently, we need turn on/off console_suspend_enabled frequently.

Below patch adds a module parameter, so users could change it by:
/sys/module/printk/parameters/console_suspend

Signed-off-by Yanmin Zhang <[email protected]>

---
 kernel/printk.c |    2 ++

 1 files changed, 2 insertions(+), 0 deletions(-)
kernel/printk.c +2 -1
index 37dff34..1decef6 100644
@@ -1106,6 +1106,8 @@ static int __init console_suspend_disable(char *str)
        return 1;
  }
  __setup("no_console_suspend", console_suspend_disable);
+module_param_named(console_suspend, console_suspend_enabled,
+               bool, S_IRUGO | S_IWUSR);
 
  /**
  * suspend_console - suspend the console subsystem
--
Signature · 2 lines
Regards
Yang RuiRui