Skip to contentSkip to conversation

ARM: S3C2443: Remove redundant s3c_register_clocks call for init_clocks

PATCH In review Axel Lin 4 participants 4 messages Aug 16, 2011 – Oct 14, 2011

Subsystems (2)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 ARM: S3C2443: Remove redundant s3c_register_clocks call for init_clocks

Since commit af337f3e633a198034a99450416257ddf2307497
"ARM: S3C2443: Move parts of the clock code to common clock file", the init_clocks array is moved to arch/arm/plat-s3c24xx/s3c2443-clock.c. Now we call s3c_register_clocks for init_clocks in s3c2443_common_init_clocks.

Thus we can remove the empty init_clocks array here and remove the redundant s3c_register_clocks call for init_clocks in s3c2443_init_clocks.

---
 arch/arm/mach-s3c2443/clock.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)
arch/arm/mach-s3c2443/clock.c +0 -7
index a1a7176..4018dbe 100644
@@ -305,9 +305,6 @@ static struct clk init_clocks_off[] = {
 	}
 };
 
-static struct clk init_clocks[] = {
-};
-
 /* clocks to add straight away */
 
 static struct clksrc_clk *clksrcs[] __initdata = {
@@ -345,10 +342,6 @@ void __init s3c2443_init_clocks(int xtal)
 	for (ptr = 0; ptr < ARRAY_SIZE(clksrcs); ptr++)
 		s3c_register_clksrc(clksrcs[ptr], 1);
 
-	/* register clocks from clock array */
-
-	s3c_register_clocks(init_clocks, ARRAY_SIZE(init_clocks));
-
 	/* We must be careful disabling the clocks we are not intending to
 	 * be using@boot time, as subsystems such as the LCD which do
 	 * their own DMA requests to the bus can cause the system to lockup
Signature · 1 line
1.7.4.1
#1 lore raw

Am Dienstag, 16. August 2011, 05:04:41 schrieb Axel Lin:

Quoted 8 lines

Since commit af337f3e633a198034a99450416257ddf2307497
"ARM: S3C2443: Move parts of the clock code to common clock file", the init_clocks array is moved to arch/arm/plat-s3c24xx/s3c2443-clock.c. Now we call s3c_register_clocks for init_clocks in s3c2443_common_init_clocks.

Thus we can remove the empty init_clocks array here and remove the redundant s3c_register_clocks call for init_clocks in s3c2443_init_clocks.

I'm not 100% sure, but you might want to include Kukjin Kim <[email protected]> who seems to be handling the Samsung-stuff most of the time.

Heiko

Quoted 31 lines
---
 arch/arm/mach-s3c2443/clock.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)
arch/arm/mach-s3c2443/clock.c +0 -7
index a1a7176..4018dbe 100644
@@ -305,9 +305,6 @@ static struct clk init_clocks_off[] = {
 	}
 };
 
-static struct clk init_clocks[] = {
-};
-
 /* clocks to add straight away */
 
 static struct clksrc_clk *clksrcs[] __initdata = {
@@ -345,10 +342,6 @@ void __init s3c2443_init_clocks(int xtal)
 	for (ptr = 0; ptr < ARRAY_SIZE(clksrcs); ptr++)
 		s3c_register_clksrc(clksrcs[ptr], 1);
 
-	/* register clocks from clock array */
-
-	s3c_register_clocks(init_clocks, ARRAY_SIZE(init_clocks));
-
 	/* We must be careful disabling the clocks we are not intending to
 	 * be using at boot time, as subsystems such as the LCD which do
 	 * their own DMA requests to the bus can cause the system to lockup
#2 lore raw
Quoted 7 lines · Heiko St?bner

Am Dienstag, 16. August 2011, 05:04:41 schrieb Axel Lin:

Quoted 6 lines

Since commit af337f3e633a198034a99450416257ddf2307497
"ARM: S3C2443: Move parts of the clock code to common clock file", the init_clocks array is moved to arch/arm/plat-s3c24xx/s3c2443-clock.c. Now we call s3c_register_clocks for init_clocks in s3c2443_common_init_clocks.

Quoted 7 lines
Quoted 2 lines

Thus we can remove the empty init_clocks array here and remove the redundant s3c_register_clocks call for init_clocks in s3c2443_init_clocks.

I'm not 100% sure, but you might want to include Kukjin Kim <[email protected]> who seems to be handling the Samsung-stuff most of the time.

Heiko

I'll pick this up, as there's plans to turn all the mach-s3c24xxs into one big directory.

Quoted 32 lines
Quoted 31 lines
---
 arch/arm/mach-s3c2443/clock.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)
arch/arm/mach-s3c2443/clock.c +0 -7
index a1a7176..4018dbe 100644
@@ -305,9 +305,6 @@ static struct clk init_clocks_off[] = {
 	}
 };
 
-static struct clk init_clocks[] = {
-};
-
 /* clocks to add straight away */
 
 static struct clksrc_clk *clksrcs[] __initdata = {
@@ -345,10 +342,6 @@ void __init s3c2443_init_clocks(int xtal)
 	for (ptr = 0; ptr < ARRAY_SIZE(clksrcs); ptr++)
 		s3c_register_clksrc(clksrcs[ptr], 1);
 
-	/* register clocks from clock array */
-
-	s3c_register_clocks(init_clocks, ARRAY_SIZE(init_clocks));
-
 	/* We must be careful disabling the clocks we are not intending to
 	 * be using at boot time, as subsystems such as the LCD which do
 	 * their own DMA requests to the bus can cause the system to lockup
Signature · 3 lines
Ben Dooks, ben at fluff.org, http://www.fluff.org/ben/

Large Hadron Colada: A large Pina Colada that makes the universe disappear.
#3 lore raw
In reply to Axel Lin
Quoted 40 lines · Axel Lin

Since commit af337f3e633a198034a99450416257ddf2307497
"ARM: S3C2443: Move parts of the clock code to common clock file", the init_clocks array is moved to arch/arm/plat-s3c24xx/s3c2443-clock.c. Now we call s3c_register_clocks for init_clocks in s3c2443_common_init_clocks.

Thus we can remove the empty init_clocks array here and remove the redundant s3c_register_clocks call for init_clocks in s3c2443_init_clocks.

---
 arch/arm/mach-s3c2443/clock.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)
arch/arm/mach-s3c2443/clock.c +0 -8
index a1a7176..4018dbe 100644
@@ -305,9 +305,6 @@ static struct clk init_clocks_off[] = {
 	}
 };
 
-static struct clk init_clocks[] = {
-};
-
 /* clocks to add straight away */
 
 static struct clksrc_clk *clksrcs[] __initdata = {
@@ -345,10 +342,6 @@ void __init s3c2443_init_clocks(int xtal)
 	for (ptr = 0; ptr < ARRAY_SIZE(clksrcs); ptr++)
 		s3c_register_clksrc(clksrcs[ptr], 1);
 
-	/* register clocks from clock array */
-
-	s3c_register_clocks(init_clocks, ARRAY_SIZE(init_clocks));
-
 	/* We must be careful disabling the clocks we are not intending to
 	 * be using at boot time, as subsystems such as the LCD which do
 	 * their own DMA requests to the bus can cause the system to lockup
--
Quoted 1 line

1.7.4.1

Looks ok, applied.
Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.