Skip to contentSkip to conversation

video: ep93xx-fb: add missing include of linux/module.h

PATCH In review Axel Lin 4 participants 9 messages Aug 21, 2011 – Aug 24, 2011 Framebuffer layer

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 video: ep93xx-fb: add missing include of linux/module.h

ep93xx-fb.c uses interfaces from linux/module.h,
so it should include that file. This patch fixes below build errors.

CC drivers/video/ep93xx-fb.o
drivers/video/ep93xx-fb.c:120: error: expected ')' before 'int' drivers/video/ep93xx-fb.c:122: error: expected ')' before string constant drivers/video/ep93xx-fb.c:409: error: 'THIS_MODULE' undeclared here (not in a function) drivers/video/ep93xx-fb.c:645: error: expected declaration specifiers or '...' before string constant drivers/video/ep93xx-fb.c:645: warning: data definition has no type or storage class drivers/video/ep93xx-fb.c:645: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION' drivers/video/ep93xx-fb.c:645: warning: function declaration isn't a prototype drivers/video/ep93xx-fb.c:646: error: expected declaration specifiers or '...' before string constant drivers/video/ep93xx-fb.c:646: warning: data definition has no type or storage class drivers/video/ep93xx-fb.c:646: warning: type defaults to 'int' in declaration of 'MODULE_ALIAS' drivers/video/ep93xx-fb.c:646: warning: function declaration isn't a prototype drivers/video/ep93xx-fb.c:647: error: expected declaration specifiers or '...' before string constant drivers/video/ep93xx-fb.c:647: warning: data definition has no type or storage class drivers/video/ep93xx-fb.c:647: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR' drivers/video/ep93xx-fb.c:647: warning: function declaration isn't a prototype drivers/video/ep93xx-fb.c:649: error: expected declaration specifiers or '...' before string constant drivers/video/ep93xx-fb.c:649: warning: data definition has no type or storage class drivers/video/ep93xx-fb.c:649: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE' drivers/video/ep93xx-fb.c:649: warning: function declaration isn't a prototype make[2]: *** [drivers/video/ep93xx-fb.o] Error 1
make[1]: *** [drivers/video] Error 2
make: *** [drivers] Error 2

---
 drivers/video/ep93xx-fb.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/video/ep93xx-fb.c +1 -0
index 40e5f17..8133a9d 100644
@@ -17,6 +17,7 @@
  *
  */
 
+#include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/dma-mapping.h>
 #include <linux/slab.h>
Signature · 1 line
1.7.4.1
Acked-by on v1 1/1
#1 lore raw
Quoted 2 lines · Axel Lin

ep93xx-fb.c uses interfaces from linux/module.h,
so it should include that file. This patch fixes below build errors.

What actually changed to make these files broken? Did some other header previously include module.h for us? How many other drivers are broken?

Anyway, the change is okay.

Quoted 41 lines

CC drivers/video/ep93xx-fb.o
drivers/video/ep93xx-fb.c:120: error: expected ')' before 'int' drivers/video/ep93xx-fb.c:122: error: expected ')' before string constant drivers/video/ep93xx-fb.c:409: error: 'THIS_MODULE' undeclared here (not in a function) drivers/video/ep93xx-fb.c:645: error: expected declaration specifiers or '...' before string constant drivers/video/ep93xx-fb.c:645: warning: data definition has no type or storage class drivers/video/ep93xx-fb.c:645: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION' drivers/video/ep93xx-fb.c:645: warning: function declaration isn't a prototype drivers/video/ep93xx-fb.c:646: error: expected declaration specifiers or '...' before string constant drivers/video/ep93xx-fb.c:646: warning: data definition has no type or storage class drivers/video/ep93xx-fb.c:646: warning: type defaults to 'int' in declaration of 'MODULE_ALIAS' drivers/video/ep93xx-fb.c:646: warning: function declaration isn't a prototype drivers/video/ep93xx-fb.c:647: error: expected declaration specifiers or '...' before string constant drivers/video/ep93xx-fb.c:647: warning: data definition has no type or storage class drivers/video/ep93xx-fb.c:647: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR' drivers/video/ep93xx-fb.c:647: warning: function declaration isn't a prototype drivers/video/ep93xx-fb.c:649: error: expected declaration specifiers or '...' before string constant drivers/video/ep93xx-fb.c:649: warning: data definition has no type or storage class drivers/video/ep93xx-fb.c:649: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE' drivers/video/ep93xx-fb.c:649: warning: function declaration isn't a prototype make[2]: *** [drivers/video/ep93xx-fb.o] Error 1
make[1]: *** [drivers/video] Error 2
make: *** [drivers] Error 2

---
  drivers/video/ep93xx-fb.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
drivers/video/ep93xx-fb.c +1 -0
index 40e5f17..8133a9d 100644
@@ -17,6 +17,7 @@
   *
   */
 
+#include<linux/module.h>
  #include<linux/platform_device.h>
  #include<linux/dma-mapping.h>
  #include<linux/slab.h>
#2 lore raw
Quoted 11 lines · Ryan Mallon
Quoted 2 lines · Axel Lin

ep93xx-fb.c uses interfaces from linux/module.h,
so it should include that file. This patch fixes below build errors.

What actually changed to make these files broken? Did some other header previously include module.h for us? How many other drivers are broken?

Anyway, the change is okay.

Actually, having a second look at this it does not look right.

drivers/video/ep93xx-fb.c includes linux/platform.h (as its first include), which includes linux/driver.h, which includes linux/module.h.

Just tested on Linus' latest tree and both this driver and the ep93xx backlight driver build fine. What kernel version are you using?

~Ryan

Quoted 61 lines
Quoted 60 lines

CC drivers/video/ep93xx-fb.o
drivers/video/ep93xx-fb.c:120: error: expected ')' before 'int' drivers/video/ep93xx-fb.c:122: error: expected ')' before string constant
drivers/video/ep93xx-fb.c:409: error: 'THIS_MODULE' undeclared here (not in a function)
drivers/video/ep93xx-fb.c:645: error: expected declaration specifiers or '...' before string constant drivers/video/ep93xx-fb.c:645: warning: data definition has no type or storage class
drivers/video/ep93xx-fb.c:645: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION' drivers/video/ep93xx-fb.c:645: warning: function declaration isn't a prototype
drivers/video/ep93xx-fb.c:646: error: expected declaration specifiers or '...' before string constant drivers/video/ep93xx-fb.c:646: warning: data definition has no type or storage class
drivers/video/ep93xx-fb.c:646: warning: type defaults to 'int' in declaration of 'MODULE_ALIAS' drivers/video/ep93xx-fb.c:646: warning: function declaration isn't a prototype
drivers/video/ep93xx-fb.c:647: error: expected declaration specifiers or '...' before string constant drivers/video/ep93xx-fb.c:647: warning: data definition has no type or storage class
drivers/video/ep93xx-fb.c:647: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR' drivers/video/ep93xx-fb.c:647: warning: function declaration isn't a prototype
drivers/video/ep93xx-fb.c:649: error: expected declaration specifiers or '...' before string constant drivers/video/ep93xx-fb.c:649: warning: data definition has no type or storage class
drivers/video/ep93xx-fb.c:649: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE' drivers/video/ep93xx-fb.c:649: warning: function declaration isn't a prototype
make[2]: *** [drivers/video/ep93xx-fb.o] Error 1
make[1]: *** [drivers/video] Error 2
make: *** [drivers] Error 2

---
  drivers/video/ep93xx-fb.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
drivers/video/ep93xx-fb.c +1 -0
index 40e5f17..8133a9d 100644
@@ -17,6 +17,7 @@
   *
   */
 
+#include<linux/module.h>
  #include<linux/platform_device.h>
  #include<linux/dma-mapping.h>
  #include<linux/slab.h>
author
#3 lore raw

2011/8/22 Ryan Mallon <[email protected]>:

Quoted 16 lines · Ryan Mallon
Quoted 6 lines · Axel Lin
Quoted 3 lines

ep93xx-fb.c uses interfaces from linux/module.h,
so it should include that file.  This patch fixes below build errors.

Quoted 6 lines

What actually changed to make these files broken? Did some other header previously include module.h for us? How many other drivers are broken?

Anyway, the change is okay.

Actually, having a second look at this it does not look right.

Quoted 7 lines

drivers/video/ep93xx-fb.c includes linux/platform.h (as its first include), which includes linux/driver.h, which includes linux/module.h.

Just tested on Linus' latest tree and both this driver and the ep93xx backlight driver build fine. What kernel version are you using?

~Ryan

hi Ryan,

The patch is against linux-next tree.
I got build error for ep93xx-fb.c and ep93xx_bl.c on linux-next tree. ( next-20110819 )

Regards,
Axel

Quoted 64 lines
Quoted 62 lines
Quoted 61 lines

  CC      drivers/video/ep93xx-fb.o drivers/video/ep93xx-fb.c:120: error: expected ')' before 'int' drivers/video/ep93xx-fb.c:122: error: expected ')' before string constant drivers/video/ep93xx-fb.c:409: error: 'THIS_MODULE' undeclared here (not in a function)
drivers/video/ep93xx-fb.c:645: error: expected declaration specifiers or '...' before string constant
drivers/video/ep93xx-fb.c:645: warning: data definition has no type or storage class
drivers/video/ep93xx-fb.c:645: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION' drivers/video/ep93xx-fb.c:645: warning: function declaration isn't a prototype
drivers/video/ep93xx-fb.c:646: error: expected declaration specifiers or '...' before string constant
drivers/video/ep93xx-fb.c:646: warning: data definition has no type or storage class
drivers/video/ep93xx-fb.c:646: warning: type defaults to 'int' in declaration of 'MODULE_ALIAS'
drivers/video/ep93xx-fb.c:646: warning: function declaration isn't a prototype
drivers/video/ep93xx-fb.c:647: error: expected declaration specifiers or '...' before string constant
drivers/video/ep93xx-fb.c:647: warning: data definition has no type or storage class
drivers/video/ep93xx-fb.c:647: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
drivers/video/ep93xx-fb.c:647: warning: function declaration isn't a prototype
drivers/video/ep93xx-fb.c:649: error: expected declaration specifiers or '...' before string constant
drivers/video/ep93xx-fb.c:649: warning: data definition has no type or storage class
drivers/video/ep93xx-fb.c:649: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE' drivers/video/ep93xx-fb.c:649: warning: function declaration isn't a prototype
make[2]: *** [drivers/video/ep93xx-fb.o] Error 1
make[1]: *** [drivers/video] Error 2
make: *** [drivers] Error 2

---
 drivers/video/ep93xx-fb.c |    1 +

 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/video/ep93xx-fb.c +1 -0
index 40e5f17..8133a9d 100644
@@ -17,6 +17,7 @@
   *
   */
 
+#include<linux/module.h>
  #include<linux/platform_device.h>
  #include<linux/dma-mapping.h>
  #include<linux/slab.h>
#4 lore raw
Quoted 19 lines · Axel Lin

2011/8/22 Ryan Mallon<[email protected]>:

Quoted 18 lines · Ryan Mallon
Quoted 9 lines · Axel Lin
Quoted 2 lines

ep93xx-fb.c uses interfaces from linux/module.h,
so it should include that file. This patch fixes below build errors.

What actually changed to make these files broken? Did some other header previously include module.h for us? How many other drivers are broken?

Anyway, the change is okay.

Actually, having a second look at this it does not look right.

drivers/video/ep93xx-fb.c includes linux/platform.h (as its first include), which includes linux/driver.h, which includes linux/module.h.

Just tested on Linus' latest tree and both this driver and the ep93xx backlight driver build fine. What kernel version are you using?

Quoted 6 lines
Quoted 1 line

~Ryan

hi Ryan,

The patch is against linux-next tree.
I got build error for ep93xx-fb.c and ep93xx_bl.c on linux-next tree. ( next-20110819 )

Ok, I see now. The change which caused the breakage is fdb697c:
"include: replace linux/module.h with "struct module" wherever possible". How many other drivers got broken now that device.h does not include module.h?

~Ryan

Quoted 59 lines
Quoted 59 lines
Quoted 58 lines
Quoted 58 lines

CC drivers/video/ep93xx-fb.o
drivers/video/ep93xx-fb.c:120: error: expected ')' before 'int' drivers/video/ep93xx-fb.c:122: error: expected ')' before string constant drivers/video/ep93xx-fb.c:409: error: 'THIS_MODULE' undeclared here (not in a function)
drivers/video/ep93xx-fb.c:645: error: expected declaration specifiers or '...' before string constant
drivers/video/ep93xx-fb.c:645: warning: data definition has no type or storage class
drivers/video/ep93xx-fb.c:645: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION' drivers/video/ep93xx-fb.c:645: warning: function declaration isn't a prototype
drivers/video/ep93xx-fb.c:646: error: expected declaration specifiers or '...' before string constant
drivers/video/ep93xx-fb.c:646: warning: data definition has no type or storage class
drivers/video/ep93xx-fb.c:646: warning: type defaults to 'int' in declaration of 'MODULE_ALIAS'
drivers/video/ep93xx-fb.c:646: warning: function declaration isn't a prototype
drivers/video/ep93xx-fb.c:647: error: expected declaration specifiers or '...' before string constant
drivers/video/ep93xx-fb.c:647: warning: data definition has no type or storage class
drivers/video/ep93xx-fb.c:647: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
drivers/video/ep93xx-fb.c:647: warning: function declaration isn't a prototype
drivers/video/ep93xx-fb.c:649: error: expected declaration specifiers or '...' before string constant
drivers/video/ep93xx-fb.c:649: warning: data definition has no type or storage class
drivers/video/ep93xx-fb.c:649: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE' drivers/video/ep93xx-fb.c:649: warning: function declaration isn't a prototype
make[2]: *** [drivers/video/ep93xx-fb.o] Error 1
make[1]: *** [drivers/video] Error 2
make: *** [drivers] Error 2

---
  drivers/video/ep93xx-fb.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
drivers/video/ep93xx-fb.c +1 -0
index 40e5f17..8133a9d 100644
@@ -17,6 +17,7 @@
   *
   */
 
+#include<linux/module.h>
  #include<linux/platform_device.h>
  #include<linux/dma-mapping.h>
  #include<linux/slab.h>
Acked-by on v1 1/1
#8 lore raw
In reply to Axel Lin
Quoted 38 lines · Axel Lin

ep93xx-fb.c uses interfaces from linux/module.h,
so it should include that file. This patch fixes below build errors.

CC drivers/video/ep93xx-fb.o
drivers/video/ep93xx-fb.c:120: error: expected ')' before 'int' drivers/video/ep93xx-fb.c:122: error: expected ')' before string constant drivers/video/ep93xx-fb.c:409: error: 'THIS_MODULE' undeclared here (not in a function) drivers/video/ep93xx-fb.c:645: error: expected declaration specifiers or '...' before string constant drivers/video/ep93xx-fb.c:645: warning: data definition has no type or storage class drivers/video/ep93xx-fb.c:645: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION' drivers/video/ep93xx-fb.c:645: warning: function declaration isn't a prototype drivers/video/ep93xx-fb.c:646: error: expected declaration specifiers or '...' before string constant drivers/video/ep93xx-fb.c:646: warning: data definition has no type or storage class drivers/video/ep93xx-fb.c:646: warning: type defaults to 'int' in declaration of 'MODULE_ALIAS' drivers/video/ep93xx-fb.c:646: warning: function declaration isn't a prototype drivers/video/ep93xx-fb.c:647: error: expected declaration specifiers or '...' before string constant drivers/video/ep93xx-fb.c:647: warning: data definition has no type or storage class drivers/video/ep93xx-fb.c:647: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR' drivers/video/ep93xx-fb.c:647: warning: function declaration isn't a prototype drivers/video/ep93xx-fb.c:649: error: expected declaration specifiers or '...' before string constant drivers/video/ep93xx-fb.c:649: warning: data definition has no type or storage class drivers/video/ep93xx-fb.c:649: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE' drivers/video/ep93xx-fb.c:649: warning: function declaration isn't a prototype make[2]: *** [drivers/video/ep93xx-fb.o] Error 1
make[1]: *** [drivers/video] Error 2
make: *** [drivers] Error 2

---
 drivers/video/ep93xx-fb.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/video/ep93xx-fb.c +0 -0
index 40e5f17..8133a9d 100644

drivers/video/ep93xx-fb.c line 23

Quoted 7 lines
drivers/video/ep93xx-fb.c +1 -0
@@ -17,6 +17,7 @@
  *
  */
 
+#include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/dma-mapping.h>
 #include <linux/slab.h>

Same issue as the backlight driver...

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ¥Šwÿº{.nÇ+‰·¥Š{±ıöİzÿâ�Ø^n‡r¡ö¦zË�ëh™¨è­Ú&£ûàz¿äz¹Ş—ú+€Ê+zf£¢·hšˆ§~†­†Ûiÿÿï�êÿ‘êçz_è®æj:+v‰¨ş)ߣøm

#5 lore raw
In reply to Ryan Mallon
Quoted 23 lines · Ryan Mallon
Quoted 22 lines · Axel Lin

2011/8/22 Ryan Mallon<[email protected]>:

Quoted 12 lines · Ryan Mallon
Quoted 9 lines · Axel Lin
Quoted 2 lines

ep93xx-fb.c uses interfaces from linux/module.h,
so it should include that file. This patch fixes below build errors.

What actually changed to make these files broken? Did some other header previously include module.h for us? How many other drivers are broken?

Anyway, the change is okay.

Actually, having a second look at this it does not look right.

Quoted 7 lines

drivers/video/ep93xx-fb.c includes linux/platform.h (as its first include), which includes linux/driver.h, which includes linux/module.h.

Just tested on Linus' latest tree and both this driver and the ep93xx backlight driver build fine. What kernel version are you using?

~Ryan

hi Ryan,

Quoted 8 lines
Quoted 3 lines

The patch is against linux-next tree.
I got build error for ep93xx-fb.c and ep93xx_bl.c on linux-next tree. ( next-20110819 )

Ok, I see now. The change which caused the breakage is fdb697c:
"include: replace linux/module.h with "struct module" wherever possible". How many other drivers got broken now that device.h does not include module.h?

Probably a lot... Which is one of the reasons linux-next exists.. . ;-)

Actually, Paul Gortmaker caused this breakage with the commit. He should take a deeper look and see what it broke. From his commit:

Most of the implicit dependencies on module.h being present by these headers pulling it in have been now weeded out, so we can finally make this change with hopefully minimal breakage.

Regards,
Hartley

#6 lore raw
Quoted 24 lines · H Hartley Sweeten
Quoted 23 lines · Ryan Mallon
Quoted 22 lines · Axel Lin

2011/8/22 Ryan Mallon<[email protected]>:

Quoted 12 lines · Ryan Mallon
Quoted 9 lines · Axel Lin
Quoted 2 lines

ep93xx-fb.c uses interfaces from linux/module.h,
so it should include that file. This patch fixes below build errors.

What actually changed to make these files broken? Did some other header previously include module.h for us? How many other drivers are broken?

Anyway, the change is okay.

Actually, having a second look at this it does not look right.

Quoted 7 lines

drivers/video/ep93xx-fb.c includes linux/platform.h (as its first include), which includes linux/driver.h, which includes linux/module.h.

Just tested on Linus' latest tree and both this driver and the ep93xx backlight driver build fine. What kernel version are you using?

~Ryan

hi Ryan,

Quoted 8 lines
Quoted 7 lines
Quoted 3 lines

The patch is against linux-next tree.
I got build error for ep93xx-fb.c and ep93xx_bl.c on linux-next tree. ( next-20110819 )

Ok, I see now. The change which caused the breakage is fdb697c:
"include: replace linux/module.h with "struct module" wherever possible". How many other drivers got broken now that device.h does not include module.h?

Probably a lot... Which is one of the reasons linux-next exists.. . ;-)

Does anybody know how we can quickly determine which drivers are broken short of doing an allyesconfig? I tried to do some quick tricks by passing files which contain THIS_MODULE/MODULE_* through cpp, but I get loads of errors in headers files because I'm missing some config includes. Is there an easy way to get the kbuild arguments for the current .config so I can pass them to cpp?

Quoted 6 lines

Actually, Paul Gortmaker caused this breakage with the commit. He should take a deeper look and see what it broke. From his commit:

Most of the implicit dependencies on module.h being present by these headers pulling it in have been now weeded out, so we can finally make this change with hopefully minimal breakage.

Quick glance:

ryanm@kiwi:linux-2.6$ grep -lR "^MODULE_" drivers/  | xargs grep -L 
"linux/module.h\|linux/moduleloader.h\|linux/miscdevice.h\|linux/regmap.h\|linux/irq.h"  
| wc -l
579
ryanm@kiwi:linux-2.6$ grep -lR "THIS_MODULE" drivers/ | xargs grep -L 
"linux/module.h\|linux/moduleloader.h\|linux/miscdevice.h\|linux/regmap.h\|linux/irq.h\|linux/export.h\|acpi/platform/aclinux.h\|xen/xenbus.h"   
| wc -l
399

Not sure how many of those are really broken though since there may be a few other ways to include module.h/export.h. I would also think there would be a lot more build failure reports if all of those were broken :-).

~Ryan

#7 lore raw
Quoted 11 lines · Ryan Mallon
Quoted 10 lines · H Hartley Sweeten
Quoted 9 lines · Ryan Mallon
Quoted 8 lines · Axel Lin

2011/8/22 Ryan Mallon<[email protected]>:

Quoted 7 lines · Ryan Mallon
Quoted 6 lines · Axel Lin
Quoted 2 lines

ep93xx-fb.c uses interfaces from linux/module.h,
so it should include that file. This patch fixes below build errors.

What actually changed to make these files broken? Did some other header previously include module.h for us? How many other drivers are broken?

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 3 lines

Anyway, the change is okay.

Actually, having a second look at this it does not look right.

drivers/video/ep93xx-fb.c includes linux/platform.h (as its first include), which includes linux/driver.h, which includes linux/module.h.

For the record, this is exactly what we are trying to fix -- relying on implicit and non-obvious include chaining. If you are writing a modular driver, you should include module.h explicitly.

Quoted 30 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 5 lines

Just tested on Linus' latest tree and both this driver and the ep93xx backlight driver build fine. What kernel version are you using?

~Ryan

hi Ryan,

Quoted 8 lines
Quoted 7 lines
Quoted 3 lines

The patch is against linux-next tree.
I got build error for ep93xx-fb.c and ep93xx_bl.c on linux-next tree. ( next-20110819 )

Ok, I see now. The change which caused the breakage is fdb697c:
"include: replace linux/module.h with "struct module" wherever possible". How many other drivers got broken now that device.h does not include module.h?

Probably a lot... Which is one of the reasons linux-next exists.. . ;-)

Does anybody know how we can quickly determine which drivers are broken short of doing an allyesconfig? I tried to do some quick tricks by passing files which contain THIS_MODULE/MODULE_* through cpp, but I get loads of errors in headers files because I'm missing some config includes. Is there an easy way to get the kbuild arguments for the current .config so I can pass them to cpp?

Quoted 6 lines

Actually, Paul Gortmaker caused this breakage with the commit. He should take a deeper look and see what it broke. From his commit:

Most of the implicit dependencies on module.h being present by these headers pulling it in have been now weeded out, so we can finally make this change with hopefully minimal breakage.

Quoted 6 lines

Quick glance:

ryanm@kiwi:linux-2.6$ grep -lR "^MODULE_" drivers/  | xargs grep -L 
"linux/module.h\|linux/moduleloader.h\|linux/miscdevice.h\|linux/regmap.h\|linux/irq.h"  
| wc -l
579

This can be misleading because subsystems may have a common header that includes module.h, and then all the C files include that common header. I think the e1000 network driver is one example.

Quoted 9 lines
ryanm@kiwi:linux-2.6$ grep -lR "THIS_MODULE" drivers/ | xargs grep -L 
"linux/module.h\|linux/moduleloader.h\|linux/miscdevice.h\|linux/regmap.h\|linux/irq.h\|linux/export.h\|acpi/platform/aclinux.h\|xen/xenbus.h"   
| wc -l
399

Not sure how many of those are really broken though since there may be a few other ways to include module.h/export.h. I would also think there would be a lot more build failure reports if all of those were broken :-).

Exactly. I've done allyesconfig, allnoconfig, allmodconfig builds for all the common arch and even half a dozen or so uncommon arch. Plus in the case of things like arm and powerpc with board specific config files that are in arch/*/configs, I've built all those. So a couple of odd cases like this which don't get build coverage through any of the above was expected, and hence the value of being in linux-next for a while.

Thanks all for the report, I'll make sure these files get the proper include header they need.

Paul.

Quoted 5 lines

~Ryan