dmaengine i.MX DMA/SDMA: add missing include of linux/module.h
Subsystems (2)
PATCH 1/1 dmaengine i.MX DMA/SDMA: add missing include of linux/module.h
Add missing include of linux/module.h to fix build error.
--- drivers/dma/imx-dma.c | 1 + drivers/dma/imx-sdma.c | 1 + 2 files changed, 2 insertions(+), 0 deletions(-)
drivers/dma/imx-dma.c +1 -0
@@ -14,6 +14,7 @@* http://www.gnu.org/copyleft/gpl.html */ #include <linux/init.h> +#include <linux/module.h> #include <linux/types.h> #include <linux/mm.h> #include <linux/interrupt.h>
drivers/dma/imx-sdma.c +1 -0
@@ -18,6 +18,7 @@*/ #include <linux/init.h> +#include <linux/module.h> #include <linux/types.h> #include <linux/mm.h> #include <linux/interrupt.h>
Signature · 1 line
1.7.4.1
Quoted 3 lines · Axel Lin
Add missing include of
linux/module.hto fix build error.Signed-off-by Axel Lin <[email protected]>
Sascha is on holiday, so please accept my:
Quoted 39 lines
--- drivers/dma/imx-dma.c | 1 + drivers/dma/imx-sdma.c | 1 + 2 files changed, 2 insertions(+), 0 deletions(-)drivers/dma/imx-dma.c +1
-0@@ -14,6 +14,7 @@* http://www.gnu.org/copyleft/gpl.html */ #include <linux/init.h> +#include <linux/module.h> #include <linux/types.h> #include <linux/mm.h> #include <linux/interrupt.h> drivers/dma/imx-sdma.c +1
-0@@ -18,6 +18,7 @@*/ #include <linux/init.h> +#include <linux/module.h> #include <linux/types.h> #include <linux/mm.h> #include <linux/interrupt.h> Signature · 9 lines
1.7.4.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Signature · 2 lines
Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
Quoted 1 line · Axel Lin
Add missing include of
linux/module.hto fix build error.
I don't see this build error in my tree (based on rc4), In which config is this seen?
Quoted 31 lines
Signed-off-by Axel Lin <[email protected]>--- drivers/dma/imx-dma.c | 1 + drivers/dma/imx-sdma.c | 1 + 2 files changed, 2 insertions(+), 0 deletions(-)drivers/dma/imx-dma.c +1
-0@@ -14,6 +14,7 @@* http://www.gnu.org/copyleft/gpl.html */ #include <linux/init.h> +#include <linux/module.h> #include <linux/types.h> #include <linux/mm.h> #include <linux/interrupt.h> drivers/dma/imx-sdma.c +1
-0@@ -18,6 +18,7 @@*/ #include <linux/init.h> +#include <linux/module.h> #include <linux/types.h> #include <linux/mm.h> #include <linux/interrupt.h>
Signature · 1 line
~Vinod
2011/9/5 Vinod Koul <[email protected]>:
Quoted 4 lines · Axel Lin
Quoted 1 line
Add missing include of
linux/module.hto fix build error.I don't see this build error in my tree (based on rc4), In which config is this seen?
The patch is against linux-next tree.
I got the build error by "make imx_v4_v5_defconfig" on linux-next tree ( next-20110831 )
Regards,
Axel
Quoted 8 lines · Axel Lin
2011/9/5 Vinod Koul <[email protected]>:
Quoted 4 lines · Axel Lin
Quoted 1 line
Add missing include of
linux/module.hto fix build error.I don't see this build error in my tree (based on rc4), In which config is this seen?
The patch is against linux-next tree.
I got the build error by "makeimx_v4_v5_defconfig" on linux-next tree ( next-20110831 )
Sorry I am not able to find it, can you please point me to archives..
Signature · 1 line
~Vinod
2011/9/5 Vinod Koul <[email protected]>:
Quoted 10 lines · Axel Lin
Quoted 8 lines
2011/9/5 Vinod Koul <[email protected]>:
Quoted 4 lines · Axel Lin
Quoted 1 line
Add missing include of
linux/module.hto fix build error.I don't see this build error in my tree (based on rc4), In which config is this seen?
The patch is against linux-next tree.
I got the build error by "makeimx_v4_v5_defconfig" on linux-next tree ( next-20110831 )Sorry I am not able to find it, can you please point me to archives..
Hi Vinod,
Currently you can get linux-next tree atgit://github.com/sfrothwell/linux-next.git
( http://linux.f-seidel.de/linux-next/pmwiki/pmwiki.php?n=Linux-next.FAQ )
I still got below build error in today's linux-next tree.
CC drivers/dma/imx-sdma.odrivers/dma/imx-sdma.c:336: warning: data definition has no type or storage classdrivers/dma/imx-sdma.c:336: warning: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'drivers/dma/imx-sdma.c:336: warning: parameter names (without types) in function declarationdrivers/dma/imx-sdma.c:343: warning: data definition has no type or storage classdrivers/dma/imx-sdma.c:343: warning: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'drivers/dma/imx-sdma.c:343: warning: parameter names (without types) in function declarationdrivers/dma/imx-sdma.c: In function 'sdma_get_firmware':drivers/dma/imx-sdma.c:1193: error: 'THIS_MODULE' undeclared (first use in this function)drivers/dma/imx-sdma.c:1193: error: (Each undeclared identifier is reported only oncedrivers/dma/imx-sdma.c:1193: error: for each function it appears in.) drivers/dma/imx-sdma.c: At top level:drivers/dma/imx-sdma.c:1457: error: expected declaration specifiers or '...' before string constantdrivers/dma/imx-sdma.c:1457: warning: data definition has no type or storage classdrivers/dma/imx-sdma.c:1457: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'drivers/dma/imx-sdma.c:1457: warning: function declaration isn't a prototype drivers/dma/imx-sdma.c:1458: error: expected declaration specifiers or '...' before string constantdrivers/dma/imx-sdma.c:1458: warning: data definition has no type or storage classdrivers/dma/imx-sdma.c:1458: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'drivers/dma/imx-sdma.c:1458: warning: function declaration isn't a prototype drivers/dma/imx-sdma.c:1459: error: expected declaration specifiers or '...' before string constantdrivers/dma/imx-sdma.c:1459: warning: data definition has no type or storage classdrivers/dma/imx-sdma.c:1459: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'drivers/dma/imx-sdma.c:1459: warning: function declaration isn't a prototype make[2]: *** [drivers/dma/imx-sdma.o] Error 1
make[1]: *** [drivers/dma] Error 2
make: *** [drivers] Error 2
Regards,
Axel
Quoted 53 lines · Axel Lin
2011/9/5 Vinod Koul <[email protected]>:
Quoted 10 lines · Axel Lin
Quoted 8 lines
2011/9/5 Vinod Koul <[email protected]>:
Quoted 4 lines · Axel Lin
Quoted 1 line
Add missing include of
linux/module.hto fix build error.I don't see this build error in my tree (based on rc4), In which config is this seen?
The patch is against linux-next tree.
I got the build error by "makeimx_v4_v5_defconfig" on linux-next tree ( next-20110831 )Sorry I am not able to find it, can you please point me to archives..
Hi Vinod,
Currently you can get linux-next tree atgit://github.com/sfrothwell/linux-next.git
( http://linux.f-seidel.de/linux-next/pmwiki/pmwiki.php?n=Linux-next.FAQ )I still got below build error in today's linux-next tree.
CCdrivers/dma/imx-sdma.odrivers/dma/imx-sdma.c:336: warning: data definition has no type or storage classdrivers/dma/imx-sdma.c:336: warning: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'drivers/dma/imx-sdma.c:336: warning: parameter names (without types) in function declarationdrivers/dma/imx-sdma.c:343: warning: data definition has no type or storage classdrivers/dma/imx-sdma.c:343: warning: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'drivers/dma/imx-sdma.c:343: warning: parameter names (without types) in function declarationdrivers/dma/imx-sdma.c: In function 'sdma_get_firmware':drivers/dma/imx-sdma.c:1193: error: 'THIS_MODULE' undeclared (first use in this function)drivers/dma/imx-sdma.c:1193: error: (Each undeclared identifier is reported only oncedrivers/dma/imx-sdma.c:1193: error: for each function it appears in.)drivers/dma/imx-sdma.c: At top level:drivers/dma/imx-sdma.c:1457: error: expected declaration specifiers or '...' before string constantdrivers/dma/imx-sdma.c:1457: warning: data definition has no type or storage classdrivers/dma/imx-sdma.c:1457: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'drivers/dma/imx-sdma.c:1457: warning: function declaration isn't a prototypedrivers/dma/imx-sdma.c:1458: error: expected declaration specifiers or '...' before string constantdrivers/dma/imx-sdma.c:1458: warning: data definition has no type or storage classdrivers/dma/imx-sdma.c:1458: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'drivers/dma/imx-sdma.c:1458: warning: function declaration isn't a prototypedrivers/dma/imx-sdma.c:1459: error: expected declaration specifiers or '...' before string constant
Quoted 9 lines
drivers/dma/imx-sdma.c:1459: warning: data definition has no type or storage classdrivers/dma/imx-sdma.c:1459: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'drivers/dma/imx-sdma.c:1459: warning: function declaration isn't a prototype make[2]: *** [drivers/dma/imx-sdma.o] Error 1
make[1]: *** [drivers/dma] Error 2
make: *** [drivers] Error 2
Can you pls send me your .config?
Signature · 1 line
~Vinod
Quoted 1 line
Can you pls send me your .config?
I got the error by "make imx_v4_v5_defconfig; make"
It's available in arch/arm/configs/imx_v4_v5_defconfig.
Quoted 4 lines
--
~Vinod
Vinod Koul
AppliedQuoted 4 lines · Axel Lin
Quoted 1 line
Can you pls send me your .config?
I got the error by "make
imx_v4_v5_defconfig; make"It's available in
arch/arm/configs/imx_v4_v5_defconfig.
Applied, Thanks
Signature · 1 line
~Vinod