Skip to contentSkip to conversation

connman: fix typo with -test package

PATCH Superseded Anders Darander 3 participants 4 messages Aug 31, 2011

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 connman: fix typo with -test package

The typo prohibited the connman-tests package from being populated.

---
V2: Bumping PR, as the packaged contents of connman differs.

 meta-oe/recipes-connectivity/connman/connman.inc |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
meta-oe/recipes-connectivity/connman/connman.inc +2 -1
index eeccf50..45916d2 100644
@@ -18,6 +18,7 @@ DEPENDS  = "dbus glib-2.0 ppp busybox dhcp resolvconf iptables gnutls ntp \
             ${@base_contains('DISTRO_FEATURES', 'bluetooth','bluez4', '', d)} \
             ${@base_contains('DISTRO_FEATURES', 'wifi','wpa-supplicant', '', d)} \
             "
+PR = "1"
 
 EXTRA_OECONF += "\
     ac_cv_path_WPASUPPLICANT=/usr/sbin/wpa_supplicant \
@@ -72,7 +73,7 @@ PACKAGES_DYNAMIC = "${PN}-plugin-*"
 PACKAGES =+ "${PN}-scripts ${PN}-tools ${PN}-tests"
 
 FILES_${PN}-tools = "${bindir}/wispr"
-FILES_${PN{-tests = "${bindir}/*-test"
+FILES_${PN}-tests = "${bindir}/*-test"
 FILES_${PN} = "${bindir}/* ${sbindir}/* ${libexecdir}/* ${libdir}/lib*.so.* \
             ${sysconfdir} ${sharedstatedir} ${localstatedir} \
             ${base_bindir}/* ${base_sbindir}/* ${base_libdir}/*.so* ${datadir}/${PN} \
Signature · 1 line
1.7.5.4
#1 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 31-08-11 14:00, Anders Darander schreef:

Quoted 8 lines

The typo prohibited the connman-tests package from being populated.

meta-oe/recipes-connectivity/connman/connman.inc | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)

meta-oe/recipes-connectivity/connman/connman.inc index eeccf50..45916d2 100644 --- a/meta-oe/recipes-connectivity/connman/connman.inc +++ b/meta-oe/recipes-connectivity/connman/connman.inc @@ -18,6 +18,7 @@ DEPENDS = "dbus renamed from meta-oe/recipes-connectivity/connman/connman.inc +0 -0

glib-2.0 ppp busybox dhcp resolvconf iptables gnutls ntp \ ${@base_contains('DISTRO_FEATURES', 'bluetooth','bluez4', '', d)} \ ${@base_contains('DISTRO_FEATURES', 'wifi','wpa-supplicant', '', d)} \ " +PR = "1"

That should go into the .bb, not the .inc

Quoted 4 lines

EXTRA_OECONF += "\ ac_cv_path_WPASUPPLICANT=/usr/sbin/wpa_supplicant \ @@ -72,7 +73,7 @@ PACKAGES_DYNAMIC = "${PN}-plugin-*" PACKAGES =+ "${PN}-scripts ${PN}-tools ${PN}-tests"

FILES_${PN}-tools = "${bindir}/wispr" -FILES_${PN{-tests = "${bindir}/*-test" +FILES_${PN}-tests = "${bindir}/*-test" FILES_${PN} = "${bindir}/* ${sbindir}/* ${libexecdir}/* ${libdir}/lib*.so.* \ ${sysconfdir} ${sharedstatedir} ${localstatedir} \ ${base_bindir}/* ${base_sbindir}/* ${base_libdir}/*.so* ${datadir}/${PN} \

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFOXibQMkyGM64RGpERApteAJ4r2A4z7Pd3nQUwreRj+UyJiSzriACgmi22 ndTJSNjpvW2BWxdsK+QJDYA=
=/Ivi
-----END PGP SIGNATURE-----

#2 lore raw
Quoted 11 lines · Koen Kooi

Op 31-08-11 14:00, Anders Darander schreef:

Quoted 8 lines

The typo prohibited the connman-tests package from being populated.

meta-oe/recipes-connectivity/connman/connman.inc | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)

meta-oe/recipes-connectivity/connman/connman.inc index eeccf50..45916d2 100644 --- a/meta-oe/recipes-connectivity/connman/connman.inc +++ b/meta-oe/recipes-connectivity/connman/connman.inc @@ -18,6 +18,7 @@ DEPENDS = "dbus renamed from meta-oe/recipes-connectivity/connman/connman.inc +0 -0

glib-2.0 ppp busybox dhcp resolvconf iptables gnutls ntp \ ${@base_contains('DISTRO_FEATURES', 'bluetooth','bluez4', '', d)} \ ${@base_contains('DISTRO_FEATURES', 'wifi','wpa-supplicant', '', d)} \ " +PR = "1"

That should go into the .bb, not the .inc

Sure, I'll send an updated patch.

Cheers,
Anders

Signature · 2 lines
Anders Darander
ChargeStorm AB
#3 lore raw
Quoted 1 line · On Wednesday 31 August 2011 13:25:35 Anders Darander wrote:

Sure, I'll send an updated patch.

Also "r1" as opposed to "1".

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre