Skip to contentSkip to conversation

Staging: comedi: Removed unnecessary "extern" from do_become_nonbusy()

PATCH In review Johannes Thumshirn 2 participants 2 messages Sep 4, 2011 – Sep 7, 2011 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: comedi: Removed unnecessary "extern" from do_become_nonbusy()

Removed unnecessary "extern" label from do_become_nonbusy() function to make checkpatch.pl happy

---
 drivers/staging/comedi/comedi_fops.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
drivers/staging/comedi/comedi_fops.c +1 -2
index e90e3cc..c46db8f 100644
@@ -101,8 +101,7 @@ static int do_insn_ioctl(struct comedi_device *dev,
 static int do_poll_ioctl(struct comedi_device *dev, unsigned int subd,
 			 void *file);
 
-extern void do_become_nonbusy(struct comedi_device *dev,
-			      struct comedi_subdevice *s);
+void do_become_nonbusy(struct comedi_device *dev, struct comedi_subdevice *s);
 static int do_cancel(struct comedi_device *dev, struct comedi_subdevice *s);
 
 static int comedi_fasync(int fd, struct file *file, int on);
Signature · 1 line
1.7.4.1
#1 lore raw
Quoted 13 lines · Johannes Thumshirn

Removed unnecessary "extern" label from do_become_nonbusy() function to make checkpatch.pl happy

---
 drivers/staging/comedi/comedi_fops.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
drivers/staging/comedi/comedi_fops.c +0 -0
index e90e3cc..c46db8f 100644

drivers/staging/comedi/comedi_fops.c static int do_insn_ioctl(struct comedi_device *dev, · line 104

Quoted 6 lines
drivers/staging/comedi/comedi_fops.c +1 -2
@@ -101,8 +101,7 @@ static int do_insn_ioctl(struct comedi_device *dev,
 static int do_poll_ioctl(struct comedi_device *dev, unsigned int subd,
 			 void *file);
 
-extern void do_become_nonbusy(struct comedi_device *dev,
-			      struct comedi_subdevice *s);
+void do_become_nonbusy(struct comedi_device *dev, struct comedi_subdevice *s);

This patch does not apply, what tree did you make it against?

Please try it against the latest linux-next tree and resend it.

thanks,

greg k-h