leds: ledtrig-timer: fix broken sysfs delay handling
PATCH 1/1 leds: ledtrig-timer: fix broken sysfs delay handling
Fix regression introduced by commit 5ada28bf76752e33dce3d807bf0dfbe6d1b943ad (led-class: always implement blinking) which broke sysfs delay handling by not storing the updated value. Consequently it was only possible to set one of the delays through the sysfs interface as the other delay was automatically restored to it's default value. Reading the parameters always gave the defaults.
--- drivers/leds/ledtrig-timer.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/leds/ledtrig-timer.c +2 -0
@@ -41,6 +41,7 @@ static ssize_t led_delay_on_store(struct device *dev,if (count == size) {led_blink_set (led_cdev, &state, &led_cdev->blink_delay_off); + led_cdev->blink_delay_on = state; ret = count; }
@@ -69,6 +70,7 @@ static ssize_t led_delay_off_store(struct device *dev,if (count == size) {led_blink_set (led_cdev, &led_cdev->blink_delay_on, &state); + led_cdev->blink_delay_off = state; ret = count; }
Signature · 1 line
1.7.6
Quoted 10 lines · On Monday 05 September 2011 17:33:03 Johan Hovold wrote:
Fix regression introduced by commit
5ada28bf76752e33dce3d807bf0dfbe6d1b943ad(led-class: always implement blinking) which broke sysfs delay handling by not storing the updated value. Consequently it was only possible to set one of the delays through the sysfs interface as the other delay was automatically restored to it's default value. Reading the parameters always gave the defaults.Signed-off-by Johan Hovold <[email protected]>
Quoted 23 lines
--- drivers/leds/ledtrig-timer.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)drivers/leds/ledtrig-timer.c +2
-0@@ -41,6 +41,7 @@ static ssize_t led_delay_on_store(struct device *dev,if (count == size) {led_blink_set (led_cdev, &state, &led_cdev->blink_delay_off); + led_cdev->blink_delay_on = state; ret = count; }@@ -69,6 +70,7 @@ static ssize_t led_delay_off_store(struct device *dev,if (count == size) {led_blink_set (led_cdev, &led_cdev->blink_delay_on, &state); + led_cdev->blink_delay_off = state; ret = count; }
Signature · 1 line
Florian
Richard Purdie
Acked-byQuoted 9 lines · Florian Fainelli
Quoted 8 lines · On Monday 05 September 2011 17:33:03 Johan Hovold wrote:
Fix regression introduced by commit
5ada28bf76752e33dce3d807bf0dfbe6d1b943ad(led-class: always implement blinking) which broke sysfs delay handling by not storing the updated value. Consequently it was only possible to set one of the delays through the sysfs interface as the other delay was automatically restored to it's default value. Reading the parameters always gave the defaults.
Quoted 4 lines
Quoted 2 lines
Signed-off-by Johan Hovold <[email protected]>Acked-by Florian Fainelli <[email protected]>
Quoted 24 lines
Quoted 23 lines
--- drivers/leds/ledtrig-timer.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)drivers/leds/ledtrig-timer.c +2
-0@@ -41,6 +41,7 @@ static ssize_t led_delay_on_store(struct device *dev,if (count == size) {led_blink_set (led_cdev, &state, &led_cdev->blink_delay_off); + led_cdev->blink_delay_on = state; ret = count; }@@ -69,6 +70,7 @@ static ssize_t led_delay_off_store(struct device *dev,if (count == size) {led_blink_set (led_cdev, &led_cdev->blink_delay_on, &state); + led_cdev->blink_delay_off = state; ret = count; }
Quoted 1 line · On Mon, 05 Sep 2011 20:54:50 +0100 Richard Purdie…
Acked-by Richard Purdie <[email protected]>
Y r mssng vwl.
Is [email protected] now your preferred address? Will [email protected] cease to work?
Quoted 6 lines · Andrew Morton
Quoted 1 line · On Mon, 05 Sep 2011 20:54:50 +0100 Richard Purdie…
Acked-by Richard Purdie <[email protected]>Y r mssng vwl.
thx ;-)
Quoted 1 line
Is [email protected] now your preferred address?
Yes.
Quoted 1 line
Will [email protected] cease to work?
No, it will continue to work.
Cheers,
Richard